vlc.git
18 years ago* modules/codec/rawvideo.c: added support for YUY2 and I422 and fixed a bug in FillPi...
Gildas Bazin [Sat, 26 Apr 2003 12:26:46 +0000 (12:26 +0000)]
* modules/codec/rawvideo.c: added support for YUY2 and I422 and fixed a bug in FillPicture(). ( The v4l input is working here now :) )

18 years ago * libmp4: clean up and preliminary work to read mp4 file through http.
Laurent Aimar [Fri, 25 Apr 2003 21:47:25 +0000 (21:47 +0000)]
 * libmp4: clean up and preliminary work to read mp4 file through http.
 * mp4: don't return a failed value when recognize a ref file, but use
a dummy Demux function that return EOF.

18 years ago * ffmpeg: use bigger split size (~8000 samples) as it avoid too much
Laurent Aimar [Fri, 25 Apr 2003 18:57:41 +0000 (18:57 +0000)]
 * ffmpeg: use bigger split size (~8000 samples) as it avoid too much
resampling with my samples. Fix a potential divide by 0 (thx meuuh).

18 years ago *ffmpeg: split huge audio packets as aout didn't like them.
Laurent Aimar [Fri, 25 Apr 2003 17:35:52 +0000 (17:35 +0000)]
 *ffmpeg: split huge audio packets as aout didn't like them.

18 years ago * mms: reduce mtu (avoid too much delay with slow connection)
Laurent Aimar [Fri, 25 Apr 2003 17:33:57 +0000 (17:33 +0000)]
 * mms: reduce mtu (avoid too much delay with slow connection)

18 years ago* modules/gui/skins/src/vlcproc.cpp: small compilation fix.
Gildas Bazin [Fri, 25 Apr 2003 12:37:52 +0000 (12:37 +0000)]
* modules/gui/skins/src/vlcproc.cpp: small compilation fix.

18 years ago * mp4: fix a buffer overflow.
Laurent Aimar [Thu, 24 Apr 2003 20:49:54 +0000 (20:49 +0000)]
 * mp4: fix a buffer overflow.

18 years ago * .cvsignore: forgot this file.
Laurent Aimar [Thu, 24 Apr 2003 20:33:53 +0000 (20:33 +0000)]
 * .cvsignore: forgot this file.

18 years ago * asf: fix to play stream over mmsh.
Laurent Aimar [Thu, 24 Apr 2003 20:26:32 +0000 (20:26 +0000)]
 * asf: fix to play stream over mmsh.

18 years ago * mpeg4video.c: use video size when available from bitmapinfoheader.
Laurent Aimar [Thu, 24 Apr 2003 20:24:44 +0000 (20:24 +0000)]
 * mpeg4video.c: use video size when available from bitmapinfoheader.

18 years ago* src/libvlc.c: forgot to reload the command line options after we reload the main...
Gildas Bazin [Thu, 24 Apr 2003 17:44:53 +0000 (17:44 +0000)]
* src/libvlc.c: forgot to reload the command line options after we reload the main module when the user disables the translation.

18 years ago* Makefile.am: added a dist-hook target to include the auto-generated msvc files...
Gildas Bazin [Thu, 24 Apr 2003 16:13:38 +0000 (16:13 +0000)]
* Makefile.am: added a dist-hook target to include the auto-generated msvc files into the dist. added src/misc/modules_plugins.h to the dist.

18 years ago* modules/gui/skins/src/themeloader.*: dropped the dependancy on libtar
Gildas Bazin [Thu, 24 Apr 2003 15:57:50 +0000 (15:57 +0000)]
* modules/gui/skins/src/themeloader.*: dropped the dependancy on libtar
   for the .vlt skins support. libtar is still used if present, otherwise
   we use our small implementation of untar.

18 years ago * mp4: select only first enabled track.
Laurent Aimar [Thu, 24 Apr 2003 14:39:53 +0000 (14:39 +0000)]
 * mp4: select only first enabled track.

18 years ago* get screen size with gtk2
Cyril Deguet [Thu, 24 Apr 2003 14:38:06 +0000 (14:38 +0000)]
* get screen size with gtk2

18 years ago modules/gui/beos/VlcWrapper.cpp: fixed the issue with untranslated
Eric Petit [Wed, 23 Apr 2003 15:18:24 +0000 (15:18 +0000)]
 modules/gui/beos/VlcWrapper.cpp: fixed the issue with untranslated
  strings and "...". i18n seems OK under BeOS now.

18 years ago* fixed some constructors and destructors
Cyril Deguet [Wed, 23 Apr 2003 10:29:52 +0000 (10:29 +0000)]
* fixed some constructors and destructors

18 years ago* modules/codec/libmpeg2.c: make sure there are no more linked pictures
Gildas Bazin [Tue, 22 Apr 2003 23:31:07 +0000 (23:31 +0000)]
* modules/codec/libmpeg2.c: make sure there are no more linked pictures
   left when closing the decoder.

18 years ago * ./modules/gui/skins/src/theme.cpp: fixed a bug with anchored windows
Olivier Teulière [Tue, 22 Apr 2003 22:57:40 +0000 (22:57 +0000)]
 * ./modules/gui/skins/src/theme.cpp: fixed a bug with anchored windows

18 years ago* modules/audio_filter/converter/s16tofloat32swab.c:
Gildas Bazin [Tue, 22 Apr 2003 22:25:09 +0000 (22:25 +0000)]
* modules/audio_filter/converter/s16tofloat32swab.c:
   added an #ifdef HAVE_ALLOCA.

18 years ago* configure.ac.in: don't link with the math library on win32. It isn't
Gildas Bazin [Tue, 22 Apr 2003 21:45:42 +0000 (21:45 +0000)]
* configure.ac.in: don't link with the math library on win32. It isn't
   needed and will even screw up things under cygwin with -mno-cygwin.

18 years ago* output.c: avoid a floating point exception when aout-rate==0
Cyril Deguet [Tue, 22 Apr 2003 19:26:02 +0000 (19:26 +0000)]
* output.c: avoid a floating point exception when aout-rate==0
* gtk2_api.cpp: made valgrind happy ;)

18 years ago * ./modules/gui/wxwindows/fileinfo.cpp: cosmetic changes
Olivier Teulière [Tue, 22 Apr 2003 18:21:15 +0000 (18:21 +0000)]
 * ./modules/gui/wxwindows/fileinfo.cpp: cosmetic changes

18 years ago* fixed the volume slider bug
Cyril Deguet [Tue, 22 Apr 2003 17:56:44 +0000 (17:56 +0000)]
* fixed the volume slider bug

18 years ago * Makefile.am: fixed 'make package-beos'
Eric Petit [Tue, 22 Apr 2003 16:36:16 +0000 (16:36 +0000)]
 * Makefile.am: fixed 'make package-beos'
 * modules/gui/beos/*: added _()s so the whole interface is translated
 * src/libvlc.c: ask gettext for UTF-8 strings (under BeOS only for now)
   FIXME: currently, untranslated strings are not converted to UTF-8

18 years ago * mp4: fix "mov playlist" handling. (raaah strncpy doesn't add '\0' :(
Laurent Aimar [Tue, 22 Apr 2003 16:28:24 +0000 (16:28 +0000)]
 * mp4: fix "mov playlist" handling. (raaah strncpy doesn't add '\0' :(

18 years ago* modules/codec/libmpeg2.c: fixed aspect ratio problem.
Gildas Bazin [Tue, 22 Apr 2003 12:54:49 +0000 (12:54 +0000)]
* modules/codec/libmpeg2.c: fixed aspect ratio problem.

18 years ago * mp4: preliminary support of "mov playlist(ref) file"
Laurent Aimar [Tue, 22 Apr 2003 11:38:25 +0000 (11:38 +0000)]
 * mp4: preliminary support of "mov playlist(ref) file"

18 years ago * mp4: more mov fields are parsed.
Laurent Aimar [Tue, 22 Apr 2003 08:51:28 +0000 (08:51 +0000)]
 * mp4: more mov fields are parsed.

18 years ago* changed "Font" into "SkinFont" (see previous commit)
Cyril Deguet [Mon, 21 Apr 2003 22:12:37 +0000 (22:12 +0000)]
* changed "Font" into "SkinFont" (see previous commit)

18 years ago* changed "Window" into "SkinWindow" to prepare X11 port
Cyril Deguet [Mon, 21 Apr 2003 21:51:16 +0000 (21:51 +0000)]
* changed "Window" into "SkinWindow" to prepare X11 port
 (Window is already a Xlib type !)
  *** not tested under win32, please check ! ***

18 years ago* at last fixed transparency under linux !!
Cyril Deguet [Mon, 21 Apr 2003 18:39:39 +0000 (18:39 +0000)]
* at last fixed transparency under linux !!

18 years ago*All: fixed unwanted fileinfo window refresh under windows.
Anil Daoud [Mon, 21 Apr 2003 16:55:53 +0000 (16:55 +0000)]
*All: fixed unwanted fileinfo window refresh under windows.

18 years ago* modules/misc/network/ipv4.c: a bit of cleanup.
Gildas Bazin [Mon, 21 Apr 2003 16:22:43 +0000 (16:22 +0000)]
* modules/misc/network/ipv4.c: a bit of cleanup.

18 years ago* raise the skin window on top when clicked
Cyril Deguet [Mon, 21 Apr 2003 14:26:59 +0000 (14:26 +0000)]
* raise the skin window on top when clicked
* a bit of code cleaning

18 years ago* configure.ac.in: print an error message if libmpeg2 is not found or too old.
Gildas Bazin [Mon, 21 Apr 2003 12:54:08 +0000 (12:54 +0000)]
* configure.ac.in: print an error message if libmpeg2 is not found or too old.

18 years ago* configure.ac.in: the libmpeg2 plugin is now enabled by default when the right versi...
Gildas Bazin [Mon, 21 Apr 2003 12:22:54 +0000 (12:22 +0000)]
* configure.ac.in: the libmpeg2 plugin is now enabled by default when the right version of libmpeg2 is detected (0.3.2 aka cvs).

18 years ago* added a preferences button in the default skin
Cyril Deguet [Mon, 21 Apr 2003 11:47:22 +0000 (11:47 +0000)]
* added a preferences button in the default skin

18 years ago* fixed the previous commit for linux
Cyril Deguet [Mon, 21 Apr 2003 03:37:40 +0000 (03:37 +0000)]
* fixed the previous commit for linux

18 years ago* fixed a timing issue under windows ?
Cyril Deguet [Mon, 21 Apr 2003 02:50:49 +0000 (02:50 +0000)]
* fixed a timing issue under windows ?

18 years ago * we now use a wxwindow dialog to load the skins, so we can get rid
Olivier Teulière [Mon, 21 Apr 2003 02:12:06 +0000 (02:12 +0000)]
 * we now use a wxwindow dialog to load the skins, so we can get rid
   of our custom dialog

18 years ago* shortcut handling under linux
Cyril Deguet [Mon, 21 Apr 2003 01:47:42 +0000 (01:47 +0000)]
* shortcut handling under linux

18 years ago * added preferences, file info and stream output dialogs to the skins
Olivier Teulière [Mon, 21 Apr 2003 00:54:26 +0000 (00:54 +0000)]
 * added preferences, file info and stream output dialogs to the skins

18 years ago* configure.ac.in : finished disabling the old mpeg_video plug-ins.
Christophe Massiot [Mon, 21 Apr 2003 00:33:29 +0000 (00:33 +0000)]
* configure.ac.in : finished disabling the old mpeg_video plug-ins.

18 years ago* fixed refresh of the playlist (and a segfault...)
Cyril Deguet [Mon, 21 Apr 2003 00:18:37 +0000 (00:18 +0000)]
* fixed refresh of the playlist (and a segfault...)

18 years ago* modules/codec/libmpeg2.c: fixed a problem with some frame rates (thx
Christophe Massiot [Sun, 20 Apr 2003 23:42:17 +0000 (23:42 +0000)]
* modules/codec/libmpeg2.c: fixed a problem with some frame rates (thx
  gibalou)

18 years ago* fixed a segfault at exit
Cyril Deguet [Sun, 20 Apr 2003 23:09:31 +0000 (23:09 +0000)]
* fixed a segfault at exit

18 years ago* a few segfaults but wxwindows works under linux !
Cyril Deguet [Sun, 20 Apr 2003 22:52:50 +0000 (22:52 +0000)]
* a few segfaults but wxwindows works under linux !

18 years ago* modules/audio_output/file.c: fixed a mismatch in a config name.
Gildas Bazin [Sun, 20 Apr 2003 22:52:03 +0000 (22:52 +0000)]
* modules/audio_output/file.c: fixed a mismatch in a config name.

18 years ago * ./modules/audio_output/oss.c: code comments.
Sam Hocevar [Sun, 20 Apr 2003 21:19:41 +0000 (21:19 +0000)]
  * ./modules/audio_output/oss.c: code comments.

18 years ago * ./modules/video_output/fb.c: fixed a bug that prevented proper console
Sam Hocevar [Sun, 20 Apr 2003 21:15:31 +0000 (21:15 +0000)]
  * ./modules/video_output/fb.c: fixed a bug that prevented proper console
    resetting.

18 years ago * ./mozilla/npvlc_rc.rc: fixed a typo in the MIME types.
Sam Hocevar [Sun, 20 Apr 2003 21:14:20 +0000 (21:14 +0000)]
  * ./mozilla/npvlc_rc.rc: fixed a typo in the MIME types.

18 years ago * added wxwindows Open and Messages dialog boxes into the windows skins
Olivier Teulière [Sun, 20 Apr 2003 20:28:40 +0000 (20:28 +0000)]
 * added wxwindows Open and Messages dialog boxes into the windows skins
   (it may break things on linux...)

18 years ago* added wxwindows for skins !!
Cyril Deguet [Sun, 20 Apr 2003 20:22:12 +0000 (20:22 +0000)]
* added wxwindows for skins !!

18 years ago* configure.ac.in: removed useless --with-ffmpeg=PATH ./configure option.
Gildas Bazin [Sun, 20 Apr 2003 19:53:57 +0000 (19:53 +0000)]
* configure.ac.in: removed useless --with-ffmpeg=PATH ./configure option.

18 years ago * mms/* : begining of a m$-http-for-asf-streaming support.
Laurent Aimar [Sun, 20 Apr 2003 19:29:43 +0000 (19:29 +0000)]
 * mms/* : begining of a m$-http-for-asf-streaming support.
 Proxy aren't yet supported. Use mmsh to force it, else mms will try it
at the end (after mmst and mmsu). Some http url are in fact mmsh but
not yet auto-detected.
 *Please report* not working url and any regression for mmst and mmsu.

18 years ago * ./modules/gui/skins/src/themeloader.cpp: compile fix (include errno.h)
Jon Lech Johansen [Sun, 20 Apr 2003 19:03:15 +0000 (19:03 +0000)]
  * ./modules/gui/skins/src/themeloader.cpp: compile fix (include errno.h)

18 years ago* Fixed mouse wheel
Emmanuel Puig [Sun, 20 Apr 2003 16:45:44 +0000 (16:45 +0000)]
* Fixed mouse wheel

18 years ago* fixed the "always on top" bug
Cyril Deguet [Sun, 20 Apr 2003 16:16:34 +0000 (16:16 +0000)]
* fixed the "always on top" bug

18 years ago* Added support of wheel with win32
Emmanuel Puig [Sun, 20 Apr 2003 15:06:07 +0000 (15:06 +0000)]
* Added support of wheel with win32

18 years ago* Fixed support of wheel for playlist with GTK2
Emmanuel Puig [Sun, 20 Apr 2003 15:00:19 +0000 (15:00 +0000)]
* Fixed support of wheel for playlist with GTK2
* Added support of whell for slider with GTK2

18 years ago* configure.ac.in, modules/codec/ffmpeg/ffmpeg.c: fixed my last breakage in the ffmpe...
Gildas Bazin [Sun, 20 Apr 2003 14:11:25 +0000 (14:11 +0000)]
* configure.ac.in, modules/codec/ffmpeg/ffmpeg.c: fixed my last breakage in the ffmpeg detection code.

18 years ago* enabled scrolling in the playlist with the mouse wheel
Cyril Deguet [Sun, 20 Apr 2003 13:14:14 +0000 (13:14 +0000)]
* enabled scrolling in the playlist with the mouse wheel

18 years ago* The libmpeg2 plug-in is now completely operational ;
Christophe Massiot [Sun, 20 Apr 2003 12:59:02 +0000 (12:59 +0000)]
* The libmpeg2 plug-in is now completely operational ;
* configure.ac.in : disabled compiling the old mpeg_video plug-in, so :
DO NOT FORGET TO INSTALL LIBMPEG2 AND COMPILE WITH --enable-libmpeg2

18 years ago* configure.ac.in, modules/codec/ffmpeg/*, modules/encoder/ffmpeg/*, modules/stream_o...
Gildas Bazin [Sun, 20 Apr 2003 11:57:13 +0000 (11:57 +0000)]
* configure.ac.in, modules/codec/ffmpeg/*, modules/encoder/ffmpeg/*, modules/stream_out/transcode.c: fixed detection of the ffmpeg headers/libs when they are installed in their default location.

18 years ago* fixed a typo with dvbpsi
Cyril Deguet [Sun, 20 Apr 2003 01:05:40 +0000 (01:05 +0000)]
* fixed a typo with dvbpsi

18 years ago* Added a 'opaqueness' configoption to macosx-vout. Yeah i know, useles.
Derk-Jan Hartman [Sat, 19 Apr 2003 13:55:56 +0000 (13:55 +0000)]
* Added a 'opaqueness' configoption to macosx-vout. Yeah i know, useles.
  But it's coooooool. http://sidekick.student.utwente.nl/videolan/transparent.jpg

18 years ago* Font fixed
Emmanuel Puig [Sat, 19 Apr 2003 12:39:14 +0000 (12:39 +0000)]
* Font fixed

18 years ago* There was a problem where deinterlace could not be turned off via it's
Derk-Jan Hartman [Sat, 19 Apr 2003 12:33:01 +0000 (12:33 +0000)]
* There was a problem where deinterlace could not be turned off via it's
  corresponding menu. On thy fly filter changes are still not possible.

18 years ago* fixed a segfault
Cyril Deguet [Sat, 19 Apr 2003 11:46:11 +0000 (11:46 +0000)]
* fixed a segfault

18 years ago* drag&drop works ! (at least with mozilla)
Cyril Deguet [Sat, 19 Apr 2003 11:16:17 +0000 (11:16 +0000)]
* drag&drop works ! (at least with mozilla)

18 years ago* Fixed wrapping for texts
Emmanuel Puig [Sat, 19 Apr 2003 02:34:47 +0000 (02:34 +0000)]
* Fixed wrapping for texts
* Filling GTK2Graphics and GTK2Region destructors

18 years ago * mp4: some memory leaks fixed.
Laurent Aimar [Sat, 19 Apr 2003 00:12:50 +0000 (00:12 +0000)]
 * mp4: some memory leaks fixed.

18 years ago * ./configure.ac.in: workaround for a bug in the OS X ld who sees symbol
Sam Hocevar [Fri, 18 Apr 2003 22:51:59 +0000 (22:51 +0000)]
  * ./configure.ac.in: workaround for a bug in the OS X ld who sees symbol
    redefinitions when linking twice with the same static libary.

18 years ago * mp4.c : begining of a mp4/mov muxer.
Laurent Aimar [Fri, 18 Apr 2003 22:43:08 +0000 (22:43 +0000)]
 * mp4.c : begining of a mp4/mov muxer.

 It's far from stable, produce file unplayable by mplayer at least,
and doesn't yet take care of video/audio synchro.
Becarefull that the header is written only when closing, and there is
no way to repair a mp4 file without its header.

18 years ago * stream_output.c: add a vlc_mutex_lock/unlock ...
Laurent Aimar [Fri, 18 Apr 2003 22:38:11 +0000 (22:38 +0000)]
 * stream_output.c: add a vlc_mutex_lock/unlock ...

18 years ago Added a few keyboard shortcuts
Eric Petit [Fri, 18 Apr 2003 19:26:38 +0000 (19:26 +0000)]
 Added a few keyboard shortcuts

18 years ago Under BeOS, disable the screensaver if playing in fullscreen.
Eric Petit [Fri, 18 Apr 2003 16:38:58 +0000 (16:38 +0000)]
 Under BeOS, disable the screensaver if playing in fullscreen.

18 years ago beos/*: fixed fullscreen shortcuts
Eric Petit [Fri, 18 Apr 2003 16:10:28 +0000 (16:10 +0000)]
 beos/*: fixed fullscreen shortcuts

18 years ago* network stream now work
Cyril Deguet [Fri, 18 Apr 2003 16:04:17 +0000 (16:04 +0000)]
* network stream now work
* double-click is now implemented

18 years ago ALL: fixed i18n under BeOS
Eric Petit [Fri, 18 Apr 2003 15:25:51 +0000 (15:25 +0000)]
 ALL: fixed i18n under BeOS

18 years ago* Ask tooney to know ! (fix minor bug)
Emmanuel Puig [Thu, 17 Apr 2003 19:56:31 +0000 (19:56 +0000)]
* Ask tooney to know ! (fix minor bug)

18 years ago* small fix
Cyril Deguet [Thu, 17 Apr 2003 17:45:38 +0000 (17:45 +0000)]
* small fix

18 years ago* Scrolling text now works on linux
Emmanuel Puig [Thu, 17 Apr 2003 16:34:31 +0000 (16:34 +0000)]
* Scrolling text now works on linux

18 years ago* Fixed kludge
Emmanuel Puig [Thu, 17 Apr 2003 16:32:14 +0000 (16:32 +0000)]
* Fixed kludge

18 years ago* Added AddEllipse: the slider now works ! :)
Emmanuel Puig [Thu, 17 Apr 2003 16:30:40 +0000 (16:30 +0000)]
* Added AddEllipse: the slider now works ! :)

18 years ago* Added clip region to graphics
Emmanuel Puig [Thu, 17 Apr 2003 16:11:46 +0000 (16:11 +0000)]
* Added clip region to graphics
* Added functionnality to region

18 years ago* Improved font support for linux (just missing underline parameter )
Emmanuel Puig [Thu, 17 Apr 2003 15:43:30 +0000 (15:43 +0000)]
* Improved font support for linux (just missing underline parameter )

18 years ago* oups forgot to commit this one. still the hide/show thing.
Anil Daoud [Thu, 17 Apr 2003 14:18:47 +0000 (14:18 +0000)]
* oups forgot to commit this one. still the hide/show thing.

18 years ago* We now use hide/show for the file info window
Anil Daoud [Thu, 17 Apr 2003 14:00:44 +0000 (14:00 +0000)]
* We now use hide/show for the file info window

18 years ago* Can get size of a text
Emmanuel Puig [Thu, 17 Apr 2003 13:46:55 +0000 (13:46 +0000)]
* Can get size of a text

18 years ago* SkinManage is called by a timer
Emmanuel Puig [Thu, 17 Apr 2003 13:08:02 +0000 (13:08 +0000)]
* SkinManage is called by a timer
* Timer for text control are working badly but it's the first step

18 years ago * ffmpeg: remove some #ifdef (you need at least libavcodec build >= 4655)
Laurent Aimar [Thu, 17 Apr 2003 10:58:30 +0000 (10:58 +0000)]
 * ffmpeg: remove some #ifdef (you need at least libavcodec build >= 4655)
and use ffmpeg postprocessing instead of vlc builtins. (It's a lot faster).

18 years ago* Fixed dewtructor
Emmanuel Puig [Thu, 17 Apr 2003 10:53:00 +0000 (10:53 +0000)]
* Fixed dewtructor

18 years ago* beginning of font support !
Cyril Deguet [Thu, 17 Apr 2003 10:42:41 +0000 (10:42 +0000)]
* beginning of font support !

18 years ago* gtk2_theme.cpp: window are not automatically visibled
Emmanuel Puig [Wed, 16 Apr 2003 21:50:19 +0000 (21:50 +0000)]
* gtk2_theme.cpp: window are not automatically visibled
* gtk2_window.cpp: removed fading transition delay
* vlcproc.cpp: removed warning

18 years ago * modules/gui/skins/*: we now #include skin files using a relative
Olivier Teulière [Wed, 16 Apr 2003 21:40:07 +0000 (21:40 +0000)]
 *  modules/gui/skins/*: we now #include skin files using a relative
    path, so that MSVC is happy :)

18 years ago* Removed debug calls
Emmanuel Puig [Wed, 16 Apr 2003 21:39:00 +0000 (21:39 +0000)]
* Removed debug calls

18 years ago* Can now quit the interface
Emmanuel Puig [Wed, 16 Apr 2003 21:30:56 +0000 (21:30 +0000)]
* Can now quit the interface

18 years ago* gtk2_bitmap.cpp: fixed constructor bug
Emmanuel Puig [Wed, 16 Apr 2003 19:22:53 +0000 (19:22 +0000)]
* gtk2_bitmap.cpp: fixed constructor bug
* Events work better: controls are working, not still perfectly...