From: Rémi Denis-Courmont Date: Mon, 8 Sep 2008 16:07:13 +0000 (+0300) Subject: Remove dummy usage of vlc_thread_ready() X-Git-Tag: 1.0.0-pre1~3432 X-Git-Url: https://git.videolan.org/gitweb.cgi/vlc.git/?p=vlc.git;p=vlc.git;a=commitdiff_plain;h=8161681ded5bfb62950386dad97a33c41bb414d8 Remove dummy usage of vlc_thread_ready() It only makes sense if the thread actually initializes something. --- diff --git a/src/input/input.c b/src/input/input.c index 1feaf8679a..aa85dd2eec 100644 --- a/src/input/input.c +++ b/src/input/input.c @@ -370,7 +370,7 @@ input_thread_t *__input_CreateThreadExtended( vlc_object_t *p_parent, /* Create thread and wait for its readiness. */ if( vlc_thread_create( p_input, "input", Run, - VLC_THREAD_PRIORITY_INPUT, true ) ) + VLC_THREAD_PRIORITY_INPUT, false ) ) { input_ChangeState( p_input, ERROR_S ); msg_Err( p_input, "cannot create input thread" ); @@ -408,7 +408,7 @@ int __input_Read( vlc_object_t *p_parent, input_item_t *p_item, else { if( vlc_thread_create( p_input, "input", RunAndDestroy, - VLC_THREAD_PRIORITY_INPUT, true ) ) + VLC_THREAD_PRIORITY_INPUT, false ) ) { input_ChangeState( p_input, ERROR_S ); msg_Err( p_input, "cannot create input thread" ); @@ -495,9 +495,6 @@ static void* Run( vlc_object_t *p_this ) input_thread_t *p_input = (input_thread_t *)p_this; const int canc = vlc_savecancel(); - /* Signal that the thread is launched */ - vlc_thread_ready( p_input ); - if( Init( p_input ) ) { /* If we failed, wait before we are killed, and exit */ @@ -530,9 +527,6 @@ static void* RunAndDestroy( vlc_object_t *p_this ) input_thread_t *p_input = (input_thread_t *)p_this; const int canc = vlc_savecancel(); - /* Signal that the thread is launched */ - vlc_thread_ready( p_input ); - if( Init( p_input ) ) goto exit; diff --git a/src/playlist/thread.c b/src/playlist/thread.c index 67624e0c07..7be2d0d5de 100644 --- a/src/playlist/thread.c +++ b/src/playlist/thread.c @@ -76,7 +76,7 @@ void __playlist_ThreadCreate( vlc_object_t *p_parent ) vlc_object_attach( p_playlist->p->p_preparse, p_playlist ); if( vlc_thread_create( p_playlist->p->p_preparse, "preparser", - RunPreparse, VLC_THREAD_PRIORITY_LOW, true ) ) + RunPreparse, VLC_THREAD_PRIORITY_LOW, false ) ) { msg_Err( p_playlist, "cannot spawn preparse thread" ); vlc_object_release( p_playlist->p->p_preparse ); @@ -105,7 +105,7 @@ void __playlist_ThreadCreate( vlc_object_t *p_parent ) if( vlc_thread_create( p_playlist->p->p_fetcher, "fetcher", RunFetcher, - VLC_THREAD_PRIORITY_LOW, true ) ) + VLC_THREAD_PRIORITY_LOW, false ) ) { msg_Err( p_playlist, "cannot spawn secondary preparse thread" ); vlc_object_release( p_playlist->p->p_fetcher ); @@ -114,7 +114,7 @@ void __playlist_ThreadCreate( vlc_object_t *p_parent ) // Start the thread if( vlc_thread_create( p_playlist, "playlist", RunControlThread, - VLC_THREAD_PRIORITY_LOW, true ) ) + VLC_THREAD_PRIORITY_LOW, false ) ) { msg_Err( p_playlist, "cannot spawn playlist thread" ); vlc_object_release( p_playlist ); @@ -133,8 +133,6 @@ void __playlist_ThreadCreate( vlc_object_t *p_parent ) static void* RunControlThread ( vlc_object_t *p_this ) { playlist_t *p_playlist = (playlist_t*)p_this; - /* Tell above that we're ready */ - vlc_thread_ready( p_playlist ); int canc = vlc_savecancel (); vlc_object_lock( p_playlist ); @@ -176,8 +174,6 @@ static void* RunPreparse ( vlc_object_t *p_this ) playlist_preparse_t *p_obj = (playlist_preparse_t*)p_this; int canc; - /* Tell above that we're ready */ - vlc_thread_ready( p_obj ); canc = vlc_savecancel (); playlist_PreparseLoop( p_obj ); vlc_restorecancel (canc); @@ -187,8 +183,6 @@ static void* RunPreparse ( vlc_object_t *p_this ) static void* RunFetcher( vlc_object_t *p_this ) { playlist_fetcher_t *p_obj = (playlist_fetcher_t *)p_this; - /* Tell above that we're ready */ - vlc_thread_ready( p_obj ); int canc = vlc_savecancel (); playlist_FetcherLoop( p_obj ); vlc_restorecancel (canc);