vlc.git
2 years agochromecast: refactor out encoder option functions
Shaleen Jain [Wed, 28 Nov 2018 06:23:36 +0000 (11:53 +0530)]
chromecast: refactor out encoder option functions

Signed-off-by: Thomas Guillem <thomas@gllm.fr>
Signed-off-by: Hugo Beauzée-Luyssen <hugo@beauzee.fr>
2 years agochroma: d3d11: Silence unused parameters warnings
Hugo Beauzée-Luyssen [Thu, 10 Jan 2019 09:01:37 +0000 (10:01 +0100)]
chroma: d3d11: Silence unused parameters warnings

2 years agochroma: d3d11: Fix winstore build
Hugo Beauzée-Luyssen [Thu, 10 Jan 2019 09:01:03 +0000 (10:01 +0100)]
chroma: d3d11: Fix winstore build

2 years agochromecast: fix invalid corks state
Thomas Guillem [Wed, 9 Jan 2019 13:52:19 +0000 (14:52 +0100)]
chromecast: fix invalid corks state

It happened when the chromecast was switching to the buffering state from the
playing state.

2 years agodav1d/aom: forward the colorimetry metadata from the container to the output
Steve Lhomme [Wed, 9 Jan 2019 10:30:58 +0000 (11:30 +0100)]
dav1d/aom: forward the colorimetry metadata from the container to the output

If there is none and the stream contains some, it will be overridden in
NewPicture() otherwise the container values are used.

Fixes #21578

2 years agodav1d: handle 10/12 bits greyscale pixel formats
Steve Lhomme [Wed, 9 Jan 2019 09:57:50 +0000 (10:57 +0100)]
dav1d: handle 10/12 bits greyscale pixel formats

Co-authored-by: James Almer <jamrial@gmail.com>
2 years agoavcodec: map 10/12 bits greyscale pixel formats
Steve Lhomme [Wed, 9 Jan 2019 09:56:53 +0000 (10:56 +0100)]
avcodec: map 10/12 bits greyscale pixel formats

2 years agofourcc: add 10 bits / 12 bits greyscale chroma
Steve Lhomme [Wed, 9 Jan 2019 09:51:51 +0000 (10:51 +0100)]
fourcc: add 10 bits / 12 bits greyscale chroma

2 years agodav1d: add support for 12 bits sources
Steve Lhomme [Wed, 9 Jan 2019 09:10:42 +0000 (10:10 +0100)]
dav1d: add support for 12 bits sources

Co-authored-by: James Almer <jamrial@gmail.com>
Fixes #21670

2 years agocontrib: aom: do not force generic target
Tristan Matthews [Tue, 8 Jan 2019 17:28:54 +0000 (12:28 -0500)]
contrib: aom: do not force generic target

This is the default for the av1-normative branch.

2 years agocontrib: aom: reenable multithreading
Tristan Matthews [Tue, 8 Jan 2019 17:27:58 +0000 (12:27 -0500)]
contrib: aom: reenable multithreading

This is default disabled in av1-normative.

2 years agodemux: wav: fix uninitialized member usage (cid #1476075)
Francois Cartegnie [Tue, 8 Jan 2019 16:01:21 +0000 (17:01 +0100)]
demux: wav: fix uninitialized member usage (cid #1476075)

2 years agopacketizer/av1: Fix size calculation in AV1_OBUSkipHeader
Marvin Scholz [Thu, 29 Nov 2018 14:53:14 +0000 (15:53 +0100)]
packetizer/av1: Fix size calculation in AV1_OBUSkipHeader

In case that AV1_OBUHasSizeField is false, i_header was used
uninitialized. The OBU header is always at least 1 byte and
the extension field is unrelated to the fact if a size field
exists or not.

Signed-off-by: Francois Cartegnie <fcvlcdev@free.fr>
2 years agoplaylist: remove incorrect comment
Romain Vimont [Tue, 27 Nov 2018 09:55:37 +0000 (10:55 +0100)]
playlist: remove incorrect comment

The player behavior has changed since this comment was written, now the
on_current_media_changed callback is called even on SetCurrentItem().

Signed-off-by: Thomas Guillem <thomas@gllm.fr>
2 years agocore: playlist: keep current item on expand
Romain Vimont [Tue, 11 Dec 2018 14:22:13 +0000 (15:22 +0100)]
core: playlist: keep current item on expand

When an item is expanded (e.g. due to preparsing), it is replaced by its
(flatten) subitems.

The previous implementation first removed the item, then inserted its
subitems. As a consequence of the removal, the current index was reset
and the player was stopped.

Since we don't want to stop the player on item expansion, instead,
replace the item by its first subitem (if any), then insert the
remaining subitems.

Signed-off-by: Thomas Guillem <thomas@gllm.fr>
2 years agocore: playlist: refactor current media update
Romain Vimont [Tue, 11 Dec 2018 14:22:12 +0000 (15:22 +0100)]
core: playlist: refactor current media update

The actions to execute after a content change were factorized in
separate functions (vlc_playlist_ItemsInserted(), etc.).

These functions also updated the current media on the player. Instead,
update it separately, so that we can make several changes while
updating/invalidating the current media only once.

This paves the way to improve the implementation of
vlc_playlist_Expand().

Signed-off-by: Thomas Guillem <thomas@gllm.fr>
2 years agocore: playlist: move Expand() to content.c
Romain Vimont [Tue, 11 Dec 2018 14:22:11 +0000 (15:22 +0100)]
core: playlist: move Expand() to content.c

Expanding an item (replacing it by its subitems) was implemented in
preparse.c, essentially because it's only used for preparsing.

For consistency, implement all functions changing the content of the
playlist in content.c. This avoids to expose internal functions
like vlc_playlist_ItemsInserted().

Signed-off-by: Thomas Guillem <thomas@gllm.fr>
2 years agodxva2: clean device checking when getting the decoder surface
Steve Lhomme [Tue, 8 Jan 2019 10:29:32 +0000 (11:29 +0100)]
dxva2: clean device checking when getting the decoder surface

2 years agoavcodec: va: document the returned type of the get() callback
Steve Lhomme [Tue, 8 Jan 2019 10:16:11 +0000 (11:16 +0100)]
avcodec: va: document the returned type of the get() callback

The picture is not being allocated, nor the surface. It's only about getting
the proper surface for lavc.

2 years agod3d11: cleaner split of the (non)winstore code
Steve Lhomme [Tue, 8 Jan 2019 09:36:46 +0000 (10:36 +0100)]
d3d11: cleaner split of the (non)winstore code

2 years agod3d11: log possible failures to read the driver version
Steve Lhomme [Tue, 8 Jan 2019 09:32:49 +0000 (10:32 +0100)]
d3d11: log possible failures to read the driver version

2 years agocontrib: bluray: Add an explicit path to find shared libraries
David Fuhrmann [Mon, 7 Jan 2019 18:43:17 +0000 (19:43 +0100)]
contrib: bluray: Add an explicit path to find shared libraries

This is needed because runtime hardening does not automatically look
for libraries outside of the own application bundle anymore.

2 years agocontrib: aom: update to latest tag
Tristan Matthews [Fri, 4 Jan 2019 17:26:04 +0000 (12:26 -0500)]
contrib: aom: update to latest tag

2 years agobluray: don't use a region if it's not allocated
Steve Lhomme [Mon, 7 Jan 2019 11:27:33 +0000 (12:27 +0100)]
bluray: don't use a region if it's not allocated

2 years agoFix syntax error
Rémi Denis-Courmont [Sat, 5 Jan 2019 10:00:00 +0000 (12:00 +0200)]
Fix syntax error

2 years agocontrib: d3d9: get more wine
Thomas Guillem [Fri, 4 Jan 2019 13:18:36 +0000 (14:18 +0100)]
contrib: d3d9: get more wine

On Debian Buster, the idl include path is located on /usr/include/wine/wine/

This fixes the "Unable to open include file unknwn.idl" error.

2 years agocontrib: d3d9: rename IDL includes variable
Thomas Guillem [Fri, 4 Jan 2019 13:17:58 +0000 (14:17 +0100)]
contrib: d3d9: rename IDL includes variable

2 years agocontrib: d3d11: get more wine
Thomas Guillem [Fri, 4 Jan 2019 10:43:21 +0000 (11:43 +0100)]
contrib: d3d11: get more wine

On Debian Buster, the idl include path is located on /usr/include/wine/wine/

This fixes the "Unable to open include file oaidl.idl" error.

2 years agocontrib: d3d11: rename IDL includes variable
Thomas Guillem [Fri, 4 Jan 2019 10:42:18 +0000 (11:42 +0100)]
contrib: d3d11: rename IDL includes variable

2 years agoFortunes about QT and "hearing" video codecs
Jean-Baptiste Kempf [Thu, 3 Jan 2019 23:27:48 +0000 (00:27 +0100)]
Fortunes about QT and "hearing" video codecs

2 years agoxcb/xv: drop RGB support
Rémi Denis-Courmont [Thu, 3 Jan 2019 18:21:32 +0000 (20:21 +0200)]
xcb/xv: drop RGB support

The RENDER output supports RGB chroma better in all respects. Besides,
I have not seen an X server supporting RGB XVideo formats in a decade.

2 years agoavcodec: fix version checks
Zhao Zhili [Thu, 27 Dec 2018 08:08:44 +0000 (16:08 +0800)]
avcodec: fix version checks

Signed-off-by: Rémi Denis-Courmont <remi@remlab.net>
2 years agobuild: avoid annoying _FORTIFY_SOURCE warnings (fixes #17341)
Janne Grunau [Wed, 2 Jan 2019 11:54:49 +0000 (12:54 +0100)]
build: avoid annoying _FORTIFY_SOURCE warnings (fixes #17341)

fixed patch with the duplicate "#if defined ..." removed

Janne
---8<---
Some toolchains predefine _FORTIFY_SOURCE resulting in countless
_FORTIFY_SOURCE is redefined warnings. Using _FORTIFY_SOURCE without
compiler optimizations also generates warnings.
_FORTIFY_SOURCE is a reserved identifier in C99 ("All identifiers that
begin with an underscore and either an uppercase letter or another
underscore are always reserved for any use.") so the toolchain is
perfectly free to predefine it.

Signed-off-by: Rémi Denis-Courmont <remi@remlab.net>
2 years agoaarch64: Use ".arch armv8-a+feature" instead of ".arch_extension feature"
Martin Storsjö [Fri, 21 Dec 2018 22:13:29 +0000 (00:13 +0200)]
aarch64: Use ".arch armv8-a+feature" instead of ".arch_extension feature"

Clang doesn't support the .arch_extension directive for aarch64 at
the moment, but the same effect can be achieved by using .arch
instead.

Signed-off-by: Rémi Denis-Courmont <remi@remlab.net>
2 years agokva: report mouse position in window coordinates
KO Myung-Hun [Wed, 2 Jan 2019 09:38:22 +0000 (18:38 +0900)]
kva: report mouse position in window coordinates

Signed-off-by: Rémi Denis-Courmont <remi@remlab.net>
2 years agoRevert "demux:avi: use samples_from_vlc_tick for PTS conversion"
Francois Cartegnie [Wed, 2 Jan 2019 22:41:30 +0000 (23:41 +0100)]
Revert "demux:avi: use samples_from_vlc_tick for PTS conversion"

breaks compressed audio / adpcm

This reverts commit 6c3bef5f18bf1647c33fd495367a3192e33bb8ca.

2 years agodisplay: do not require a vout_thread object
Rémi Denis-Courmont [Wed, 2 Jan 2019 10:43:19 +0000 (12:43 +0200)]
display: do not require a vout_thread object

Any object is fine.

2 years agodisplay: move out vout thread event handler
Rémi Denis-Courmont [Wed, 2 Jan 2019 10:35:36 +0000 (12:35 +0200)]
display: move out vout thread event handler

2 years agodisplay: remove vout back-pointer
Rémi Denis-Courmont [Wed, 2 Jan 2019 10:29:54 +0000 (12:29 +0200)]
display: remove vout back-pointer

2 years agodisplay: avoid unnecessary special case
Rémi Denis-Courmont [Wed, 2 Jan 2019 10:27:02 +0000 (12:27 +0200)]
display: avoid unnecessary special case

Always provide a display "owner" structure in caller when creating a
vout display. Also use the owner data as a pointer to the owning video
output thread.

2 years agodisplay: relax invalid pictures memory ordering
Rémi Denis-Courmont [Wed, 2 Jan 2019 10:19:36 +0000 (12:19 +0200)]
display: relax invalid pictures memory ordering

2 years agodisplay: use function rather than event for invalid pictures
Rémi Denis-Courmont [Wed, 2 Jan 2019 10:13:57 +0000 (12:13 +0200)]
display: use function rather than event for invalid pictures

Handling is the same for all (two) cases and does not depend on the
owner.

2 years agodisplay: remove dead code
Rémi Denis-Courmont [Wed, 2 Jan 2019 09:20:12 +0000 (11:20 +0200)]
display: remove dead code

2 years agoposix: add suggested noreturn qualifier
Rémi Denis-Courmont [Wed, 2 Jan 2019 09:15:14 +0000 (11:15 +0200)]
posix: add suggested noreturn qualifier

2 years agokva: fix compilation with some cosmetics
KO Myung-Hun [Mon, 31 Dec 2018 17:25:21 +0000 (02:25 +0900)]
kva: fix compilation with some cosmetics

Signed-off-by: Rémi Denis-Courmont <remi@remlab.net>
2 years agokva: replace deprecated APIs
KO Myung-Hun [Mon, 31 Dec 2018 17:25:20 +0000 (02:25 +0900)]
kva: replace deprecated APIs

Signed-off-by: Rémi Denis-Courmont <remi@remlab.net>
2 years agoskins2: os2: fix compilation
KO Myung-Hun [Mon, 31 Dec 2018 17:25:19 +0000 (02:25 +0900)]
skins2: os2: fix compilation

-----
In file included from gui/skins2/os2/os2_factory.cpp:39:0:
gui/skins2/os2/os2_window.hpp: In member function 'virtual void OS2Window::setOSHandle(vout_window_t*) const':
gui/skins2/os2/os2_window.hpp:65:13: error: invalid use of incomplete type 'struct vout_window_t'
         pWnd->type = VOUT_WINDOW_TYPE_HWND;
             ^~
-----

Signed-off-by: Rémi Denis-Courmont <remi@remlab.net>
2 years agoqt: fix compilation
KO Myung-Hun [Mon, 31 Dec 2018 17:25:18 +0000 (02:25 +0900)]
qt: fix compilation

-----
In file included from gui/qt/menus.cpp:40:0:
gui/qt/main_interface.hpp: At global scope:
gui/qt/main_interface.hpp:75:10: error: 'atomic_flag' in namespace 'std' does not name a type
     std::atomic_flag videoActive;
          ^~~~~~~~~~~
-----

Signed-off-by: Rémi Denis-Courmont <remi@remlab.net>
2 years agoWelcome to 2019
Jean-Baptiste Kempf [Wed, 2 Jan 2019 06:58:14 +0000 (07:58 +0100)]
Welcome to 2019

2 years agodisplay: remove useless lock
Rémi Denis-Courmont [Mon, 31 Dec 2018 16:31:45 +0000 (18:31 +0200)]
display: remove useless lock

2 years agodisplay: remove mouse events
Rémi Denis-Courmont [Sun, 30 Dec 2018 21:57:22 +0000 (23:57 +0200)]
display: remove mouse events

2 years agodisplay: reroute legacy mouse events through window
Rémi Denis-Courmont [Mon, 31 Dec 2018 13:59:58 +0000 (15:59 +0200)]
display: reroute legacy mouse events through window

2 years agomsw: report mouse position in window coordinates
Rémi Denis-Courmont [Mon, 31 Dec 2018 13:52:55 +0000 (15:52 +0200)]
msw: report mouse position in window coordinates

2 years agomacosx: remove write-only parameter
Rémi Denis-Courmont [Mon, 31 Dec 2018 15:33:08 +0000 (17:33 +0200)]
macosx: remove write-only parameter

2 years agodisplay: remove redundant place parameter
Rémi Denis-Courmont [Mon, 31 Dec 2018 15:32:01 +0000 (17:32 +0200)]
display: remove redundant place parameter

2 years agodisplay: remove constant parameter
Rémi Denis-Courmont [Sun, 30 Dec 2018 21:53:20 +0000 (23:53 +0200)]
display: remove constant parameter

2 years agovout: remove vout_ManageDisplay()
Rémi Denis-Courmont [Sun, 30 Dec 2018 19:54:32 +0000 (21:54 +0200)]
vout: remove vout_ManageDisplay()

2 years agoopengl/vdpau: do not assume C and GL ptrdiff_t match
Rémi Denis-Courmont [Mon, 31 Dec 2018 16:44:16 +0000 (18:44 +0200)]
opengl/vdpau: do not assume C and GL ptrdiff_t match

This should fix compilation on some 32-bits platforms.

2 years agodisplay: process fullscreen event synchronously
Rémi Denis-Courmont [Mon, 31 Dec 2018 16:34:23 +0000 (18:34 +0200)]
display: process fullscreen event synchronously

2 years agodisplay: do not use is_fullscreen at start
Rémi Denis-Courmont [Sun, 30 Dec 2018 19:38:18 +0000 (21:38 +0200)]
display: do not use is_fullscreen at start

Just send the legacy fullscreen event right after probing if necessary.

2 years agodisplay: process window state synchronously
Rémi Denis-Courmont [Sun, 30 Dec 2018 19:39:07 +0000 (21:39 +0200)]
display: process window state synchronously

2 years agodisplay: set on-top state immediately
Rémi Denis-Courmont [Sun, 30 Dec 2018 19:38:18 +0000 (21:38 +0200)]
display: set on-top state immediately

Do not postpone until the first manage poll event.

2 years agodisplay: move vout_display_Control() to public header
Rémi Denis-Courmont [Sun, 30 Dec 2018 19:35:44 +0000 (21:35 +0200)]
display: move vout_display_Control() to public header

2 years agovout: process SPU, filter and owner hooks
Rémi Denis-Courmont [Sun, 30 Dec 2018 18:46:54 +0000 (20:46 +0200)]
vout: process SPU, filter and owner hooks

...in the video output code.

2 years agodisplay: reorient mouse pointer position
Rémi Denis-Courmont [Mon, 31 Dec 2018 13:38:50 +0000 (15:38 +0200)]
display: reorient mouse pointer position

Handle non-standard video orientation when translating the cursor
coordinates.

2 years agodisplay: add/use vout_display_TranslateMouseState()
Rémi Denis-Courmont [Sun, 30 Dec 2018 18:40:37 +0000 (20:40 +0200)]
display: add/use vout_display_TranslateMouseState()

2 years agoxcb/window: fix warning
Rémi Denis-Courmont [Sun, 30 Dec 2018 21:57:10 +0000 (23:57 +0200)]
xcb/window: fix warning

2 years agoavcodec: add an assertion
Rémi Denis-Courmont [Sat, 29 Dec 2018 09:59:24 +0000 (11:59 +0200)]
avcodec: add an assertion

2 years agoavcodec: move/balance picture allocation in callbacks
Rémi Denis-Courmont [Sat, 29 Dec 2018 09:56:33 +0000 (11:56 +0200)]
avcodec: move/balance picture allocation in callbacks

Allocate the picture in the DR and HW callbacks that actually "consume"
it. This makes no functional differences to this point.

2 years agovdpau/display: remove pool
Rémi Denis-Courmont [Tue, 25 Dec 2018 19:15:21 +0000 (21:15 +0200)]
vdpau/display: remove pool

2 years agovdpau/chroma: use filter pool
Rémi Denis-Courmont [Tue, 25 Dec 2018 19:15:09 +0000 (21:15 +0200)]
vdpau/chroma: use filter pool

2 years agovdpau/chroma: allocate a picture pool
Rémi Denis-Courmont [Tue, 25 Dec 2018 19:07:22 +0000 (21:07 +0200)]
vdpau/chroma: allocate a picture pool

2 years agodisplay: do not copy opaque pictures
Rémi Denis-Courmont [Sun, 30 Dec 2018 17:08:18 +0000 (19:08 +0200)]
display: do not copy opaque pictures

If the video format is opaque, the useful data is accessed through
picture_t.p_sys. As such, copying a picture into the display pool will
not work.

So do not copy pictures in that case, and instead assume that the
upstream converter or decoder agree with the display on the semantics
of picture_t.p_sys.

2 years agomissing: add noreturn, fix warnings
Rémi Denis-Courmont [Sun, 30 Dec 2018 16:48:54 +0000 (18:48 +0200)]
missing: add noreturn, fix warnings

2 years agodisplay: fix video context pointer aliasing
Rémi Denis-Courmont [Sun, 30 Dec 2018 17:48:17 +0000 (19:48 +0200)]
display: fix video context pointer aliasing

2 years agodisplay: fix initial window size
Rémi Denis-Courmont [Sun, 30 Dec 2018 17:37:41 +0000 (19:37 +0200)]
display: fix initial window size

2 years agomacOS build.sh: Detect local installation of python3
David Fuhrmann [Sat, 29 Dec 2018 17:55:28 +0000 (18:55 +0100)]
macOS build.sh: Detect local installation of python3

Since python3 is now mandatory for meson and co, try to detect
a packaged install and add it to the path.
Note that /usr/local/bin is not added completely, to avoid
interference with homebrew.

2 years agocontrib: srt: Remove downgrade of availability error
David Fuhrmann [Sat, 29 Dec 2018 16:16:33 +0000 (17:16 +0100)]
contrib: srt: Remove downgrade of availability error

This is not needed anymore (and did not really work in some
situations).

2 years agomacOS build.sh: Fix make clean for contribs
David Fuhrmann [Sat, 29 Dec 2018 11:16:52 +0000 (12:16 +0100)]
macOS build.sh: Fix make clean for contribs

If an old contrib folder exists, bootstrap recognizes those as
"system-available" libraries and thus does not recompile.

2 years agodisplay: free up vout_display_t.owner.sys
Rémi Denis-Courmont [Fri, 28 Dec 2018 19:10:36 +0000 (21:10 +0200)]
display: free up vout_display_t.owner.sys

2 years agodisplay: append core private data after vout_display_t
Rémi Denis-Courmont [Fri, 28 Dec 2018 19:08:03 +0000 (21:08 +0200)]
display: append core private data after vout_display_t

2 years agodisplay: inline vout_display_Delete()
Rémi Denis-Courmont [Fri, 28 Dec 2018 19:00:49 +0000 (21:00 +0200)]
display: inline vout_display_Delete()

2 years agodisplay: fix leak on error
Rémi Denis-Courmont [Fri, 28 Dec 2018 19:00:29 +0000 (21:00 +0200)]
display: fix leak on error

2 years agodisplay: inline vout_display_New()
Rémi Denis-Courmont [Fri, 28 Dec 2018 18:55:31 +0000 (20:55 +0200)]
display: inline vout_display_New()

2 years agopicture_pool: handle reserve pool pictures
Rémi Denis-Courmont [Thu, 27 Dec 2018 21:28:25 +0000 (23:28 +0200)]
picture_pool: handle reserve pool pictures

This adds yet another kludge to detect if a picture is from a pool
through another (reserve) pool. This avoids copying pictures allocated
by filters through the "private pool", until displays are fixed not to
rely on pools.

2 years agosplitter: remove write-only owner
Rémi Denis-Courmont [Thu, 27 Dec 2018 17:29:10 +0000 (19:29 +0200)]
splitter: remove write-only owner

2 years agodisplay: move prepare & display helpers
Rémi Denis-Courmont [Thu, 27 Dec 2018 10:23:18 +0000 (12:23 +0200)]
display: move prepare & display helpers

...to public headers.

2 years agowindow: missing VLC_API qualifiers
Rémi Denis-Courmont [Thu, 27 Dec 2018 10:23:01 +0000 (12:23 +0200)]
window: missing VLC_API qualifiers

2 years agovout: do not blend SPU early based on resolution
Rémi Denis-Courmont [Wed, 26 Dec 2018 08:33:05 +0000 (10:33 +0200)]
vout: do not blend SPU early based on resolution

In general, the best SPU quality should be achieved by rendering
directly to the intended display resolution rather than scaling.

This also avoids certain problems:

- If there is no blending for the source chroma, blending fails
  depending on the display resolution. This is a real problem now with
  opaque chromas and "weird" high-depth chromas.
- If the source resolution is really large, rendering to it is a waste
  of processing power.

2 years agopicture_pool: handle non-pool pictures
Rémi Denis-Courmont [Thu, 27 Dec 2018 12:04:53 +0000 (14:04 +0200)]
picture_pool: handle non-pool pictures

This works around picture_pool_OwnsPic() crashing on non-pooled
pictures. The brittle kludge works for the time being because only
pooling and cloning use non-NULL picture_priv_T.gc.opaque.

2 years agosplitter: remove picture deletion callback
Rémi Denis-Courmont [Wed, 26 Dec 2018 18:08:55 +0000 (20:08 +0200)]
splitter: remove picture deletion callback

Use picture_Release() directly.

2 years agosplitter: remove useless pool
Rémi Denis-Courmont [Wed, 26 Dec 2018 17:09:19 +0000 (19:09 +0200)]
splitter: remove useless pool

2 years agosplitter: remove useless struct
Rémi Denis-Courmont [Wed, 26 Dec 2018 17:02:21 +0000 (19:02 +0200)]
splitter: remove useless struct

Also remove xmalloc() usage.

2 years agosplitter: make p_owner a void pointer
Rémi Denis-Courmont [Wed, 26 Dec 2018 16:58:05 +0000 (18:58 +0200)]
splitter: make p_owner a void pointer

2 years agosplitter: make p_sys a void pointer
Rémi Denis-Courmont [Wed, 26 Dec 2018 16:58:05 +0000 (18:58 +0200)]
splitter: make p_sys a void pointer

2 years agovout: drop unnecessary pool check
Rémi Denis-Courmont [Wed, 26 Dec 2018 15:41:24 +0000 (17:41 +0200)]
vout: drop unnecessary pool check

Pictures are now systematically copied into the correct display pool if
necessary, so which pool the decoder allocates pictures from is
irrelevant.

Note though that this did not, and still does not, ensure that pictures
are in the expected format. A buggy decoder could and still can send
pictures in a wrong or old format.

2 years agovout: remove no-op (fix warning)
Rémi Denis-Courmont [Wed, 26 Dec 2018 16:15:03 +0000 (18:15 +0200)]
vout: remove no-op (fix warning)

2 years agosplitter: remove no-op manage function
Rémi Denis-Courmont [Wed, 26 Dec 2018 16:11:10 +0000 (18:11 +0200)]
splitter: remove no-op manage function

This does not do anything any longer.

Refs #21604.

2 years agovout: inline vout_ManageWrapper()
Rémi Denis-Courmont [Wed, 26 Dec 2018 16:08:32 +0000 (18:08 +0200)]
vout: inline vout_ManageWrapper()

2 years agodisplay: remove a constant return value
Rémi Denis-Courmont [Wed, 26 Dec 2018 14:43:05 +0000 (16:43 +0200)]
display: remove a constant return value