ffmpeg.git
9 years agoarm: Fix 10l typo
Michael Niedermayer [Sat, 3 Mar 2012 03:35:15 +0000 (04:35 +0100)]
arm: Fix 10l typo

Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
9 years agobluray protocol
Petri Hintukainen [Sat, 3 Mar 2012 03:25:48 +0000 (04:25 +0100)]
bluray protocol

Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
9 years agokvmc: Fix out of reference frame reads.
Michael Niedermayer [Sat, 3 Mar 2012 03:14:37 +0000 (04:14 +0100)]
kvmc: Fix out of reference frame reads.

Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
9 years agoqpeg: fix overreads.
Michael Niedermayer [Sat, 3 Mar 2012 02:50:05 +0000 (03:50 +0100)]
qpeg: fix overreads.

qpeg should probably be changed to use the checked bytestream reader.
But for now this fixes it and is significantly less work.

Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
9 years agoqpeg: Fix out of array writes.
Michael Niedermayer [Sat, 3 Mar 2012 02:37:52 +0000 (03:37 +0100)]
qpeg: Fix out of array writes.

Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
9 years agosrtdec: fix a format string vulnerability.
Fabian Greffrath [Sat, 3 Mar 2012 01:35:27 +0000 (02:35 +0100)]
srtdec: fix a format string vulnerability.

Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
9 years agoRemove duplicate initializers for VDA_VLD and GBR24P.
Dale Curtis [Fri, 2 Mar 2012 22:56:33 +0000 (14:56 -0800)]
Remove duplicate initializers for VDA_VLD and GBR24P.

Noticed by the Chromium Mac clang build, http://crbug.com/116599

Signed-off-by: Dale Curtis <dalecurtis@chromium.org>
Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
9 years agoMerge remote-tracking branch 'qatar/master'
Michael Niedermayer [Fri, 2 Mar 2012 23:09:47 +0000 (00:09 +0100)]
Merge remote-tracking branch 'qatar/master'

* qatar/master: (29 commits)
  amrwb: remove duplicate arguments from extrapolate_isf().
  amrwb: error out early if mode is invalid.
  h264: change underread for 10bit QPEL to overread.
  matroska: check buffer size for RM-style byte reordering.
  vp8: disable mmx functions with sse/sse2 counterparts on x86-64.
  vp8: change int stride to ptrdiff_t stride.
  wma: fix invalid buffer size assumptions causing random overreads.
  Windows Media Audio Lossless decoder
  rv10/20: Fix slice overflow with checked bitstream reader.
  h263dec: Disallow width/height changing with frame threads.
  rv10/20: Fix a buffer overread caused by losing track of the remaining buffer size.
  rmdec: Honor .RMF tag size rather than assuming 18.
  g722: Fix the QMF scaling
  r3d: don't set codec timebase.
  electronicarts: set timebase for tgv video.
  electronicarts: parse the framerate for cmv video.
  ogg: don't set codec timebase
  electronicarts: don't set codec timebase
  avs: don't set codec timebase
  wavpack: Fix an integer overflow
  ...

Conflicts:
libavcodec/arm/vp8dsp_init_arm.c
libavcodec/fraps.c
libavcodec/h264.c
libavcodec/mpeg4videodec.c
libavcodec/mpegvideo.c
libavcodec/msmpeg4.c
libavcodec/pnmdec.c
libavcodec/qpeg.c
libavcodec/rawenc.c
libavcodec/ulti.c
libavcodec/vcr1.c
libavcodec/version.h
libavcodec/wmalosslessdec.c
libavformat/electronicarts.c
libswscale/ppc/yuv2rgb_altivec.c
tests/ref/acodec/g722
tests/ref/fate/ea-cmv

Merged-by: Michael Niedermayer <michaelni@gmx.at>
9 years agosimple_idct: idct_4col_put: Fix out of array reads.
Michael Niedermayer [Fri, 2 Mar 2012 21:09:44 +0000 (22:09 +0100)]
simple_idct: idct_4col_put: Fix out of array reads.

Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
9 years agorawdec: fix input overread.
Michael Niedermayer [Fri, 2 Mar 2012 21:04:00 +0000 (22:04 +0100)]
rawdec: fix input overread.

Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
9 years agoamrwb: remove duplicate arguments from extrapolate_isf().
Ronald S. Bultje [Thu, 1 Mar 2012 23:44:25 +0000 (15:44 -0800)]
amrwb: remove duplicate arguments from extrapolate_isf().

Prevents warnings because the dst and src overlap (are the same) in the
memcpy() inside the function.

Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
CC: libav-stable@libav.org
9 years agotruemotion1: Check input buffer size against header size.
Michael Niedermayer [Fri, 2 Mar 2012 20:36:42 +0000 (21:36 +0100)]
truemotion1: Check input buffer size against header size.

Fixes overread.

Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
9 years agomjpeg: Check for interlaced progressive frames
Michael Niedermayer [Fri, 2 Mar 2012 20:35:58 +0000 (21:35 +0100)]
mjpeg: Check for interlaced progressive frames

Fixes null pointer dereference.

Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
9 years agosnow: check reference frame indices.
Michael Niedermayer [Fri, 2 Mar 2012 19:53:00 +0000 (20:53 +0100)]
snow: check reference frame indices.

Fixes NULL ptr dereference

Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
9 years agoamrwb: error out early if mode is invalid.
Ronald S. Bultje [Thu, 1 Mar 2012 21:51:21 +0000 (13:51 -0800)]
amrwb: error out early if mode is invalid.

Prevents using the invalid mode as an index in a static array, which
would generate invalid reads.

Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
CC: libav-stable@libav.org
9 years agoh264: change underread for 10bit QPEL to overread.
Ronald S. Bultje [Sun, 26 Feb 2012 01:24:56 +0000 (17:24 -0800)]
h264: change underread for 10bit QPEL to overread.

This prevents us from reading before the start of the buffer, and thus
prevents crashes resulting from this behaviour. Fixes bug 237.

9 years agomatroska: check buffer size for RM-style byte reordering.
Ronald S. Bultje [Fri, 2 Mar 2012 01:01:22 +0000 (17:01 -0800)]
matroska: check buffer size for RM-style byte reordering.

Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
CC: libav-stable@libav.org
9 years agovp8: disable mmx functions with sse/sse2 counterparts on x86-64.
Ronald S. Bultje [Fri, 2 Mar 2012 04:39:49 +0000 (20:39 -0800)]
vp8: disable mmx functions with sse/sse2 counterparts on x86-64.

x86-64 is guaranteed to have at least SSE2, therefore the MMX/MMX2
functions will never be used in practice.

9 years agovp8: change int stride to ptrdiff_t stride.
Ronald S. Bultje [Fri, 2 Mar 2012 05:17:03 +0000 (21:17 -0800)]
vp8: change int stride to ptrdiff_t stride.

On 64bit platforms with 32bit int, this means we won't have to sign-
extend the integer anymore.

9 years agowma: fix invalid buffer size assumptions causing random overreads.
Ronald S. Bultje [Fri, 2 Mar 2012 00:19:51 +0000 (16:19 -0800)]
wma: fix invalid buffer size assumptions causing random overreads.

Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
CC: libav-stable@libav.org
9 years agoWindows Media Audio Lossless decoder
Mashiat Sarker Shakkhar [Thu, 1 Mar 2012 12:43:00 +0000 (12:43 +0000)]
Windows Media Audio Lossless decoder

Decodes 16-bit WMA Lossless encoded files. 24-bit is not supported yet.

Bitstream parser written by Andreas Öman with contributions from
Baptiste Coudurier and Ulion.

Includes a number of bug-fixes from Benjamin Larsson, Michael Niedermayer and
Konstantin Shishkov, shine and polish by Diego Biurrun.

Signed-off-by: Diego Biurrun <diego@biurrun.de>
9 years agohuffyuv: pad classic huffman tables so as to avoid bitreader overread.
Michael Niedermayer [Fri, 2 Mar 2012 17:49:39 +0000 (18:49 +0100)]
huffyuv: pad classic huffman tables so as to avoid bitreader overread.

Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
9 years agovc1: mquant is not allowed to be 0
Michael Niedermayer [Fri, 2 Mar 2012 17:24:21 +0000 (18:24 +0100)]
vc1: mquant is not allowed to be 0

Fixes out of bounds read.
Checked against SMPTE 421M-2006

Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
9 years agorv10/20: Fix slice overflow with checked bitstream reader.
Alex Converse [Thu, 1 Mar 2012 21:24:55 +0000 (13:24 -0800)]
rv10/20: Fix slice overflow with checked bitstream reader.

9 years agoh263dec: Disallow width/height changing with frame threads.
Michael Niedermayer [Fri, 17 Feb 2012 21:35:10 +0000 (13:35 -0800)]
h263dec: Disallow width/height changing with frame threads.

Fixes CVE-2011-3937

Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
9 years agorv10/20: Fix a buffer overread caused by losing track of the remaining buffer size.
Alex Converse [Thu, 1 Mar 2012 22:07:22 +0000 (14:07 -0800)]
rv10/20: Fix a buffer overread caused by losing track of the remaining buffer size.

Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
CC: libav-stable@libav.org
9 years agormdec: Honor .RMF tag size rather than assuming 18.
Alex Converse [Fri, 2 Mar 2012 00:47:54 +0000 (16:47 -0800)]
rmdec: Honor .RMF tag size rather than assuming 18.

9 years agog722: Fix the QMF scaling
Martin Storsjö [Fri, 2 Mar 2012 15:03:06 +0000 (17:03 +0200)]
g722: Fix the QMF scaling

This fixes clipping if the encoder input used the full 16 bit
input range (samples with a magnitude below 16383 worked fine).
The filtered subband samples should be 15 bit maximum, while
the code earlier produced them scaled to 16 bit.

This makes the decoder output have double the magnitude
compared to before.

The spec reference samples doesn't test the QMF at all, which
was why this part slipped past initially.

Signed-off-by: Martin Storsjö <martin@martin.st>
9 years agor3d: don't set codec timebase.
Anton Khirnov [Fri, 2 Mar 2012 13:08:11 +0000 (14:08 +0100)]
r3d: don't set codec timebase.

It's not supposed to be set by demuxers.

Set avg_frame_rate and r_frame_rate instead.

9 years agoh263: fix zygo debug printing overreading.
Michael Niedermayer [Fri, 2 Mar 2012 15:52:32 +0000 (16:52 +0100)]
h263: fix zygo debug printing overreading.

Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
9 years agowmadec: fix off by 1 error on the pow_tab index check.
Michael Niedermayer [Fri, 2 Mar 2012 15:44:49 +0000 (16:44 +0100)]
wmadec: fix off by 1 error on the pow_tab index check.

Fixes global out of array read.

Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
9 years agotimefilter: better selftest code.
Michael Niedermayer [Fri, 2 Mar 2012 05:21:48 +0000 (06:21 +0100)]
timefilter: better selftest code.

Add support for divergence detection and variable period.

Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
9 years agoh261: check mtype.
Michael Niedermayer [Fri, 2 Mar 2012 14:58:14 +0000 (15:58 +0100)]
h261: check mtype.

Fixes out of array read

Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
9 years agoelectronicarts: set timebase for tgv video.
Anton Khirnov [Thu, 1 Mar 2012 20:24:16 +0000 (21:24 +0100)]
electronicarts: set timebase for tgv video.

The container has no timestamps and the framerate isn't stored in the
data either.
The decoder sets codec timebase to experimentally found value 1/15. Do
the same for the demuxer too, it should at least be better than the
default 1/90000.

9 years agoelectronicarts: parse the framerate for cmv video.
Anton Khirnov [Thu, 1 Mar 2012 12:16:49 +0000 (13:16 +0100)]
electronicarts: parse the framerate for cmv video.

9 years agoogg: don't set codec timebase
Anton Khirnov [Thu, 24 Nov 2011 19:58:22 +0000 (20:58 +0100)]
ogg: don't set codec timebase

Demuxers are not supposed to set it.

9 years agoelectronicarts: don't set codec timebase
Anton Khirnov [Thu, 24 Nov 2011 19:58:22 +0000 (20:58 +0100)]
electronicarts: don't set codec timebase

Demuxers are not supposed to set it.
Set stream timebase and framerates instead (this is a cfr container with
no timestamps).

9 years agoavs: don't set codec timebase
Anton Khirnov [Thu, 24 Nov 2011 19:58:22 +0000 (20:58 +0100)]
avs: don't set codec timebase

Demuxers are not supposed to set it.
Set r_frame_rate and avg_frame_rate instead.

9 years agowavpack: Fix an integer overflow
Derek Buitenhuis [Thu, 1 Mar 2012 21:34:57 +0000 (16:34 -0500)]
wavpack: Fix an integer overflow

Integer Overflow Checker detected an integer
overflow while FATE was running.

See: http://fate.libav.org/x86_64-linux-ioc/

Signed-off-by: Derek Buitenhuis <derek.buitenhuis@gmail.com>
Signed-off-by: Kostya Shishkov <kostya.shishkov@gmail.com>
9 years agolavf: fix update_initial_durations() so it handles missing durations with the initial...
Michael Niedermayer [Fri, 2 Mar 2012 05:22:20 +0000 (06:22 +0100)]
lavf: fix update_initial_durations() so it handles missing durations with the initial timestamp being known.

This fixes duplicate timestamps on mp2 in ts with non seekable input.
It also fixed the fate pva demux timestamps.

Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
9 years agowavpack: Fix an integer overflow
Derek Buitenhuis [Thu, 1 Mar 2012 21:36:08 +0000 (16:36 -0500)]
wavpack: Fix an integer overflow

Integer Overflow Checker detected an integer
overflow while FATE was running.

Signed-off-by: Derek Buitenhuis <derek.buitenhuis@gmail.com>
Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
9 years agofate: Add sunrast regression test
Derek Buitenhuis [Thu, 1 Mar 2012 23:24:44 +0000 (18:24 -0500)]
fate: Add sunrast regression test

Signed-off-by: Derek Buitenhuis <derek.buitenhuis@gmail.com>
Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
9 years agoroqvideodec: improve end of input buffer check
Michael Niedermayer [Fri, 2 Mar 2012 01:32:14 +0000 (02:32 +0100)]
roqvideodec: improve end of input buffer check

This fixes a out of array read.

Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
9 years agoswscale: K&R formatting cosmetics for PowerPC code (part II/II)
Diego Biurrun [Tue, 21 Feb 2012 18:59:38 +0000 (19:59 +0100)]
swscale: K&R formatting cosmetics for PowerPC code (part II/II)

9 years agomp3dec: Fix reading file size and frames in VBRI headers
Ingo Brückl [Fri, 16 Sep 2011 22:00:19 +0000 (15:00 -0700)]
mp3dec: Fix reading file size and frames in VBRI headers

The fields "Number of Bytes" and "Number of Frames" are mixed up. "Bytes"
come first, "Frames" behind.

Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
Signed-off-by: Alex Converse <alex.converse@gmail.com>
9 years agoMerge remote-tracking branch 'qatar/master'
Michael Niedermayer [Thu, 1 Mar 2012 22:11:31 +0000 (23:11 +0100)]
Merge remote-tracking branch 'qatar/master'

* qatar/master:
  h264: error out on invalid bitdepth.
  aacsbr: use a swap index for the Y matrix rather than copy buffers.
  huffyuv: do not abort on unknown pix_fmt; instead, return an error.
  lcl: return negative error codes on decode_init() errors.
  rtpenc: Use MB info side data for splitting H263 packets for RFC 2190
  h263enc: Add an option for outputting info about MBs as side data
  avpacket: Add a function for shrinking already allocated side data
  nellymoserdec: Saner and faster IMDCT windowing

Conflicts:
doc/APIchanges
libavcodec/avpacket.c
libavcodec/version.h

Merged-by: Michael Niedermayer <michaelni@gmx.at>
9 years agomjpegdec: use correct variable in av_log invocation
Diego Biurrun [Wed, 29 Feb 2012 18:47:49 +0000 (19:47 +0100)]
mjpegdec: use correct variable in av_log invocation

libavcodec/mjpegdec.c:1463: warning: format ‘%x’ expects type ‘unsigned int’, but argument 5 has type ‘const uint8_t *’

9 years agormdec: adjust printf format string specifier to fix warning
Diego Biurrun [Sun, 26 Feb 2012 22:42:37 +0000 (23:42 +0100)]
rmdec: adjust printf format string specifier to fix warning

libavformat/rmdec.c:383: warning: format ‘%d’ expects type ‘int’, but argument 7 has type ‘int64_t’

9 years agoReplace AVFrame pointer type punning by proper struct member assignments.
Diego Biurrun [Mon, 27 Feb 2012 21:08:41 +0000 (22:08 +0100)]
Replace AVFrame pointer type punning by proper struct member assignments.

9 years agoReplace AVFrame pointer casts by proper struct member accesses.
Diego Biurrun [Mon, 27 Feb 2012 21:02:45 +0000 (22:02 +0100)]
Replace AVFrame pointer casts by proper struct member accesses.

9 years agoRemove unnecessary AVFrame pointer casts.
Diego Biurrun [Mon, 27 Feb 2012 07:51:20 +0000 (08:51 +0100)]
Remove unnecessary AVFrame pointer casts.

9 years agomsmpeg4: Split encoding backend code off from general backend code.
Diego Biurrun [Sat, 18 Feb 2012 13:28:43 +0000 (14:28 +0100)]
msmpeg4: Split encoding backend code off from general backend code.

9 years agolavc: shrink encoded video packet size after encoding.
Anton Khirnov [Thu, 1 Mar 2012 11:15:45 +0000 (12:15 +0100)]
lavc: shrink encoded video packet size after encoding.

Based on a patch by Nicolas George <nicolas.george <at> normalesup.org>

9 years agovc1: avoid reading beyond the last line in vc1_draw_sprites()
Michael Niedermayer [Thu, 1 Mar 2012 21:19:36 +0000 (22:19 +0100)]
vc1: avoid reading beyond the last line in vc1_draw_sprites()

Fixes overread

Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
9 years agoh264: error out on invalid bitdepth.
Ronald S. Bultje [Thu, 1 Mar 2012 19:56:05 +0000 (11:56 -0800)]
h264: error out on invalid bitdepth.

Fixes invalid reads while initializing the dequant tables, which uses
the bit depth to determine the QP table size.

Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
CC: libav-stable@libav.org
9 years agoaacsbr: use a swap index for the Y matrix rather than copy buffers.
Christophe Gisquet [Thu, 23 Feb 2012 22:25:44 +0000 (22:25 +0000)]
aacsbr: use a swap index for the Y matrix rather than copy buffers.

Signed-off-by: Alex Converse <alex.converse@gmail.com>
9 years agoeatgq: Pass error code from tgq_decode_mb() and let the caller fail.
Michael Niedermayer [Thu, 1 Mar 2012 18:56:57 +0000 (19:56 +0100)]
eatgq: Pass error code from tgq_decode_mb() and let the caller fail.

This fixes a over read.

Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
9 years agovc1: fix out of array reads in vc1_inv_trans_4x4_c()
Michael Niedermayer [Thu, 1 Mar 2012 18:24:24 +0000 (19:24 +0100)]
vc1: fix out of array reads in vc1_inv_trans_4x4_c()

Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
9 years agovc1: fix out of array reads in vc1_inv_trans_4x8_c()
Michael Niedermayer [Thu, 1 Mar 2012 18:18:34 +0000 (19:18 +0100)]
vc1: fix out of array reads in vc1_inv_trans_4x8_c()

Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
9 years agovc1: fix out of array reads in vc1_inv_trans_8x4_c()
Michael Niedermayer [Thu, 1 Mar 2012 18:14:50 +0000 (19:14 +0100)]
vc1: fix out of array reads in vc1_inv_trans_8x4_c()

Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
9 years agohuffyuv: do not abort on unknown pix_fmt; instead, return an error.
Ronald S. Bultje [Thu, 1 Mar 2012 17:41:22 +0000 (09:41 -0800)]
huffyuv: do not abort on unknown pix_fmt; instead, return an error.

Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
CC: libav-stable@libav.org
9 years agompc: Fix mpc_CC table and use.
Michael Niedermayer [Thu, 1 Mar 2012 15:16:13 +0000 (16:16 +0100)]
mpc: Fix mpc_CC table and use.

This is based on the reference implementation and fixes
a global out of array read.

Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
9 years agompc: Fix mpc_SCF use and content.
Michael Niedermayer [Thu, 1 Mar 2012 14:55:31 +0000 (15:55 +0100)]
mpc: Fix mpc_SCF use and content.

This fixes a out of global array read.
This change is based on the reference mpc imlementation.

Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
9 years agolcl: return negative error codes on decode_init() errors.
Ronald S. Bultje [Thu, 1 Mar 2012 01:50:28 +0000 (17:50 -0800)]
lcl: return negative error codes on decode_init() errors.

Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
CC: libav-stable@libav.org
9 years agortpenc: Use MB info side data for splitting H263 packets for RFC 2190
Martin Storsjö [Fri, 10 Feb 2012 08:31:19 +0000 (10:31 +0200)]
rtpenc: Use MB info side data for splitting H263 packets for RFC 2190

This makes the packetization spec compliant for cases where one single
GOB doesn't fit into an RTP packet.

Signed-off-by: Martin Storsjö <martin@martin.st>
9 years agoh263enc: Add an option for outputting info about MBs as side data
Martin Storsjö [Mon, 27 Feb 2012 21:23:45 +0000 (23:23 +0200)]
h263enc: Add an option for outputting info about MBs as side data

Signed-off-by: Martin Storsjö <martin@martin.st>
9 years agoavpacket: Add a function for shrinking already allocated side data
Martin Storsjö [Mon, 27 Feb 2012 23:08:31 +0000 (01:08 +0200)]
avpacket: Add a function for shrinking already allocated side data

Signed-off-by: Martin Storsjö <martin@martin.st>
9 years agorv34dsp: avoid use of crop table for idct.
Michael Niedermayer [Thu, 1 Mar 2012 06:06:53 +0000 (07:06 +0100)]
rv34dsp: avoid use of crop table for idct.

Fixes out of array read.

Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
9 years agompegaudiodec: Enable checked bitstream reader.
Michael Niedermayer [Thu, 1 Mar 2012 04:29:20 +0000 (05:29 +0100)]
mpegaudiodec: Enable checked bitstream reader.

It appears there are corner cases with damaged input that can lead
to small overreads.

Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
9 years agompegaudiodec: change granule skip code to avoid false checked bitstream reader errors.
Michael Niedermayer [Thu, 1 Mar 2012 05:07:36 +0000 (06:07 +0100)]
mpegaudiodec: change granule skip code to avoid false checked bitstream reader errors.

Code ported from qatar/master, please see there for per line authorship.
Main authors AFAIK are Ronald and Justin. I have no authorship on this.

Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
9 years agosvq3dec: fix overread of the cliping table.
Michael Niedermayer [Thu, 1 Mar 2012 04:25:11 +0000 (05:25 +0100)]
svq3dec: fix overread of the cliping table.

Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
9 years agoeval: fix infinite loop on opensolaris x86.
Michael Niedermayer [Thu, 1 Mar 2012 02:24:45 +0000 (03:24 +0100)]
eval: fix infinite loop on opensolaris x86.

Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
9 years agoMerge remote-tracking branch 'qatar/master'
Michael Niedermayer [Thu, 1 Mar 2012 00:13:16 +0000 (01:13 +0100)]
Merge remote-tracking branch 'qatar/master'

* qatar/master: (58 commits)
  amrnbdec: check frame size before decoding.
  cscd: use negative error values to indicate decode_init() failures.
  h264: prevent overreads in intra PCM decoding.
  FATE: do not decode audio in the nuv test.
  dxa: set audio stream time base using the sample rate
  psx-str: do not allow seeking by bytes
  asfdec: Do not set AVCodecContext.frame_size
  vqf: set packet parameters after av_new_packet()
  mpegaudiodec: use DSPUtil.butterflies_float().
  FATE: add mp3 test for sample that exhibited false overreads
  fate: add cdxl test for bit line plane arrangement
  vmnc: return error on decode_init() failure.
  libvorbis: add/update error messages
  libvorbis: use AVFifoBuffer for output packet buffer
  libvorbis: remove unneeded e_o_s check
  libvorbis: check return values for functions that can return errors
  libvorbis: use float input instead of s16
  libvorbis: do not flush libvorbis analysis if dsp state was not initialized
  libvorbis: use VBR by default, with default quality of 3
  libvorbis: fix use of minrate/maxrate AVOptions
  ...

Conflicts:
Changelog
doc/APIchanges
libavcodec/avcodec.h
libavcodec/dpxenc.c
libavcodec/libvorbis.c
libavcodec/vmnc.c
libavformat/asfdec.c
libavformat/id3v2enc.c
libavformat/internal.h
libavformat/mp3enc.c
libavformat/utils.c
libavformat/version.h
libswscale/utils.c
tests/fate/video.mak
tests/ref/fate/nuv
tests/ref/fate/prores-alpha
tests/ref/lavf/ffm
tests/ref/vsynth1/prores
tests/ref/vsynth2/prores

Merged-by: Michael Niedermayer <michaelni@gmx.at>
9 years agonellymoserdec: Saner and faster IMDCT windowing
Vitor Sessak [Wed, 29 Feb 2012 18:39:16 +0000 (19:39 +0100)]
nellymoserdec: Saner and faster IMDCT windowing

Signed-off-by: Ronald S. Bultje <rsbultje@gmail.com>
9 years agoamrnbdec: check frame size before decoding.
Vitor Sessak [Wed, 29 Feb 2012 21:09:10 +0000 (22:09 +0100)]
amrnbdec: check frame size before decoding.

Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
CC: libav-stable@libav.org
Signed-off-by: Ronald S. Bultje <rsbultje@gmail.com>
9 years agocscd: use negative error values to indicate decode_init() failures.
Ronald S. Bultje [Wed, 29 Feb 2012 21:55:09 +0000 (13:55 -0800)]
cscd: use negative error values to indicate decode_init() failures.

Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
CC: libav-stable@libav.org
9 years agoh264: prevent overreads in intra PCM decoding.
Ronald S. Bultje [Wed, 29 Feb 2012 02:48:27 +0000 (18:48 -0800)]
h264: prevent overreads in intra PCM decoding.

Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
CC: libav-stable@libav.org
9 years agoFATE: do not decode audio in the nuv test.
Justin Ruggles [Fri, 20 Jan 2012 04:47:48 +0000 (23:47 -0500)]
FATE: do not decode audio in the nuv test.

We already have sufficient coverage for 16-bit pcm.

9 years agodxa: set audio stream time base using the sample rate
Justin Ruggles [Thu, 19 Jan 2012 20:55:18 +0000 (15:55 -0500)]
dxa: set audio stream time base using the sample rate

9 years agopsx-str: do not allow seeking by bytes
Justin Ruggles [Tue, 17 Jan 2012 15:16:34 +0000 (10:16 -0500)]
psx-str: do not allow seeking by bytes

9 years agoasfdec: Do not set AVCodecContext.frame_size
Justin Ruggles [Fri, 13 Jan 2012 23:20:18 +0000 (18:20 -0500)]
asfdec: Do not set AVCodecContext.frame_size

9 years agovqf: set packet parameters after av_new_packet()
Justin Ruggles [Thu, 19 Jan 2012 20:48:11 +0000 (15:48 -0500)]
vqf: set packet parameters after av_new_packet()

Otherwise the values are overwritten.

9 years agolavc: fix 10l oversight in realloc of avcodec_encode_video2.
Michael Niedermayer [Wed, 29 Feb 2012 20:33:00 +0000 (21:33 +0100)]
lavc: fix 10l oversight in realloc of avcodec_encode_video2.

Packets are not guranteed to be allocated by av_malloc().

Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
9 years agodca: dont overread dca_default_coeffs.
Michael Niedermayer [Wed, 29 Feb 2012 20:14:17 +0000 (21:14 +0100)]
dca: dont overread dca_default_coeffs.

Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
9 years agodca: Check scale_sum.
Michael Niedermayer [Wed, 29 Feb 2012 19:47:47 +0000 (20:47 +0100)]
dca: Check scale_sum.

Fixes a out of array read.

Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
9 years agodca: Check LFEScaleIndex.
Michael Niedermayer [Wed, 29 Feb 2012 17:09:51 +0000 (18:09 +0100)]
dca: Check LFEScaleIndex.

Its not clear from the spec what to do with values larger than 127
so iam opting for the safe side and ask for a sample.

Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
9 years agompegaudiodec: use DSPUtil.butterflies_float().
Vitor Sessak [Wed, 29 Feb 2012 20:06:13 +0000 (21:06 +0100)]
mpegaudiodec: use DSPUtil.butterflies_float().

Signed-off-by: Ronald S. Bultje <rsbultje@gmail.com>
9 years agoFATE: add mp3 test for sample that exhibited false overreads
Justin Ruggles [Fri, 24 Feb 2012 21:47:28 +0000 (16:47 -0500)]
FATE: add mp3 test for sample that exhibited false overreads

related to b7165426917f91ebcad84bdff366824f03b32bfe
Error messages and audible artifacts were fixed in that commit.

9 years agofate: add cdxl test for bit line plane arrangement
Paul B Mahol [Sun, 26 Feb 2012 19:23:50 +0000 (19:23 +0000)]
fate: add cdxl test for bit line plane arrangement

Signed-off-by: Paul B Mahol <onemda@gmail.com>
Signed-off-by: Justin Ruggles <justin.ruggles@gmail.com>
9 years agovmnc: return error on decode_init() failure.
Ronald S. Bultje [Wed, 29 Feb 2012 03:00:48 +0000 (19:00 -0800)]
vmnc: return error on decode_init() failure.

Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
CC: libav-stable@libav.org
9 years agolibvorbis: add/update error messages
Justin Ruggles [Wed, 29 Feb 2012 05:02:55 +0000 (00:02 -0500)]
libvorbis: add/update error messages

also use AVERROR codes for some return values instead of -1

9 years agolibvorbis: use AVFifoBuffer for output packet buffer
Justin Ruggles [Wed, 29 Feb 2012 03:39:07 +0000 (22:39 -0500)]
libvorbis: use AVFifoBuffer for output packet buffer

simplifies the code and does less memmove()

9 years agolibvorbis: remove unneeded e_o_s check
Justin Ruggles [Wed, 29 Feb 2012 02:02:22 +0000 (21:02 -0500)]
libvorbis: remove unneeded e_o_s check

vorbis_bitrate_flushpacket() does not return any packets that should not be
output in the bitstream.

9 years agolibvorbis: check return values for functions that can return errors
Justin Ruggles [Wed, 29 Feb 2012 02:00:33 +0000 (21:00 -0500)]
libvorbis: check return values for functions that can return errors

9 years agolibvorbis: use float input instead of s16
Justin Ruggles [Wed, 29 Feb 2012 00:55:10 +0000 (19:55 -0500)]
libvorbis: use float input instead of s16

libvorbis takes float input, so we can just deinterleave/reorder the input
as-is instead of also converting.

9 years agolibvorbis: do not flush libvorbis analysis if dsp state was not initialized
Justin Ruggles [Wed, 29 Feb 2012 00:51:25 +0000 (19:51 -0500)]
libvorbis: do not flush libvorbis analysis if dsp state was not initialized

Fixes a segfault if init() fails before initializing the dsp state

9 years agolibvorbis: use VBR by default, with default quality of 3
Justin Ruggles [Wed, 29 Feb 2012 00:33:07 +0000 (19:33 -0500)]
libvorbis: use VBR by default, with default quality of 3

9 years agolibvorbis: fix use of minrate/maxrate AVOptions
Justin Ruggles [Tue, 28 Feb 2012 23:52:30 +0000 (18:52 -0500)]
libvorbis: fix use of minrate/maxrate AVOptions

- enable the options for audio encoding
- properly check for user-set maxrate
- use correct calling order in vorbis_encode_setup_managed()

9 years agolibvorbis: cosmetics: renaming/pretty-printing/comments/unused code
Justin Ruggles [Tue, 28 Feb 2012 23:51:04 +0000 (18:51 -0500)]
libvorbis: cosmetics: renaming/pretty-printing/comments/unused code

9 years ago(e)ac3enc: select a default bit rate based on the channel layout
Justin Ruggles [Thu, 23 Feb 2012 02:45:06 +0000 (21:45 -0500)]
(e)ac3enc: select a default bit rate based on the channel layout