From: Clément Bœsch Date: Sun, 8 Feb 2015 16:16:21 +0000 (+0100) Subject: avfilter/hqdn3d: an invalid bit depth means a bug, not invalid read data X-Git-Tag: n2.6~628 X-Git-Url: https://git.videolan.org/?p=ffmpeg.git;a=commitdiff_plain;h=55feff57cec85cfcc972d40e02af131f0cb86a34 avfilter/hqdn3d: an invalid bit depth means a bug, not invalid read data This code looks clumsy, and an assert would probably be more welcome. --- diff --git a/libavfilter/vf_hqdn3d.c b/libavfilter/vf_hqdn3d.c index 4b1f2f997f..99d22d9ff7 100644 --- a/libavfilter/vf_hqdn3d.c +++ b/libavfilter/vf_hqdn3d.c @@ -155,7 +155,7 @@ static int denoise_depth(HQDN3DContext *s, #define denoise(...) \ do { \ - int ret = AVERROR_INVALIDDATA; \ + int ret = AVERROR_BUG; \ switch (s->depth) { \ case 8: ret = denoise_depth(__VA_ARGS__, 8); break; \ case 9: ret = denoise_depth(__VA_ARGS__, 9); break; \