lavf/framecrcenc: do not hash side data
authorAnton Khirnov <anton@khirnov.net>
Sat, 24 Apr 2021 13:08:51 +0000 (15:08 +0200)
committerAnton Khirnov <anton@khirnov.net>
Sun, 9 May 2021 09:07:20 +0000 (11:07 +0200)
commitc6ae560a18d67b9ddaa25a0338b7fb55e3312e57
tree3919e0031810dd57a0e56ab23489c4446f247475
parent4d28a6756c0716c90d93c6f3995f711c0dd12f29
lavf/framecrcenc: do not hash side data

There are no guarantees that all side data types have the same
representation on all platforms.

Tests that change output due to this:

id3v2-priv-remux, cover-art-mp3-id3v2-remux, gapless-mp3: SKIP_SAMPLES,
which is tested by fate-gapless-mp3-side-data

matroska-vp8-alpha-remux: MATROSKA_BLOCKADDITIONAL, which is tested by
remux itself (side data is written into output)

matroska-mastering-display-metadata: MASTERING_DISPLAY_METADATA and
CONTENT_LIGHT_LEVEL, which are tested by ffprobe invocation in the same
test

matroska-spherical-mono-remux: STEREO3D and SPHERICAL, which are tested
by ffprobe invocation in the same test

segment-mp4-to-ts: MPEGTS_STREAM_ID, which is tested by ts remuxing
tests

webm-webvtt-remux: WEBVTT_IDENTIFIER/SETTINGS, which is tested by the
ffprobe invocation in the same test

mxf-d10-user-comments: CPB_PROPERTIES, which is tested by mxf-probe-d10

mov-cover-image: SKIP_SAMPLES, which is tested for mov by
mov-aac-2048-priming

copy-trac3074: AUDIO_SERVICE_TYPE, which is tested by fate-hls-fmp4_ac3
12 files changed:
libavformat/framecrcenc.c
tests/ref/fate/copy-trac3074
tests/ref/fate/cover-art-mp3-id3v2-remux
tests/ref/fate/gapless-mp3
tests/ref/fate/id3v2-priv-remux
tests/ref/fate/matroska-mastering-display-metadata
tests/ref/fate/matroska-spherical-mono-remux
tests/ref/fate/matroska-vp8-alpha-remux
tests/ref/fate/mov-cover-image
tests/ref/fate/mxf-d10-user-comments
tests/ref/fate/segment-mp4-to-ts
tests/ref/fate/webm-webvtt-remux