avformat/rmdec: Check size in ivr_read_packet() before use
authorMichael Niedermayer <michael@niedermayer.cc>
Thu, 14 Jan 2016 22:20:58 +0000 (23:20 +0100)
committerMichael Niedermayer <michael@niedermayer.cc>
Thu, 14 Jan 2016 22:49:52 +0000 (23:49 +0100)
Fixes out of array access
Fixes: asan_heap-oob_445b39_1741_d00eb645ab48eb2203b4a04a5b997103.ivr

Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
libavformat/rmdec.c

index 4e46a3d..ad919e8 100644 (file)
@@ -1357,6 +1357,11 @@ static int ivr_read_packet(AVFormatContext *s, AVPacket *pkt)
                 size = avio_rb32(pb);
                 avio_skip(pb, 4);
 
+                if (size < 1 || size > INT_MAX/4) {
+                    av_log(s, AV_LOG_ERROR, "size %d is invalid\n");
+                    return AVERROR_INVALIDDATA;
+                }
+
                 st = s->streams[index];
                 ret = ff_rm_parse_packet(s, pb, st, st->priv_data, size, pkt,
                                          &seq, 0, pts);