vlc.git
11 years agoWin32: fix potential error with thumbbar buttons
Geoffroy Couprie [Sat, 22 Aug 2009 13:18:07 +0000 (15:18 +0200)]
Win32: fix potential error with thumbbar buttons

11 years agoProbably fix an assumed PPC64 warning
Rémi Denis-Courmont [Sun, 6 Sep 2009 16:04:22 +0000 (19:04 +0300)]
Probably fix an assumed PPC64 warning

11 years agoOptimize a little bit more
Rémi Denis-Courmont [Sun, 6 Sep 2009 12:06:35 +0000 (15:06 +0300)]
Optimize a little bit more

11 years agoNEON vectorized fi32->s16l audio filter
Rémi Denis-Courmont [Sat, 5 Sep 2009 19:12:36 +0000 (22:12 +0300)]
NEON vectorized fi32->s16l audio filter

This conversion is always needed between mixer and output.

11 years agoconverter_neon: minor tweaks for fl32->fi32
Rémi Denis-Courmont [Sun, 6 Sep 2009 10:44:15 +0000 (13:44 +0300)]
converter_neon: minor tweaks for fl32->fi32

 * always use NEON VCVT
 * avoid pointless interlace/deinterlace in load/store

11 years agoskins2: redraw a black background required for some skins when resizing (see wb skins...
Erwan Tulou [Sun, 6 Sep 2009 10:05:09 +0000 (12:05 +0200)]
skins2: redraw a black background required for some skins when resizing (see wb skins for example)

11 years agoWin32: FromLocale/ToLocale: fix stack underflow on very long strings
Rémi Denis-Courmont [Sun, 6 Sep 2009 07:46:36 +0000 (10:46 +0300)]
Win32: FromLocale/ToLocale: fix stack underflow on very long strings

11 years agoskins2: correct typos
Erwan Tulou [Sat, 5 Sep 2009 19:25:10 +0000 (21:25 +0200)]
skins2: correct typos

11 years agoReduce register clobber
Rémi Denis-Courmont [Sat, 5 Sep 2009 19:12:24 +0000 (22:12 +0300)]
Reduce register clobber

11 years agoskins2: implement recording and next-frame
Erwan Tulou [Sat, 5 Sep 2009 15:12:07 +0000 (17:12 +0200)]
skins2: implement recording and next-frame

This patch adds the following keywords for skins developpers :
      - vlc.canRecord      (boolean / refers to can-record)
      - vlc.isRecording    (boolean / refers to record)
      - vlc.toggleRecord() (function / toggle recording)
      - vlc.nextFrame()    (function / next frame)

11 years agoskins2: replace polling with callbacks
Erwan Tulou [Sat, 5 Sep 2009 10:49:41 +0000 (12:49 +0200)]
skins2: replace polling with callbacks

11 years agoXA: group ADPCM frames per ~50ms before sending to decoder
Rémi Denis-Courmont [Sat, 5 Sep 2009 18:40:29 +0000 (21:40 +0300)]
XA: group ADPCM frames per ~50ms before sending to decoder

Sending one frame per block had way to high CPU overhead.

11 years agoqt4: playlist: allow to hide all but the index 0 column
Jakob Leben [Fri, 4 Sep 2009 01:06:26 +0000 (03:06 +0200)]
qt4: playlist: allow to hide all but the index 0 column

In some circumstances QTreeView does not behave properly if the column index 0 can hide/reappear.

Precisely, when column 0 is hidden and an item get's subitems, those subitems can not be D&D-ed.
If column 0 is then unhidden, trying to D&D the subitems will fail or result in unexpected behaviour.

11 years agoqt4: make title the first PL column
Jakob Leben [Fri, 4 Sep 2009 00:52:36 +0000 (02:52 +0200)]
qt4: make title the first PL column

So that tree branches appear on it.

11 years agoNEON float to fixed point vectorized conversion
Rémi Denis-Courmont [Sat, 5 Sep 2009 14:14:09 +0000 (17:14 +0300)]
NEON float to fixed point vectorized conversion

11 years agoAdd a CPU capability for ARM NEON
Rémi Denis-Courmont [Sat, 5 Sep 2009 13:56:25 +0000 (16:56 +0300)]
Add a CPU capability for ARM NEON

Currently, detection is done at build time. Feel free to add run-time
detect if you know how.

11 years agoconfigure: check for NEON assemly support
Rémi Denis-Courmont [Sat, 5 Sep 2009 15:18:27 +0000 (18:18 +0300)]
configure: check for NEON assemly support

11 years agoARM: pretend not lack the FPU even if we have one
Rémi Denis-Courmont [Sat, 5 Sep 2009 15:20:52 +0000 (18:20 +0300)]
ARM: pretend not lack the FPU even if we have one

While VFP/NEON do support floating point instructions, they appear to
be noticeably slower than fixed point.

11 years agoEnabled snapshot in "vout display" wrapper.
Laurent Aimar [Sat, 5 Sep 2009 09:17:11 +0000 (11:17 +0200)]
Enabled snapshot in "vout display" wrapper.

11 years agoConverted snapshot to "vout display" API.
Laurent Aimar [Sat, 5 Sep 2009 09:16:46 +0000 (11:16 +0200)]
Converted snapshot to "vout display" API.

11 years agoDecreased snapshot vout module priority to 0.
Laurent Aimar [Fri, 4 Sep 2009 18:26:06 +0000 (20:26 +0200)]
Decreased snapshot vout module priority to 0.

You don't want it to be selected automatically.

11 years agocontrib: enable XCB and XCB-UTIL for Maemo
Rémi Denis-Courmont [Sat, 5 Sep 2009 09:19:18 +0000 (12:19 +0300)]
contrib: enable XCB and XCB-UTIL for Maemo

11 years agoTypo
Rémi Denis-Courmont [Sat, 5 Sep 2009 09:12:34 +0000 (12:12 +0300)]
Typo

11 years agoduplicate: cleaning up
Rémi Denis-Courmont [Sat, 5 Sep 2009 09:00:55 +0000 (12:00 +0300)]
duplicate: cleaning up

11 years agoduplicate: fix bug of NumInRange(), i_stop always < 0
Andy chenee [Thu, 3 Sep 2009 17:21:52 +0000 (01:21 +0800)]
duplicate: fix bug of NumInRange(), i_stop always < 0

Signed-off-by: Rémi Denis-Courmont <remi@remlab.net>
11 years agocontrib: Maemo use Tremor instead of Vorbis
Rémi Denis-Courmont [Sat, 5 Sep 2009 08:47:40 +0000 (11:47 +0300)]
contrib: Maemo use Tremor instead of Vorbis

This seems about twice as fast.

11 years agoReport RTP packet loss and make PIM Asserts only a debug event
Marian Ďurkovič [Sat, 5 Sep 2009 08:44:33 +0000 (11:44 +0300)]
Report RTP packet loss and make PIM Asserts only a debug event

(Closes: #2718)

Signed-off-by: Rémi Denis-Courmont <remi@remlab.net>
11 years agoRTP: fix re-ordering across sequence number wrap
Rémi Denis-Courmont [Sat, 5 Sep 2009 08:39:21 +0000 (11:39 +0300)]
RTP: fix re-ordering across sequence number wrap

Pointed-out-by: Marian Ďurkovič <md@bts.sk>
11 years agoUse vlc_object_get_name()
Rémi Denis-Courmont [Sat, 5 Sep 2009 08:00:07 +0000 (11:00 +0300)]
Use vlc_object_get_name()

11 years agoExport vlc_object_get_name
Rémi Denis-Courmont [Sat, 5 Sep 2009 07:59:47 +0000 (10:59 +0300)]
Export vlc_object_get_name

11 years agoDeprecate vlc_object_find_name()
Rémi Denis-Courmont [Sat, 5 Sep 2009 08:08:41 +0000 (11:08 +0300)]
Deprecate vlc_object_find_name()

11 years agoFix warning
Rémi Denis-Courmont [Sat, 5 Sep 2009 07:59:22 +0000 (10:59 +0300)]
Fix warning

11 years agomacosx/framework: share folder should be in the framework.
Pierre d'Herbemont [Sat, 5 Sep 2009 00:15:49 +0000 (02:15 +0200)]
macosx/framework: share folder should be in the framework.

Else we won't have any lua scripts.

11 years agopython-ctypes: provide a helper pygtk VLCWidget which also serves as example player...
Olivier Aubert [Fri, 4 Sep 2009 14:31:50 +0000 (16:31 +0200)]
python-ctypes: provide a helper pygtk VLCWidget which also serves as example player app.

11 years agopython-ctypes: improve enum conversion
Olivier Aubert [Fri, 4 Sep 2009 13:40:09 +0000 (15:40 +0200)]
python-ctypes: improve enum conversion

11 years agoFix comment
Olivier Aubert [Fri, 4 Sep 2009 13:39:18 +0000 (15:39 +0200)]
Fix comment

11 years agocontribs: fixed packages for x86_64 *coughcough*
Felix Paul Kühne [Fri, 4 Sep 2009 12:47:35 +0000 (14:47 +0200)]
contribs: fixed packages for x86_64 *coughcough*

Signed-off-by: Felix Paul Kühne <fkuehne@videolan.org>
11 years agocontribs: compilation fix
Felix Paul Kühne [Fri, 4 Sep 2009 11:10:02 +0000 (13:10 +0200)]
contribs: compilation fix

11 years agofreetype: LucidaGrande is stored in a different format in Snow Leopard and therefore...
Felix Paul Kühne [Fri, 4 Sep 2009 10:39:47 +0000 (12:39 +0200)]
freetype: LucidaGrande is stored in a different format in Snow Leopard and therefore at another location

11 years agoFixed major crash on Snow Leopard pointed by Pierre
Felix Paul Kühne [Fri, 4 Sep 2009 10:32:20 +0000 (12:32 +0200)]
Fixed major crash on Snow Leopard pointed by Pierre

11 years agoAdd horizontal scrollbar to MediaInfo's third panel to fully show EPG info
Marian Ďurkovič [Wed, 2 Sep 2009 05:45:21 +0000 (07:45 +0200)]
Add horizontal scrollbar to MediaInfo's third panel to fully show EPG info

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>
11 years agoTypo again...
Jean-Baptiste Kempf [Thu, 3 Sep 2009 21:20:44 +0000 (23:20 +0200)]
Typo again...

I must have done something wrong with my VIM.

11 years agoFix demuxdump to work with RTP input, which would dump garbage when RTP
Marian Ďurkovič [Fri, 4 Sep 2009 09:36:47 +0000 (11:36 +0200)]
Fix demuxdump to work with RTP input, which would dump garbage when RTP
input is used. When stream_Read was used alone, it read 1316 bytes from
the RTP input add added garbage upto DUMP_BLOCKSIZE. With stream_Peek it
works as expected and also makes the whole demuxdump faster.

Signed-off-by: JP Dinger <jpd@videolan.org>
11 years agospdif: Add a comment to explicitely explain why we don't free old buffer.
Pierre d'Herbemont [Thu, 3 Sep 2009 21:30:53 +0000 (23:30 +0200)]
spdif: Add a comment to explicitely explain why we don't free old buffer.

11 years agoFixed dummy input Control function.
Laurent Aimar [Thu, 3 Sep 2009 21:01:09 +0000 (23:01 +0200)]
Fixed dummy input Control function.

DEMUX_GET_PTS_DELAY must not fail for an access_demux.

11 years agoFixed segfault with spdif mixer.
Laurent Aimar [Thu, 3 Sep 2009 20:37:16 +0000 (22:37 +0200)]
Fixed segfault with spdif mixer.

 The aout core use a hack to avoid useless memcpy: the buffer in which
to mix is the same as the one in the first active input fifo.

11 years agoChecked demux_Control return value in input.
Laurent Aimar [Thu, 3 Sep 2009 20:25:20 +0000 (22:25 +0200)]
Checked demux_Control return value in input.

11 years agoavcodec, avformat, postproc and switcher link against avutil
Rémi Denis-Courmont [Thu, 3 Sep 2009 19:46:50 +0000 (22:46 +0300)]
avcodec, avformat, postproc and switcher link against avutil

Contrary to swscale(?), those plugins call avutil directly

11 years agoFixed invalid p_aout->p_mixer usage in aout input.
Laurent Aimar [Thu, 3 Sep 2009 19:23:44 +0000 (21:23 +0200)]
Fixed invalid p_aout->p_mixer usage in aout input.

11 years agoChorus_flanger needs -lm
Rémi Denis-Courmont [Thu, 3 Sep 2009 19:16:58 +0000 (22:16 +0300)]
Chorus_flanger needs -lm

11 years agocontrib: and libxcb and xcb-util
Rémi Denis-Courmont [Thu, 3 Sep 2009 18:36:26 +0000 (21:36 +0300)]
contrib: and libxcb and xcb-util

11 years agocontrib: remove pointless patch and avoid libtool/autogen.sh hell
Rémi Denis-Courmont [Thu, 3 Sep 2009 17:53:21 +0000 (20:53 +0300)]
contrib: remove pointless patch and avoid libtool/autogen.sh hell

11 years agocontrib: build faad with fixed point on ARM
Rémi Denis-Courmont [Tue, 1 Sep 2009 20:06:38 +0000 (23:06 +0300)]
contrib: build faad with fixed point on ARM

It would seem to be significantly faster that way.

11 years agocontrib: Maemo: enable optimizations except tree vectorization
Rémi Denis-Courmont [Tue, 1 Sep 2009 15:02:32 +0000 (18:02 +0300)]
contrib: Maemo: enable optimizations except tree vectorization

11 years agocontrib: typo
Rémi Denis-Courmont [Tue, 1 Sep 2009 15:02:09 +0000 (18:02 +0300)]
contrib: typo

11 years agoContrib: Maemo: do not use ARM Thumb ISA
Rémi Denis-Courmont [Mon, 31 Aug 2009 20:14:24 +0000 (23:14 +0300)]
Contrib: Maemo: do not use ARM Thumb ISA

This was unstable.

11 years agoPhantom xcb_aux dependency
Rémi Denis-Courmont [Thu, 3 Sep 2009 19:15:48 +0000 (22:15 +0300)]
Phantom xcb_aux dependency

11 years agoFixed video_filter chain for chroma conversion.
Laurent Aimar [Thu, 3 Sep 2009 19:15:57 +0000 (21:15 +0200)]
Fixed video_filter chain for chroma conversion.

11 years agoDo not check rgb masks for YUV in GetFfmpegChroma.
Laurent Aimar [Thu, 3 Sep 2009 19:04:54 +0000 (21:04 +0200)]
Do not check rgb masks for YUV in GetFfmpegChroma.

11 years agolibvlc_media_library: Remove a non sense.
Pierre d'Herbemont [Thu, 3 Sep 2009 17:20:38 +0000 (19:20 +0200)]
libvlc_media_library: Remove a non sense.

11 years agoam: In non verbose be silent when we 'cd src && make install' in the VLC.app targets.
Pierre d'Herbemont [Thu, 3 Sep 2009 17:15:38 +0000 (19:15 +0200)]
am: In non verbose be silent when we 'cd src && make install' in the VLC.app targets.

11 years agoconfigure: Don't link macosx to QTKit.
Pierre d'Herbemont [Thu, 3 Sep 2009 17:14:57 +0000 (19:14 +0200)]
configure: Don't link macosx to QTKit.

We don't need it.

11 years agomacosx: Don't output any error when sending the crash log worked.
Pierre d'Herbemont [Thu, 3 Sep 2009 17:12:48 +0000 (19:12 +0200)]
macosx: Don't output any error when sending the crash log worked.

We don't want users to not press this button just because there is an other one afterwards.

11 years agopython-ctypes: implement consistency checker, and fix detected errors in include...
Olivier Aubert [Thu, 3 Sep 2009 15:33:43 +0000 (17:33 +0200)]
python-ctypes: implement consistency checker, and fix detected errors in include files

11 years agopython-ctypes: fix Logger bindings.
Olivier Aubert [Thu, 3 Sep 2009 15:22:22 +0000 (17:22 +0200)]
python-ctypes: fix Logger bindings.

11 years agolibvlc.h: fix incorrect comment docstring
Olivier Aubert [Thu, 3 Sep 2009 15:06:54 +0000 (17:06 +0200)]
libvlc.h: fix incorrect comment docstring

11 years agopython: workaround a vlc-config issue on win32 (reported by <nicola.murino@gmail...
Olivier Aubert [Thu, 3 Sep 2009 11:38:47 +0000 (13:38 +0200)]
python: workaround a vlc-config issue on win32 (reported by <nicola.murino@gmail.com>)

11 years agocontribs: another contrib package fixing the libiconv issues on Snow Leopard. Intel...
Felix Paul Kühne [Thu, 3 Sep 2009 14:54:39 +0000 (16:54 +0200)]
contribs: another contrib package fixing the libiconv issues on Snow Leopard. Intel-only.

11 years agocontribs: 32bit builds need the libiconv replacement as well on Snow Leopard
Felix Paul Kühne [Thu, 3 Sep 2009 14:39:52 +0000 (16:39 +0200)]
contribs: 32bit builds need the libiconv replacement as well on Snow Leopard

Signed-off-by: Felix Paul Kühne <fkuehne@videolan.org>
11 years agoJVLC: update libVLC event types.
Rémi Duraffort [Thu, 3 Sep 2009 14:02:54 +0000 (16:02 +0200)]
JVLC: update libVLC event types.

11 years agoaout_BufferAlloc : returns the allocated buffer
Rafaël Carré [Thu, 3 Sep 2009 14:10:12 +0000 (16:10 +0200)]
aout_BufferAlloc : returns the allocated buffer

11 years agoRemove unused alloca.h, add an assertion
Rafaël Carré [Thu, 3 Sep 2009 14:05:07 +0000 (16:05 +0200)]
Remove unused alloca.h, add an assertion

11 years agoaout_BufferAlloc() : remove stack allocation
Rafaël Carré [Thu, 3 Sep 2009 13:03:07 +0000 (15:03 +0200)]
aout_BufferAlloc() : remove stack allocation

alloca() was not used anyway on OSX and BSD, due to smaller stack sizes,
and we can't assume a default stack size anyway

I expect the performance loss to be minimal, but worth the code
simplification anyway (i didn't benchmark)

aout_BufferAlloc() is moved into its own function in a .c file instead
of being a macro

Since there is now 2 types of allocations (HEAP and NONE), make
i_alloc_type a boolean (true = HEAP alloc, false = NO alloc)

make aout_BufferFree() a static inline function in the same process.
Prototype doesn't change since the provided buffer doesn't need to be
set to NULL (I checked all the callers)

11 years agosrc/ : missing assert.h include
Rafaël Carré [Thu, 3 Sep 2009 11:38:26 +0000 (13:38 +0200)]
src/ : missing assert.h include

11 years agoJVLC: file name consitency.
Rémi Duraffort [Thu, 3 Sep 2009 10:58:51 +0000 (12:58 +0200)]
JVLC: file name consitency.

11 years agoTypo
Sébastien Escudier [Thu, 3 Sep 2009 09:00:54 +0000 (11:00 +0200)]
Typo

Signed-off-by: Rémi Duraffort <ivoire@videolan.org>
11 years agoadd_bool: wants a boolean.
Rémi Duraffort [Thu, 3 Sep 2009 09:25:31 +0000 (11:25 +0200)]
add_bool: wants a boolean.

11 years agoftp: let the user see the password in the conf (was a bad idea to hide it).
Rémi Duraffort [Thu, 3 Sep 2009 09:23:20 +0000 (11:23 +0200)]
ftp: let the user see the password in the conf (was a bad idea to hide it).

11 years agogitignore: fix file mode.
Rémi Duraffort [Thu, 3 Sep 2009 09:20:42 +0000 (11:20 +0200)]
gitignore: fix file mode.

11 years agovariables: warn if var_CountChoices result isn't used.
Rémi Duraffort [Thu, 3 Sep 2009 09:12:09 +0000 (11:12 +0200)]
variables: warn if var_CountChoices result isn't used.

11 years agoavcodec_video: cosmetics (use var_CreateGet whe applicable).
Rémi Duraffort [Thu, 3 Sep 2009 09:05:03 +0000 (11:05 +0200)]
avcodec_video: cosmetics (use var_CreateGet whe applicable).

11 years agopython: use new function libvlc_errmsg (reported by Xitij Patel <xitij.patel@xitijpat...
Olivier Aubert [Thu, 3 Sep 2009 08:56:35 +0000 (10:56 +0200)]
python: use new function libvlc_errmsg (reported by Xitij Patel <xitij.patel@xitijpatel.com>)

11 years agopython-ctypes: really accomodate new and old-style exception message getting method
Olivier Aubert [Thu, 3 Sep 2009 08:50:34 +0000 (10:50 +0200)]
python-ctypes: really accomodate new and old-style exception message getting method

11 years agolibvlc.h: mark libvlc_errmsg and libvlc_clearerr with VLC_PUBLIC_API
Olivier Aubert [Thu, 3 Sep 2009 08:49:07 +0000 (10:49 +0200)]
libvlc.h: mark libvlc_errmsg and libvlc_clearerr with VLC_PUBLIC_API

11 years agopython: remove get_vlc_id
Olivier Aubert [Thu, 3 Sep 2009 08:36:49 +0000 (10:36 +0200)]
python: remove get_vlc_id

11 years agopython: fix undefined/badly defined method bindings (reported by Xitij Patel <xitij...
Olivier Aubert [Thu, 3 Sep 2009 08:36:04 +0000 (10:36 +0200)]
python: fix undefined/badly defined method bindings (reported by Xitij Patel <xitij.patel@xitijpatel.com>)

11 years agopython-ctypes: implement comparison operators for enum classes
Olivier Aubert [Thu, 3 Sep 2009 08:31:36 +0000 (10:31 +0200)]
python-ctypes: implement comparison operators for enum classes

11 years agopython-ctypes: tweak exception handling
Olivier Aubert [Thu, 3 Sep 2009 07:57:03 +0000 (09:57 +0200)]
python-ctypes: tweak exception handling

11 years agoavcodec: use AV_VERSION_INT.
Rémi Duraffort [Thu, 3 Sep 2009 08:16:17 +0000 (10:16 +0200)]
avcodec: use AV_VERSION_INT.

11 years agoAvcodec: safeguard for people not using the latest libavcodec
Jean-Baptiste Kempf [Thu, 3 Sep 2009 08:05:41 +0000 (10:05 +0200)]
Avcodec: safeguard for people not using the latest libavcodec

11 years agocontribs: fixed correct package selection for x86_64 on Darwin broken in [c1bc979ea72...
Felix Paul Kühne [Wed, 2 Sep 2009 23:51:48 +0000 (01:51 +0200)]
contribs: fixed correct package selection for x86_64 on Darwin broken in [c1bc979ea72d16d07515a214a4adce210896e467]

11 years agoContrib: Deactivate ac3 encoder on Win64 if we want a chance to build
Jean-Baptiste Kempf [Wed, 2 Sep 2009 23:04:20 +0000 (01:04 +0200)]
Contrib: Deactivate ac3 encoder on Win64 if we want a chance to build

11 years agoContrib: use athlon64 as the basic cpu for x86_64
Jean-Baptiste Kempf [Wed, 2 Sep 2009 22:28:32 +0000 (00:28 +0200)]
Contrib: use athlon64 as the basic cpu for x86_64

11 years agoWin64: more work from iconv from NightStrike
Jean-Baptiste Kempf [Wed, 2 Sep 2009 22:03:22 +0000 (00:03 +0200)]
Win64: more work from iconv from NightStrike

11 years agoContrib: fix even more libiconv win64 patch
Jean-Baptiste Kempf [Wed, 2 Sep 2009 21:24:52 +0000 (23:24 +0200)]
Contrib: fix even more libiconv win64 patch

11 years agomacosx/framework: added a hack to fix compilation on Snow Leopard against the 10...
Felix Paul Kühne [Wed, 2 Sep 2009 21:22:07 +0000 (23:22 +0200)]
macosx/framework: added a hack to fix compilation on Snow Leopard against the 10.5 SDK

11 years ago10l: Fix typo
Jean-Baptiste Kempf [Wed, 2 Sep 2009 20:28:26 +0000 (22:28 +0200)]
10l: Fix typo

11 years agoUpdate libiconv to latest release...
Jean-Baptiste Kempf [Wed, 2 Sep 2009 20:22:42 +0000 (22:22 +0200)]
Update libiconv to latest release...

The enormous mac patch is discarded. But we couldn't stay with such an old version anyway.

11 years agoWMAPro: increase the i_output_max to have a proper decoding
Jean-Baptiste Kempf [Wed, 2 Sep 2009 18:48:40 +0000 (20:48 +0200)]
WMAPro: increase the i_output_max to have a proper decoding

11 years agoFourCC reordering for Audio
Jean-Baptiste Kempf [Wed, 2 Sep 2009 17:49:22 +0000 (19:49 +0200)]
FourCC reordering for Audio