Kill stupid VOUT_SNAPSHOT control.
authorRémi Denis-Courmont <rdenis@simphalempin.com>
Sat, 14 Feb 2009 17:58:03 +0000 (19:58 +0200)
committerRémi Denis-Courmont <rdenis@simphalempin.com>
Sat, 14 Feb 2009 18:02:31 +0000 (20:02 +0200)
commit53195e9fc7c31e8ae3aeead4879477aa950513b4
tree5a67eab48e0b57338ac1e6a8c704f6c69504bb9c
parent003d86fa032d98fbb096fb6b656fc9332e01fca2
Kill stupid VOUT_SNAPSHOT control.

Calling vout_Control() after vlc_object_find() or input_GetVouts is not
valid. It cannot be. There is no warranty that pf_control is valid (the
video output plugin could be initializing or deinitializing). Even if
there were a lock without the pf_control implementation (as with X11),
it still wouldn't work.

Anyway, in this particular case, we already have video-snapshot to do
the exact same thing in a safe manner.

There remain some issues with snapshots:
 - there is no synchronization of b_snapshoy with the video thread,
 - there is no/incomplete error handling,
 - there is no protection against multiple concurrent snapshot reqs.
12 files changed:
include/vlc_vout.h
modules/control/hotkeys.c
modules/control/http/rpn.c
modules/gui/macosx/vout.m
modules/gui/maemo/maemo_callbacks.c
modules/gui/qt4/actions_manager.cpp
modules/gui/skins2/commands/cmd_snapshot.cpp
modules/video_output/opengl.c
modules/video_output/opengllayer.m
src/control/mediacontrol_audio_video.c
src/control/video.c
src/video_output/vout_intf.c