aacenc_ltp: fix out of bounds memory access
authorRostislav Pehlivanov <atomnuker@gmail.com>
Thu, 3 Dec 2015 23:12:37 +0000 (23:12 +0000)
committerRostislav Pehlivanov <atomnuker@gmail.com>
Thu, 3 Dec 2015 23:12:37 +0000 (23:12 +0000)
Discovered by Coverity.

libavcodec/aacenc_ltp.c
tests/fate/aac.mak

index e19f3cc..1917ee9 100644 (file)
@@ -167,7 +167,7 @@ void ff_aac_search_for_ltp(AACEncContext *s, SingleChannelElement *sce,
 
     if (sce->ics.window_sequence[0] == EIGHT_SHORT_SEQUENCE) {
         if (sce->ics.ltp.lag) {
-            memset(&sce->lcoeffs[0], 0.0f, 3072*sizeof(sce->lcoeffs[0]));
+            memset(&sce->ltp_state[0], 0, 3072*sizeof(sce->ltp_state[0]));
             memset(&sce->ics.ltp, 0, sizeof(LongTermPrediction));
         }
         return;
index 7a6c734..09777af 100644 (file)
@@ -209,7 +209,7 @@ fate-aac-ltp-encode: CMD = enc_dec_pcm adts wav s16le $(TARGET_SAMPLES)/audio-re
 fate-aac-ltp-encode: CMP = stddev
 fate-aac-ltp-encode: REF = $(SAMPLES)/audio-reference/luckynight_2ch_44kHz_s16.wav
 fate-aac-ltp-encode: CMP_SHIFT = -4096
-fate-aac-ltp-encode: CMP_TARGET = 1284
+fate-aac-ltp-encode: CMP_TARGET = 1273
 fate-aac-ltp-encode: SIZE_TOLERANCE = 3560
 fate-aac-ltp-encode: FUZZ = 17