configure: make assignment of variable to '=' explicit
authorGanesh Ajjanagadde <gajjanagadde@gmail.com>
Sun, 13 Sep 2015 06:26:04 +0000 (02:26 -0400)
committerTimothy Gu <timothygu99@gmail.com>
Tue, 15 Sep 2015 21:58:48 +0000 (14:58 -0700)
op== is confusing, as it may easily be mistook for an equality check,
while in reality it is doing an assigment to '='.
This patch has the additional benefit of cleaning up 2 warnings from shellcheck.net.

Signed-off-by: Ganesh Ajjanagadde <gajjanagadde@gmail.com>
configure

index da18e70..2fb625b 100755 (executable)
--- a/configure
+++ b/configure
@@ -622,12 +622,12 @@ enable_deep_weak(){
 }
 
 enabled(){
-    test "${1#!}" = "$1" && op== || op=!=
+    test "${1#!}" = "$1" && op='=' || op=!=
     eval test "x\$${1#!}" $op "xyes"
 }
 
 disabled(){
-    test "${1#!}" = "$1" && op== || op=!=
+    test "${1#!}" = "$1" && op='=' || op=!=
     eval test "x\$${1#!}" $op "xno"
 }