vlc.git
8 years agoFix a segfault (buffer overflow for win32 only).
Rémi Duraffort [Wed, 24 Jun 2009 14:20:40 +0000 (16:20 +0200)]
Fix a segfault (buffer overflow for win32 only).

8 years agoFix memleak when using --demux.
Rémi Duraffort [Wed, 24 Jun 2009 09:51:29 +0000 (11:51 +0200)]
Fix memleak when using --demux.

8 years agoCosmetics.
Rémi Duraffort [Wed, 24 Jun 2009 08:11:02 +0000 (10:11 +0200)]
Cosmetics.

8 years agoCleaning.
Rémi Duraffort [Wed, 24 Jun 2009 08:07:16 +0000 (10:07 +0200)]
Cleaning.

8 years agoinput_item_SetURI(): add a NDEBUG printf check for paths.
Derk-Jan Hartman [Wed, 24 Jun 2009 14:22:29 +0000 (16:22 +0200)]
input_item_SetURI(): add a NDEBUG printf check for paths.

When it is called with strings that contain " " or '\' or don't have ://, we have an indication that the caller is likely providing a path. This will help us find these cases in the future.

8 years agoImprove x11 xinerama fullscreen window placement
Ilkka Ollakka [Wed, 24 Jun 2009 13:52:36 +0000 (16:52 +0300)]
Improve x11 xinerama fullscreen window placement

Select fullscreen display the one that has most of the video-window,
then you get qt4 fullscreencontroller on same display also, and it's
more logical (imo). Algorithm is prettymuch the same as Nigel Tao has
made in his gpl2 project superswitcher, Didn't want to reinvent this
with different variable-names ;)

8 years agoinput: SetURI No longer use DIRSEP. We are dealing with URIs, not paths.
Derk-Jan Hartman [Wed, 24 Jun 2009 12:28:20 +0000 (14:28 +0200)]
input: SetURI No longer use DIRSEP. We are dealing with URIs, not paths.

8 years agomacosx: Ignore attachment:// in Art uri for now.
Derk-Jan Hartman [Wed, 24 Jun 2009 11:19:28 +0000 (13:19 +0200)]
macosx: Ignore attachment:// in Art uri for now.

8 years agomacosx: Just use openWithURL, instead of uri->path
Derk-Jan Hartman [Wed, 24 Jun 2009 11:13:37 +0000 (13:13 +0200)]
macosx: Just use openWithURL, instead of uri->path

8 years agolibvlc: Abort in case of unhandled exception.
Pierre d'Herbemont [Wed, 24 Jun 2009 05:03:57 +0000 (22:03 -0700)]
libvlc: Abort in case of unhandled exception.

8 years agoskins2: solve crashes due to releasing variables at termination
Erwan Tulou [Tue, 23 Jun 2009 21:30:01 +0000 (23:30 +0200)]
skins2: solve crashes due to releasing variables at termination

skins was using two lists of variables (named and anonymous).
The problem was that variables from one list held references to variables from the other list and vice-versa. Whatever the order of releasing them, crashes could occur.

This patch uses the anonymous list to keep a reference on **all** variables.
This guarantees they are released in the reverse order from creation.

8 years agoWhen we fill the name of an input item with URI parts, use decode_URI() so it becomes...
Derk-Jan Hartman [Tue, 23 Jun 2009 21:06:47 +0000 (23:06 +0200)]
When we fill the name of an input item with URI parts, use decode_URI() so it becomes easier to read.

8 years agoDo not inherit xspf-open demux from media library
Rémi Denis-Courmont [Tue, 23 Jun 2009 20:08:28 +0000 (23:08 +0300)]
Do not inherit xspf-open demux from media library

8 years agoXSPF: remove harmful base decoding
Rémi Denis-Courmont [Tue, 23 Jun 2009 19:37:30 +0000 (22:37 +0300)]
XSPF: remove harmful base decoding

8 years agoAssume input_item_t->psz_uri contains an URI
Rafaël Carré [Tue, 23 Jun 2009 19:27:42 +0000 (21:27 +0200)]
Assume input_item_t->psz_uri contains an URI

, like the name indicates.
Pass unmodified URIs from xspf to vlc, and stores them in xspf
unmodified as well

This commit partly reverts [9a746cfa3078c53eed57d2102002b39c283c6ab4]
Code using psz_uri should be checked for consistency, and GUIs might want to decode components at display

8 years agoplaylist_MLLoad: format library URI correctly
Rémi Denis-Courmont [Tue, 23 Jun 2009 19:13:24 +0000 (22:13 +0300)]
playlist_MLLoad: format library URI correctly

8 years agoplaylist_Import: use make_URI
Rémi Denis-Courmont [Tue, 23 Jun 2009 18:50:32 +0000 (21:50 +0300)]
playlist_Import: use make_URI

8 years agoExcessive white space
Rémi Denis-Courmont [Tue, 23 Jun 2009 18:40:04 +0000 (21:40 +0300)]
Excessive white space

8 years agostring: missing space
Derk-Jan Hartman [Tue, 23 Jun 2009 12:22:09 +0000 (14:22 +0200)]
string: missing space

8 years agoAdding a libvlc_media_add_option_flag
Hugo Beauzee-Luyssen [Thu, 18 Jun 2009 22:05:50 +0000 (00:05 +0200)]
Adding a libvlc_media_add_option_flag

Signed-off-by: Rémi Denis-Courmont <remi@remlab.net>
8 years agoTypo.
Rémi Duraffort [Tue, 23 Jun 2009 06:25:59 +0000 (08:25 +0200)]
Typo.

8 years agoskins2: ensure the new SubX default skins doesn't crash on exit
Erwan Tulou [Mon, 22 Jun 2009 21:24:51 +0000 (23:24 +0200)]
skins2: ensure the new SubX default skins doesn't crash on exit

SubX crashed on both Linux and Windows in a set::erase call (STL) when releasing C++ objects. Swapping two loops solved it. (the second loop was referencing variables released in the first loop). This makes SubX terminate nicely, but doesn't solve all crashes for skins2. (more cleanup to do)

8 years agomacosx: memleak due to unneeded strdup()
Derk-Jan Hartman [Mon, 22 Jun 2009 19:39:07 +0000 (21:39 +0200)]
macosx: memleak due to unneeded strdup()

8 years agorotate filter: Avoid a crash
Derk-Jan Hartman [Mon, 22 Jun 2009 18:52:53 +0000 (20:52 +0200)]
rotate filter: Avoid a crash

This fixes a DIVIDEBYZERO crash in the rotate filter. Does not seem like the right solution to me, but dionoea should probably look into that, since he wrote most of this filter.

This crash occured with http://streams.videolan.org/issues/HIGNFY%20S25E02%20-%20Part%201.flv

plane 1 (non Y-plane)
i_visible_lines = 119
p_pic->p[Y_PLANE].i_visible_pitch = 320
p_pic->p[Y_PLANE].i_visible_lines = 239
i_visible_pitch = 160

8 years agomacosx: NSScreen(VLCAdditions) does not leak.
Derk-Jan Hartman [Mon, 22 Jun 2009 18:29:13 +0000 (20:29 +0200)]
macosx: NSScreen(VLCAdditions) does not leak.

The Objective-C runtime will properly unload this at the end of the application. The mozilla plugin should not even be using this at all.

8 years agoRevert "macosx: NSScreen dealloc is not only called at end of execution of course."
Derk-Jan Hartman [Mon, 22 Jun 2009 18:27:37 +0000 (20:27 +0200)]
Revert "macosx: NSScreen dealloc is not only called at end of execution of course."

This was even worse. +load() != init()
This reverts commit b5feb899d6047e2371ce18fe7d73c51fe270e2a1.

8 years agomacosx@core: removed the usage of dyld's 'Library Functions' completely
Felix Paul Kühne [Mon, 22 Jun 2009 18:32:03 +0000 (20:32 +0200)]
macosx@core: removed the usage of dyld's 'Library Functions' completely

these are automagically 'replaced by the more efficient 'Dynamic Loader Compatibility Functions.'' as suggested by Apple's documentation. IMO, this should be ported to the 1.0-bugfix branch as it cleanly fixes some 64bit crashes and should improve the performance slightly

8 years agomacosx: NSScreen dealloc is not only called at end of execution of course.
Derk-Jan Hartman [Mon, 22 Jun 2009 17:55:12 +0000 (19:55 +0200)]
macosx: NSScreen dealloc is not only called at end of execution of course.

This fixes the NSScreen crash, which could be accurately reproduced by following the steps in #2880.

8 years agopanoramix filter needs xcb-randr 1.3
Rémi Denis-Courmont [Mon, 22 Jun 2009 17:35:58 +0000 (20:35 +0300)]
panoramix filter needs xcb-randr 1.3

8 years agoRevert "xcb: as we require version 1.3, let's at least test in configure for it too."
Rémi Denis-Courmont [Mon, 22 Jun 2009 17:35:38 +0000 (20:35 +0300)]
Revert "xcb: as we require version 1.3, let's at least test in configure for it too."

This reverts commit 4a6e2de24341848c5592bf67ad4377d624d6f997.

8 years agoRemove vlc_UrlEncode
Rémi Denis-Courmont [Mon, 22 Jun 2009 16:45:52 +0000 (19:45 +0300)]
Remove vlc_UrlEncode

8 years agoRemove non-existent target
Rémi Denis-Courmont [Mon, 22 Jun 2009 16:45:29 +0000 (19:45 +0300)]
Remove non-existent target

8 years agoSimplification.
Rémi Duraffort [Mon, 22 Jun 2009 12:37:47 +0000 (14:37 +0200)]
Simplification.

8 years agopodcast: save configuration when adding/removing podcast from the dialog.
Rémi Duraffort [Mon, 22 Jun 2009 11:39:53 +0000 (13:39 +0200)]
podcast: save configuration when adding/removing podcast from the dialog.

8 years agoskins2(SubX): correct a typo ("notdvd.isActive" => "not dvd.isActive" )
Erwan Tulou [Mon, 22 Jun 2009 14:32:14 +0000 (16:32 +0200)]
skins2(SubX): correct a typo ("notdvd.isActive" => "not dvd.isActive" )

8 years agoCloses #2875 : relative paths in xspf playlists
Rafaël Carré [Mon, 22 Jun 2009 13:44:52 +0000 (15:44 +0200)]
Closes #2875 : relative paths in xspf playlists

8 years agocopy paste mistake in [7f43b9342a40189805621c02345539e42eae4c94]
Derk-Jan Hartman [Mon, 22 Jun 2009 10:54:22 +0000 (12:54 +0200)]
copy paste mistake in [7f43b9342a40189805621c02345539e42eae4c94]

8 years agomacosx plugin: Set miminum system version for the mozilla plugin as well.
Derk-Jan Hartman [Mon, 22 Jun 2009 10:46:57 +0000 (12:46 +0200)]
macosx plugin: Set miminum system version for the mozilla plugin as well.

8 years agomacosx: Set minimum OS version for the VLC application bundle
Derk-Jan Hartman [Mon, 22 Jun 2009 10:44:37 +0000 (12:44 +0200)]
macosx: Set minimum OS version for the VLC application bundle

This works with 10.2, 10.3 and 10.4, but 10.3 requires the code we have in VLCApplication.

8 years agomacosx: Update list of extensions. Fix video.icns -> movie.icns
Derk-Jan Hartman [Fri, 19 Jun 2009 13:30:28 +0000 (15:30 +0200)]
macosx: Update list of extensions. Fix video.icns ->  movie.icns
(cherry picked from commit 8b9d73a700bf003be654750df29f5af30f854bfd)

Signed-off-by: Derk-Jan Hartman <hartman@videolan.org>
8 years agoCosmetics in live555: Factor out duplicate code, avoid ``? True : False''.
JP Dinger [Mon, 22 Jun 2009 09:28:52 +0000 (11:28 +0200)]
Cosmetics in live555: Factor out duplicate code, avoid ``? True : False''.

8 years agoSplit the test for user/passwd and the test for the port number (the two tests are...
Rémi Duraffort [Mon, 22 Jun 2009 08:25:40 +0000 (10:25 +0200)]
Split the test for user/passwd and the test for the port number (the two tests are independent).

Signed-off-by: JP Dinger <jpd@videolan.org>
8 years agoFix the previsous commit: if the user or the password is set in the url, use
Rémi Duraffort [Mon, 22 Jun 2009 07:40:24 +0000 (09:40 +0200)]
Fix the previsous commit: if the user or the password is set in the url, use
it.

8 years agoThese header files are global and not local.
Rémi Duraffort [Mon, 22 Jun 2009 06:47:37 +0000 (08:47 +0200)]
These header files are global and not local.

8 years agoCleaning.
Rémi Duraffort [Mon, 22 Jun 2009 06:40:52 +0000 (08:40 +0200)]
Cleaning.

8 years agoRemove duplicate code.
Rémi Duraffort [Mon, 22 Jun 2009 06:31:51 +0000 (08:31 +0200)]
Remove duplicate code.

8 years agoAdd missing CoUninitialize.
Rémi Duraffort [Mon, 22 Jun 2009 06:12:24 +0000 (08:12 +0200)]
Add missing CoUninitialize.
For each CoInitialize we have to call CoUninitialize.

8 years agoFIx a segfault: we need both user and password to be not NULL.
Rémi Duraffort [Mon, 22 Jun 2009 05:47:22 +0000 (07:47 +0200)]
FIx a segfault: we need both user and password to be not NULL.

8 years agomac text renderer: Fix a nasty crash in the YUVA renderer
Derk-Jan Hartman [Sun, 21 Jun 2009 21:36:05 +0000 (23:36 +0200)]
mac text renderer: Fix a nasty crash in the YUVA renderer

This really fixes #2649
This entire module needs some refinement, but since we are gonna have to dump it for CoreText very soon, there is little point in doing that.

8 years agomac text renderer: make sure our picture is of the right height.
Derk-Jan Hartman [Sun, 21 Jun 2009 21:00:59 +0000 (23:00 +0200)]
mac text renderer: make sure our picture is of the right height.

This will likely fix #2649

8 years agoxcb: as we require version 1.3, let's at least test in configure for it too.
Dominique Leuenberger [Fri, 19 Jun 2009 14:56:02 +0000 (16:56 +0200)]
xcb: as we require version 1.3, let's at least test in configure for it too.

Signed-off-by: JP Dinger <jpd@videolan.org>
(If at all possible, we should reduce the requirements instead.)

8 years agoQt: use the native dialog for Save Playlist
Jean-Baptiste Kempf [Sun, 21 Jun 2009 16:02:42 +0000 (18:02 +0200)]
Qt: use the native dialog for Save Playlist

This is better for translations, and look'n feel.
This defaults the name to .xspf, if not a valid extension is provided.

8 years agoQt: reinventing the wheel is always a good solution.
Jean-Baptiste Kempf [Sun, 21 Jun 2009 02:03:26 +0000 (04:03 +0200)]
Qt: reinventing the wheel is always a good solution.

8 years agoQt: be sure to use everywhere the saved path.
Jean-Baptiste Kempf [Sun, 21 Jun 2009 01:57:49 +0000 (03:57 +0200)]
Qt: be sure to use everywhere the saved path.

And also fix the support for it on Windows.

8 years agoSimplification.
Rémi Duraffort [Sun, 21 Jun 2009 12:06:48 +0000 (14:06 +0200)]
Simplification.

8 years agoFactorize.
Rémi Duraffort [Sun, 21 Jun 2009 10:28:16 +0000 (12:28 +0200)]
Factorize.

8 years agoFix potential memleak.
Rémi Duraffort [Sun, 21 Jun 2009 10:15:42 +0000 (12:15 +0200)]
Fix potential memleak.

8 years agoDead initialization.
Rémi Duraffort [Fri, 19 Jun 2009 12:01:56 +0000 (14:01 +0200)]
Dead initialization.

8 years agoNew default skin: SubX
Martin Pöhlmann [Fri, 19 Jun 2009 22:25:39 +0000 (23:25 +0100)]
New default skin: SubX

Signed-off-by: Christophe Mutricy <xtophe@videolan.org>
8 years agoI like the stories well enough but I can't get myself to like this as a codename...
JP Dinger [Fri, 19 Jun 2009 19:58:20 +0000 (21:58 +0200)]
I like the stories well enough but I can't get myself to like this as a codename for 1.1. xtophe suggested sin city, so with a bit of imdb assistance, we have...

8 years agohttp interface: strdup memleaks
Derk-Jan Hartman [Fri, 19 Jun 2009 21:36:00 +0000 (23:36 +0200)]
http interface: strdup memleaks

8 years agoQt: store the filedialog path in Qt setings, instead of vlc config (internal option...
Jean-Baptiste Kempf [Thu, 18 Jun 2009 23:05:58 +0000 (01:05 +0200)]
Qt: store the filedialog path in Qt setings, instead of vlc config (internal option, btw)

This simplifies a bit the code, should solve the issue reported over and over by the users.

8 years agoQt: first step to fix directory remembering.
Jean-Baptiste Kempf [Thu, 18 Jun 2009 22:59:02 +0000 (00:59 +0200)]
Qt: first step to fix directory remembering.

8 years agoQt: cosmetics and comments.
Jean-Baptiste Kempf [Thu, 18 Jun 2009 22:25:00 +0000 (00:25 +0200)]
Qt: cosmetics and comments.

8 years agoQt: correct right click selection.
Jean-Baptiste Kempf [Thu, 18 Jun 2009 22:16:55 +0000 (00:16 +0200)]
Qt: correct right click selection.

That way, when you right-click on the not-selected item, you can delete it.

8 years agoChorus filter in NEWS.
Jean-Baptiste Kempf [Wed, 17 Jun 2009 16:29:41 +0000 (18:29 +0200)]
Chorus filter in NEWS.

8 years agoFix compilation (thanks to cppcheck developpers to notice this bug)
Rémi Duraffort [Fri, 19 Jun 2009 10:40:35 +0000 (12:40 +0200)]
Fix compilation (thanks to cppcheck developpers to notice this bug)

8 years agoFix memleak.
Rémi Duraffort [Fri, 19 Jun 2009 09:28:46 +0000 (11:28 +0200)]
Fix memleak.

8 years agoNever print the password in the logs.
Rémi Duraffort [Fri, 19 Jun 2009 09:14:36 +0000 (11:14 +0200)]
Never print the password in the logs.

8 years agoDon't print the password in the logs (even debug ones).
Rémi Duraffort [Fri, 19 Jun 2009 09:07:33 +0000 (11:07 +0200)]
Don't print the password in the logs (even debug ones).

8 years agoRemove dead increment.
Rémi Duraffort [Fri, 19 Jun 2009 08:50:55 +0000 (10:50 +0200)]
Remove dead increment.

8 years agoMissing const.
Rémi Duraffort [Fri, 19 Jun 2009 08:38:17 +0000 (10:38 +0200)]
Missing const.

8 years agoRemove dead initialization.
Rémi Duraffort [Fri, 19 Jun 2009 08:20:11 +0000 (10:20 +0200)]
Remove dead initialization.

8 years agoFix #2720 for master also. Finally that's not an hack as the code is build to
Rémi Duraffort [Mon, 15 Jun 2009 17:51:18 +0000 (19:51 +0200)]
Fix #2720 for master also. Finally that's not an hack as the code is build to
stop the playlist just after removing the playing item (so that's ok to stop
the PL even when it's empty).

(cherry picked from commit be1f4305f1203ccf5acc402fd2cc80dde3f5b1cd)

Signed-off-by: Rémi Duraffort <ivoire@videolan.org>
8 years agoUse vlc_mutex_locker
Rémi Duraffort [Fri, 19 Jun 2009 07:31:38 +0000 (09:31 +0200)]
Use vlc_mutex_locker

8 years agoUse vlc_mutex_locker.
Rémi Duraffort [Fri, 19 Jun 2009 07:06:00 +0000 (09:06 +0200)]
Use vlc_mutex_locker.

8 years agoNo need to test for NULL here.
Rémi Duraffort [Fri, 19 Jun 2009 06:25:39 +0000 (08:25 +0200)]
No need to test for NULL here.

8 years agoNo need to test for p_sys != NULL as it's already tested in the constructor.
Rémi Duraffort [Thu, 18 Jun 2009 18:11:04 +0000 (20:11 +0200)]
No need to test for p_sys != NULL as it's already tested in the constructor.

8 years agoRemove unused includes and factorize.
Rémi Duraffort [Thu, 18 Jun 2009 17:57:52 +0000 (19:57 +0200)]
Remove unused includes and factorize.

8 years agoFixed a typo.
Laurent Aimar [Thu, 18 Jun 2009 23:15:56 +0000 (01:15 +0200)]
Fixed a typo.

8 years agoWorkaround buggy flv files (#2590).
Laurent Aimar [Thu, 18 Jun 2009 23:02:04 +0000 (01:02 +0200)]
Workaround buggy flv files (#2590).

 It seems that (a lot of?) flv files does not correctly set PTS,
so ignore them, with luck the decoder (avcodec) will recreate
them.
 It might break some valid files, so report any regression.

(It needs the AVCodecContext::ticks_per_frame change).

8 years agoDo not warn about unsupported demux/access when aborting.
Laurent Aimar [Thu, 18 Jun 2009 22:52:30 +0000 (00:52 +0200)]
Do not warn about unsupported demux/access when aborting.

8 years agoDo not ask the user if we should build the avi index when the demuxer has been killed.
Laurent Aimar [Thu, 18 Jun 2009 22:51:05 +0000 (00:51 +0200)]
Do not ask the user if we should build the avi index when the demuxer has been killed.

8 years agoUsed AVCodecContext::ticks_per_frame when available.
Laurent Aimar [Thu, 18 Jun 2009 22:47:57 +0000 (00:47 +0200)]
Used AVCodecContext::ticks_per_frame when available.

It fixes a regression with interpolated timestamps for some
mpeg-I/II and for h264.

8 years agoCosmetics.
Laurent Aimar [Thu, 18 Jun 2009 22:44:41 +0000 (00:44 +0200)]
Cosmetics.

8 years agoFix memleak when out of memory.
JP Dinger [Thu, 18 Jun 2009 22:30:33 +0000 (00:30 +0200)]
Fix memleak when out of memory.

8 years agoForce new not to throw. Also drop a separate declaration of a static function that...
JP Dinger [Thu, 18 Jun 2009 21:46:21 +0000 (23:46 +0200)]
Force new not to throw. Also drop a separate declaration of a static function that's called exactly once, and mark it inline instead.

8 years agoReally used a weaker lock for input_ressource_HoldAout.
Laurent Aimar [Thu, 18 Jun 2009 21:47:15 +0000 (23:47 +0200)]
Really used a weaker lock for input_ressource_HoldAout.

8 years agoUsed av_malloc/free for avcodec_decode_audio2 output buffer.
Laurent Aimar [Thu, 18 Jun 2009 21:38:05 +0000 (23:38 +0200)]
Used av_malloc/free for avcodec_decode_audio2 output buffer.

It is needed to ensure valid buffer alignment.

8 years agoUsed a weaker lock scheme for input_resource_HoldAout.
Laurent Aimar [Thu, 18 Jun 2009 20:41:16 +0000 (22:41 +0200)]
Used a weaker lock scheme for input_resource_HoldAout.

8 years agoFixed a potential race condition in input_resource_HoldVout*.
Laurent Aimar [Thu, 18 Jun 2009 20:34:59 +0000 (22:34 +0200)]
Fixed a potential race condition in input_resource_HoldVout*.

8 years agoRenamed lock_vout in lock_hold in resource (No functionnal changes).
Laurent Aimar [Thu, 18 Jun 2009 20:34:09 +0000 (22:34 +0200)]
Renamed lock_vout in lock_hold in resource (No functionnal changes).

8 years agoContribs: Use $STRIP
Christophe Mutricy [Thu, 18 Jun 2009 17:52:39 +0000 (19:52 +0200)]
Contribs: Use $STRIP

And don't ignore errors

8 years agoUpdate THANKS
Rémi Duraffort [Thu, 18 Jun 2009 17:33:34 +0000 (19:33 +0200)]
Update THANKS

8 years agoContribs: Fix libmpcdec configure.ac
Christophe Mutricy [Thu, 18 Jun 2009 17:14:31 +0000 (19:14 +0200)]
Contribs: Fix libmpcdec configure.ac

You need a compiler.

8 years agocontribs: Use autoreconf --force to avoid libtool pb.
Christophe Mutricy [Thu, 18 Jun 2009 17:12:09 +0000 (19:12 +0200)]
contribs: Use autoreconf --force to avoid libtool pb.

Also use autoreconf where possible
And no need to reun automake after autoreconf

8 years agoRefactor spatializer initialisation and teardown to use a table and a loop.
JP Dinger [Thu, 18 Jun 2009 14:37:10 +0000 (16:37 +0200)]
Refactor spatializer initialisation and teardown to use a table and a loop.

8 years agoRevert "No need to create an object to handle the lock is such a simple case."
Rémi Duraffort [Thu, 18 Jun 2009 13:25:13 +0000 (15:25 +0200)]
Revert "No need to create an object to handle the lock is such a simple case."

This reverts commit f001a156e79ba8e9c2c4f2b62330b9e155c1ec33.

This is usually a good practice. Moreover compare to locking and unlocking the
potential overhead is really small.

8 years agocosmetics (no functionnal changes).
Rémi Duraffort [Thu, 18 Jun 2009 13:23:48 +0000 (15:23 +0200)]
cosmetics (no functionnal changes).

8 years agoCosmetic (no functionnal change).
Rémi Duraffort [Thu, 18 Jun 2009 12:57:55 +0000 (14:57 +0200)]
Cosmetic (no functionnal change).