vlc.git
23 months agomacosx: Rename and invert isNotEmbedded
Marvin Scholz [Mon, 7 Aug 2017 19:57:07 +0000 (21:57 +0200)]
macosx: Rename and invert isNotEmbedded

This makes it easier to understand the meaning and read the code.

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>
23 months agomacosx: Rename variables
Marvin Scholz [Mon, 7 Aug 2017 19:57:06 +0000 (21:57 +0200)]
macosx: Rename variables

Rename a bunch of variables to clarify their meaning.

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>
23 months agomacosx: Remove unused variable
Marvin Scholz [Mon, 7 Aug 2017 19:57:05 +0000 (21:57 +0200)]
macosx: Remove unused variable

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>
23 months agoos2: package: enable libass and fribidi
KO Myung-Hun [Tue, 8 Aug 2017 05:08:55 +0000 (14:08 +0900)]
os2: package: enable libass and fribidi

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>
23 months agoNSIS: Add icon to extension context menu (fixes #18648)
Daniel Amm [Mon, 7 Aug 2017 22:20:50 +0000 (00:20 +0200)]
NSIS: Add icon to extension context menu (fixes #18648)

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>
23 months agoaccess: dc1394: fix type mismatch
Zhao Zhili [Tue, 8 Aug 2017 02:12:43 +0000 (10:12 +0800)]
access: dc1394: fix type mismatch

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>
23 months agodvb-text: fix format string
Rémi Denis-Courmont [Mon, 7 Aug 2017 19:02:18 +0000 (22:02 +0300)]
dvb-text: fix format string

23 months agovariables: missing initializer
Rémi Denis-Courmont [Mon, 7 Aug 2017 19:02:02 +0000 (22:02 +0300)]
variables: missing initializer

23 months agoqt: sub-file expects a file path (fixes #18664)
Rémi Denis-Courmont [Mon, 7 Aug 2017 18:46:07 +0000 (21:46 +0300)]
qt: sub-file expects a file path (fixes #18664)

The sub-file wants a file path, not an URI. Set it accordingly.

NOTE: Either way, this won´t work if the path contains a whitespace
because of longstanding bug #1952.

23 months agodxva2_deinterlace: always fill the output picture->context
Steve Lhomme [Mon, 7 Aug 2017 10:46:23 +0000 (12:46 +0200)]
dxva2_deinterlace: always fill the output picture->context

It is necessary for snapshots which create a picture from scratch and then copy
"pixels" using the planes or the context callback.

Signed-off-by: Rémi Denis-Courmont <remi@remlab.net>
23 months agod3d11_deinterlace: always fill the output picture->context
Steve Lhomme [Mon, 7 Aug 2017 10:46:22 +0000 (12:46 +0200)]
d3d11_deinterlace: always fill the output picture->context

It is necessary for snapshots which create a picture from scratch and then copy
"pixels" using the planes or the context callback.

Fixes #18533

Signed-off-by: Rémi Denis-Courmont <remi@remlab.net>
23 months agoaccess/cdda: Do not discard const qualifier
Marvin Scholz [Mon, 7 Aug 2017 16:26:01 +0000 (18:26 +0200)]
access/cdda: Do not discard const qualifier

Signed-off-by: Rémi Denis-Courmont <remi@remlab.net>
23 months agoglwin32: correct vertical alignment
Victorien Le Couviour--Tuffet [Fri, 4 Aug 2017 17:41:12 +0000 (19:41 +0200)]
glwin32: correct vertical alignment

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>
23 months agocaopengllayer: correct vertical alignment
Victorien Le Couviour--Tuffet [Fri, 4 Aug 2017 17:41:11 +0000 (19:41 +0200)]
caopengllayer: correct vertical alignment

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>
23 months agomacosx: macosx-gl-display: correct vertical alignment
Victorien Le Couviour--Tuffet [Fri, 4 Aug 2017 17:41:10 +0000 (19:41 +0200)]
macosx: macosx-gl-display: correct vertical alignment

The GL textures are Y inverted, so we must reverse the vertical alignment.

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>
23 months agoopengl: correct vertical alignment
Victorien Le Couviour--Tuffet [Fri, 4 Aug 2017 17:41:09 +0000 (19:41 +0200)]
opengl: correct vertical alignment

The GL textures are Y inverted, so we must reverse the vertical alignment.

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>
23 months agovlc_vout_display: fix comment after renaming and inverting logic
Steve Lhomme [Mon, 7 Aug 2017 13:01:47 +0000 (15:01 +0200)]
vlc_vout_display: fix comment after renaming and inverting logic

In 40c96414f343d2fd939cf3053d9dc80930891c7e

Signed-off-by: Hugo Beauzée-Luyssen <hugo@beauzee.fr>
23 months agovlc_vout_display: use VLC_DEPRECATED_ENUM for enumerators
Steve Lhomme [Mon, 7 Aug 2017 11:22:32 +0000 (13:22 +0200)]
vlc_vout_display: use VLC_DEPRECATED_ENUM for enumerators

It's not available on all GCCs

Fix regression from
057e5729c51c693e255c9348046c103b75bdb19c,
40c96414f343d2fd939cf3053d9dc80930891c7e,
c900e39cf935b77f0f47383eb95936297c650651

Signed-off-by: Hugo Beauzée-Luyssen <hugo@beauzee.fr>
23 months agovlc_common: GCC enumerator attributes are only available since gcc 6
Steve Lhomme [Mon, 7 Aug 2017 11:22:31 +0000 (13:22 +0200)]
vlc_common: GCC enumerator attributes are only available since gcc 6

Signed-off-by: Hugo Beauzée-Luyssen <hugo@beauzee.fr>
23 months agoqt: win32 intf: Fix task bar icon display
Hugo Beauzée-Luyssen [Mon, 7 Aug 2017 11:31:37 +0000 (13:31 +0200)]
qt: win32 intf: Fix task bar icon display

refs #18650

23 months agovout:ios: Do not use passed video_format_t for CROP/ASPECT_RATIO changes
Steve Lhomme [Mon, 7 Aug 2017 10:58:01 +0000 (12:58 +0200)]
vout:ios: Do not use passed video_format_t for CROP/ASPECT_RATIO changes

Signed-off-by: Marvin Scholz <epirat07@gmail.com>
23 months agovout/caopengllayer: Do not use passed video_format_t for CROP/ASPECT_RATIO changes
Marvin Scholz [Mon, 7 Aug 2017 10:14:19 +0000 (12:14 +0200)]
vout/caopengllayer: Do not use passed video_format_t for CROP/ASPECT_RATIO changes

Since d9e1ff011ef0ebd262219df8e9ba3948afb7825f this is no longer passed,
vd->source is used instead.

23 months agovout/macosx: Do not use passed video_format_t for CROP/ASPECT_RATIO changes
Marvin Scholz [Mon, 7 Aug 2017 10:08:47 +0000 (12:08 +0200)]
vout/macosx: Do not use passed video_format_t for CROP/ASPECT_RATIO changes

Since d9e1ff011ef0ebd262219df8e9ba3948afb7825f this is no longer passed,
vd->source is used instead.

23 months agomacosx: Fix incorrectly saved XIB
Marvin Scholz [Mon, 7 Aug 2017 08:15:13 +0000 (10:15 +0200)]
macosx: Fix incorrectly saved XIB

23 months agovideo_output:win32: remove the video_format_t parameter
Steve Lhomme [Mon, 7 Aug 2017 07:02:38 +0000 (09:02 +0200)]
video_output:win32: remove the video_format_t parameter

It's always vd->source.

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>
23 months agodemux:mkv: don't overwrite a seekpoint using a lower trusted level
Steve Lhomme [Fri, 4 Aug 2017 12:29:03 +0000 (14:29 +0200)]
demux:mkv: don't overwrite a seekpoint using a lower trusted level

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>
23 months agodemux:mkv: don't invalid the cues just because we don't use the extra information
Steve Lhomme [Fri, 4 Aug 2017 12:29:02 +0000 (14:29 +0200)]
demux:mkv: don't invalid the cues just because we don't use the extra information

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>
23 months agovout: rename and invert has_hide_mouse
Rémi Denis-Courmont [Sun, 6 Aug 2017 07:48:50 +0000 (10:48 +0300)]
vout: rename and invert has_hide_mouse

The name was meant to indicate that the plugin hid the pointer
autonomously. But it was ostensibly confused as implying that the
plugin had a mouse hiding control (basically the exact opposite).
In fact, it really meant that the mouse hiding control would NOT be
used.

This tries to provide a slightly less confusing name, and accordingly
inverts the meaning. This is also realigns with the convention that
false should be the default setting (which was broken in the grand
grand parent of this changeset).

23 months agoios vout: fix incorrect hide mouse setting
Rémi Denis-Courmont [Sun, 6 Aug 2017 07:59:10 +0000 (10:59 +0300)]
ios vout: fix incorrect hide mouse setting

This vout never had mouse hiding, AFAICT.

23 months agovout: remove dummy dead VOUT_DISPLAY_HIDE_MOUSE controls
Rémi Denis-Courmont [Sun, 6 Aug 2017 07:38:37 +0000 (10:38 +0300)]
vout: remove dummy dead VOUT_DISPLAY_HIDE_MOUSE controls

Depending on the value of info.has_hide_mouse, the control is never
called. No point in providing a dummy implementation then.

23 months agovout: make has_hide_mouse true by default
Rémi Denis-Courmont [Sun, 6 Aug 2017 07:37:34 +0000 (10:37 +0300)]
vout: make has_hide_mouse true by default

Most video output displays either defer mouse hiding to the window
provider plugin, or do not handle the mouse events at all.
So that ought to be the default.

Also kepe the default in those display plugins that don´t handle
cursor hiding (notably X11 ones).

23 months agodisplay: always compute mouse hide timeout
Rémi Denis-Courmont [Sun, 6 Aug 2017 19:59:25 +0000 (22:59 +0300)]
display: always compute mouse hide timeout

Cursor management should eventually be moved from display to the window.
(The video output core still needs to take care of the window to video
translation, and the mouse event filtering, as it already does.)
And cursor hiding should be left entirely within the window plugins.

But in the mean time, compute the correct timestamps regardless of the
cursor hiding support in display plugin, so that it also works if the
cursor is hidden by the window plugin.

23 months agolua: fix dailymotion parsing
Nicolas Chauvet [Sun, 6 Aug 2017 10:59:15 +0000 (12:59 +0200)]
lua: fix dailymotion parsing

Current dailymotion html uses "var __PLAYER_CONFIG__" instead of
"var config" to store data such as username, qualities and etc.
Others fields are unchanged.

Signed-off-by: Nicolas Chauvet <kwizart@gmail.com>
Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>
23 months agofourcc: fix non zero terminated fallback array
Victorien Le Couviour--Tuffet [Fri, 4 Aug 2017 17:41:01 +0000 (19:41 +0200)]
fourcc: fix non zero terminated fallback array

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>
23 months agosplitter: wall: fix incorrect unecessary output condition
Victorien Le Couviour--Tuffet [Fri, 4 Aug 2017 17:40:59 +0000 (19:40 +0200)]
splitter: wall: fix incorrect unecessary output condition

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>
23 months agosplitter: wall: fix incorrect sizes
Victorien Le Couviour--Tuffet [Fri, 4 Aug 2017 17:40:58 +0000 (19:40 +0200)]
splitter: wall: fix incorrect sizes

The computations must not be done on the buffer size but on the video one.
Otherwise, we might end up with the sum of all output sizes bigger than the
video itself, which results in a green strip at the bottom of the lowest
outputs, and potentially incorrect display for all of them (with bad width).

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>
23 months agodemux: adaptive: fix warning of reorder
Zhao Zhili [Fri, 4 Aug 2017 17:25:49 +0000 (01:25 +0800)]
demux: adaptive: fix warning of reorder

Signed-off-by: Rémi Denis-Courmont <remi@remlab.net>
23 months agolua: fix dist
Rémi Denis-Courmont [Sun, 6 Aug 2017 19:41:15 +0000 (22:41 +0300)]
lua: fix dist

23 months agoextras/macosx: Disable sdl-image in configure.sh
Marvin Scholz [Sun, 6 Aug 2017 19:29:17 +0000 (21:29 +0200)]
extras/macosx: Disable sdl-image in configure.sh

Previously SDL and SDL Image was disabled with the --disable-sdl flag,
with that flag gone, SDL Image needs to be disabled explicitly instead.

23 months agowindow: deinhibit the screensaver on pause (fixes #3724)
Rémi Denis-Courmont [Sun, 6 Aug 2017 15:47:16 +0000 (18:47 +0300)]
window: deinhibit the screensaver on pause (fixes #3724)

23 months agowindow: report all double clicks
Rémi Denis-Courmont [Sun, 6 Aug 2017 13:53:16 +0000 (16:53 +0300)]
window: report all double clicks

Because we can.

23 months agowindow: improve doxygen
Rémi Denis-Courmont [Sun, 6 Aug 2017 13:44:22 +0000 (16:44 +0300)]
window: improve doxygen

23 months agowindow: add info struct and double click flag
Rémi Denis-Courmont [Sun, 6 Aug 2017 13:26:55 +0000 (16:26 +0300)]
window: add info struct and double click flag

Like display plugins before, window plugins need to be handled
differently if they emit double click events than not.

23 months agovout: remove unused mouse visible/invisible event
Rémi Denis-Courmont [Sun, 6 Aug 2017 14:54:36 +0000 (17:54 +0300)]
vout: remove unused mouse visible/invisible event

The window/display already have events/controls for this, and nothing
else cared, cares and probably will ever care.

23 months agovout: remove core event thread
Rémi Denis-Courmont [Sat, 5 Aug 2017 20:49:13 +0000 (23:49 +0300)]
vout: remove core event thread

23 months agocaca: use new event thread helper
Rémi Denis-Courmont [Sat, 5 Aug 2017 20:48:14 +0000 (23:48 +0300)]
caca: use new event thread helper

23 months agoaa: use new event thread helper
Rémi Denis-Courmont [Sat, 5 Aug 2017 20:48:14 +0000 (23:48 +0300)]
aa: use new event thread helper

23 months agovout: add legacy event thread helper outside core
Rémi Denis-Courmont [Sat, 5 Aug 2017 20:47:32 +0000 (23:47 +0300)]
vout: add legacy event thread helper outside core

23 months agovout display: deprecate the "manage" callback (refs #17700)
Rémi Denis-Courmont [Sat, 5 Aug 2017 20:13:43 +0000 (23:13 +0300)]
vout display: deprecate the "manage" callback (refs #17700)

23 months agovout_display: remove/deprecate fullscreen state
Rémi Denis-Courmont [Sat, 5 Aug 2017 20:04:57 +0000 (23:04 +0300)]
vout_display: remove/deprecate fullscreen state

Live window state, this was moved from display to window eight years
ago (minus one week). When the fullscreen state changes, the window
plugin emits a resize event, which triggers any necessary updates in
the display. The display does not need to know about fullscreen state
as such. But it is retained on HWND platforms due to legacy code, just
like window state before.

23 months agosdl: remove video output
Rémi Denis-Courmont [Sat, 5 Aug 2017 18:08:45 +0000 (21:08 +0300)]
sdl: remove video output

The SDL video output has been forcefully disabled on MacOS X for 12
years. It has also been disabled in Windows builds for over 6 years.
Finally, it has been broken on X11 due to lack of windowing
integration, for several years, cannot be fixed without changes to
the SDL API, and is completely useless.

23 months agodirectfb: remove legacy video output
Rémi Denis-Courmont [Sat, 5 Aug 2017 18:00:06 +0000 (21:00 +0300)]
directfb: remove legacy video output

The DirectFB project has been dead for several years, and is ostensibly
not used. If you really need direct access to the Linux frame buffer,
there is still the raw LinuxFB module for the time being.

23 months agovout_display: mark CHANGE_WINDOW_STATE deprecated
Rémi Denis-Courmont [Sat, 5 Aug 2017 20:03:23 +0000 (23:03 +0300)]
vout_display: mark CHANGE_WINDOW_STATE deprecated

This was moved from display to window eight years ago.

23 months agodisplay: preserve actual height on A/R or crop change
Rémi Denis-Courmont [Sat, 5 Aug 2017 19:16:49 +0000 (22:16 +0300)]
display: preserve actual height on A/R or crop change

...rather than the last saved height. In practice, this does not make
much if any difference though, as:
- the saved height should equal the actual height in windowed mode,
- the code path has no effects in fullscreen mode.

23 months agommal vout: pictures reset is impossible
Rémi Denis-Courmont [Sat, 5 Aug 2017 18:23:01 +0000 (21:23 +0300)]
mmal vout: pictures reset is impossible

Assert that it does not happen, like with all or almost all other
non-resetting video outputs.

23 months agoold http: remove useless b_continuous member
Zhao Zhili [Fri, 4 Aug 2017 02:46:19 +0000 (10:46 +0800)]
old http: remove useless b_continuous member

Signed-off-by: Rémi Denis-Courmont <remi@remlab.net>
23 months agodisplay: no need to pass the video_format_t for CROP/ASPECT_RATIO changes
Steve Lhomme [Wed, 2 Aug 2017 07:33:37 +0000 (09:33 +0200)]
display: no need to pass the video_format_t for CROP/ASPECT_RATIO changes

It's always found in vd->source.

Signed-off-by: Rémi Denis-Courmont <remi@remlab.net>
23 months agodisplay: no need for a local video_format_t with VOUT_DISPLAY_CHANGE_SOURCE_CROP
Steve Lhomme [Wed, 2 Aug 2017 07:33:36 +0000 (09:33 +0200)]
display: no need for a local video_format_t with VOUT_DISPLAY_CHANGE_SOURCE_CROP

Receivers don't check the difference with the original value, they just apply
the new value.

Signed-off-by: Rémi Denis-Courmont <remi@remlab.net>
23 months agodisplay: no need for a local video_format_t with VOUT_DISPLAY_CHANGE_SOURCE_ASPECT
Steve Lhomme [Wed, 2 Aug 2017 07:33:35 +0000 (09:33 +0200)]
display: no need for a local video_format_t with VOUT_DISPLAY_CHANGE_SOURCE_ASPECT

Receivers don't check the difference with the original value, they just apply
the new value.

Signed-off-by: Rémi Denis-Courmont <remi@remlab.net>
23 months agoshare: Install precompiled lua scripts in /share instead of /lib
Hugo Beauzée-Luyssen [Thu, 3 Aug 2017 14:31:09 +0000 (16:31 +0200)]
share: Install precompiled lua scripts in /share instead of /lib

Fix #18639

23 months agolib: Automatically select the default teletext page on activation
Hugo Beauzée-Luyssen [Fri, 4 Aug 2017 13:05:02 +0000 (15:05 +0200)]
lib: Automatically select the default teletext page on activation

Fix #18638

23 months agodeinterlace:dxva: fix a bogus string test
Steve Lhomme [Fri, 4 Aug 2017 09:30:56 +0000 (11:30 +0200)]
deinterlace:dxva: fix a bogus string test

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>
23 months agodemux:mkv: do not look for seekpoints for tracks that are not selected
Steve Lhomme [Fri, 4 Aug 2017 09:31:44 +0000 (11:31 +0200)]
demux:mkv: do not look for seekpoints for tracks that are not selected

That will reduce the potential scope of the data we will read before seeking.

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>
23 months agodemux:mkv: do not use invalid seekpoints for the final seek target
Steve Lhomme [Fri, 4 Aug 2017 09:31:43 +0000 (11:31 +0200)]
demux:mkv: do not use invalid seekpoints for the final seek target

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>
23 months agodxva2_deinterlace: use a function to fill the DXVA2_VideoProcessBltParams
Steve Lhomme [Tue, 1 Aug 2017 08:25:45 +0000 (10:25 +0200)]
dxva2_deinterlace: use a function to fill the DXVA2_VideoProcessBltParams

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>
23 months agodxva2_deinterlace: replace an assert by a debug warning
Steve Lhomme [Tue, 1 Aug 2017 08:25:44 +0000 (10:25 +0200)]
dxva2_deinterlace: replace an assert by a debug warning

Might fix #18599

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>
23 months agod3d11va: fix Xbox limitation test
Steve Lhomme [Fri, 28 Jul 2017 11:37:33 +0000 (13:37 +0200)]
d3d11va: fix Xbox limitation test

The va_pool surface dimensions are only set if the surfaces are created
successfully. We must use the temporary video_format_t dimensions at this stage.

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>
23 months agodxva2_deinterlace: fix potential double free when there are errors
Steve Lhomme [Tue, 1 Aug 2017 08:25:43 +0000 (10:25 +0200)]
dxva2_deinterlace: fix potential double free when there are errors

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>
23 months agodxva2_deinterlace: fix wrong copy/paste in log
Steve Lhomme [Tue, 1 Aug 2017 08:25:42 +0000 (10:25 +0200)]
dxva2_deinterlace: fix wrong copy/paste in log

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>
23 months agodeinterlace:dxva: log when the algorithm doesn't match the user choice exactly
Steve Lhomme [Wed, 2 Aug 2017 06:31:56 +0000 (08:31 +0200)]
deinterlace:dxva: log when the algorithm doesn't match the user choice exactly

Since available ones may vary from hardware to hardware.

23 months agodirect3d11: always place the picture based on the quad source dimensions
Steve Lhomme [Tue, 1 Aug 2017 13:30:03 +0000 (15:30 +0200)]
direct3d11: always place the picture based on the quad source dimensions

They may not always be equal to the vd->fmt.

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>
23 months agodirect3d11: decide the main quad dimensions early
Steve Lhomme [Tue, 1 Aug 2017 13:01:22 +0000 (15:01 +0200)]
direct3d11: decide the main quad dimensions early

We decide once in Direct3D11Open() and keep using that.
The staging texture has the same dimensions.

Might fix #18578

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>
23 months agodirect3d11: fix possibly failing CopySubresourceRegion on odd dimensions
Steve Lhomme [Tue, 1 Aug 2017 13:01:21 +0000 (15:01 +0200)]
direct3d11: fix possibly failing CopySubresourceRegion on odd dimensions

The texture is created with extra size so we can use more for the copy.

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>
23 months agodirect3d11: remove write-only i_x/y_offset in d3d_quad_t
Steve Lhomme [Tue, 1 Aug 2017 13:01:20 +0000 (15:01 +0200)]
direct3d11: remove write-only i_x/y_offset in d3d_quad_t

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>
23 months agodemux: hls: code cleaning
Zhao Zhili [Wed, 2 Aug 2017 12:59:09 +0000 (20:59 +0800)]
demux: hls: code cleaning

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>
23 months agodemux:mkv: simplify the default Seekpoint constructor
Steve Lhomme [Thu, 3 Aug 2017 16:18:35 +0000 (18:18 +0200)]
demux:mkv: simplify the default Seekpoint constructor

Use the full constructor.

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>
23 months agodemux:mkv: make the default trust level of a Seekpoint to TRUSTED
Steve Lhomme [Thu, 3 Aug 2017 16:18:34 +0000 (18:18 +0200)]
demux:mkv: make the default trust level of a Seekpoint to TRUSTED

For a needle it doesn't matter the level, it's never used.

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>
23 months agodemux:mkv: pass a Seekpoint to add_seekpoint
Steve Lhomme [Thu, 3 Aug 2017 16:18:33 +0000 (18:18 +0200)]
demux:mkv: pass a Seekpoint to add_seekpoint

No need to pass all parameters, especially if the Seekpoint prototype grows.

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>
23 months agodemux:mkv: remove the unused duration field from Seekpoint
Steve Lhomme [Thu, 3 Aug 2017 16:18:32 +0000 (18:18 +0200)]
demux:mkv: remove the unused duration field from Seekpoint

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>
23 months agodemux:mkv: simplify the code as we always disable the trust check with get_seekpoints...
Steve Lhomme [Thu, 3 Aug 2017 16:18:31 +0000 (18:18 +0200)]
demux:mkv: simplify the code as we always disable the trust check with get_seekpoints_around()

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>
23 months agodemux:mkv: don't look for the upper seekpoint when we only want the lower one
Steve Lhomme [Thu, 3 Aug 2017 16:18:30 +0000 (18:18 +0200)]
demux:mkv: don't look for the upper seekpoint when we only want the lower one

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>
23 months agodemux:mkv: remove useless initialization
Steve Lhomme [Thu, 3 Aug 2017 16:18:29 +0000 (18:18 +0200)]
demux:mkv: remove useless initialization

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>
23 months agodemux:mkv: init an invalid Seekpoint with a proper invalid seek position
Steve Lhomme [Thu, 3 Aug 2017 16:18:28 +0000 (18:18 +0200)]
demux:mkv: init an invalid Seekpoint with a proper invalid seek position

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>
23 months agodemux:mkv: use the TrustLevel type when looking for seekpoint boundaries
Steve Lhomme [Thu, 3 Aug 2017 16:18:27 +0000 (18:18 +0200)]
demux:mkv: use the TrustLevel type when looking for seekpoint boundaries

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>
23 months agodemux:mkv: clean the type and default value of the seek position
Steve Lhomme [Thu, 3 Aug 2017 16:18:26 +0000 (18:18 +0200)]
demux:mkv: clean the type and default value of the seek position

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>
23 months agohttp: Ensure mobile buttons are on one line
Mathieu Parent [Thu, 3 Aug 2017 16:27:04 +0000 (18:27 +0200)]
http: Ensure mobile buttons are on one line

Tested with 320x480 or wider.

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>
23 months agohttp: Allow to select media from playlist too
Mathieu Parent [Thu, 3 Aug 2017 16:27:03 +0000 (18:27 +0200)]
http: Allow to select media from playlist too

Signed-off-by: Mathieu Parent <math.parent@gmail.com>
Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>
23 months agohttp: Handle unparsable item name in /requests/playlist_jstree.xml
Mathieu Parent [Thu, 3 Aug 2017 16:27:02 +0000 (18:27 +0200)]
http: Handle unparsable item name in /requests/playlist_jstree.xml

Signed-off-by: Mathieu Parent <math.parent@gmail.com>
Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>
23 months agoconfigure: Explain how to disable avcodec or alsa
Mathieu Parent [Thu, 3 Aug 2017 16:27:01 +0000 (18:27 +0200)]
configure: Explain how to disable avcodec or alsa

Signed-off-by: Mathieu Parent <math.parent@gmail.com>
Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>
23 months agokwallet: Fix leak on error
Hugo Beauzée-Luyssen [Thu, 3 Aug 2017 13:55:40 +0000 (15:55 +0200)]
kwallet: Fix leak on error

CID #1372939

23 months agoupnp: Fix leak on error
Hugo Beauzée-Luyssen [Thu, 3 Aug 2017 13:52:26 +0000 (15:52 +0200)]
upnp: Fix leak on error

CID #1398416

23 months agolibavi: Fix expension unsafe helper
Hugo Beauzée-Luyssen [Thu, 3 Aug 2017 13:24:46 +0000 (15:24 +0200)]
libavi: Fix expension unsafe helper

23 months agogl: vaapi: use wayland CFLAGS
Olaf Hering [Mon, 31 Jul 2017 07:38:26 +0000 (09:38 +0200)]
gl: vaapi: use wayland CFLAGS

Use the CFLAGS from wayland-client.pc because the header files are not
in the standard directories. In openSUSE they are found in
/usr/include/wayland. Fixes commit 14ba7d2d7e ("gl: vaapi: add DRM
support")

Signed-off-by: Olaf Hering <olaf@aepfle.de>
Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>
23 months agosplitter: wall: fix aspect ratio
Victorien Le Couviour--Tuffet [Wed, 2 Aug 2017 14:37:13 +0000 (16:37 +0200)]
splitter: wall: fix aspect ratio

Signed-off-by: Rémi Denis-Courmont <remi@remlab.net>
23 months agomacosx: remove spaces from blank line
Victorien Le Couviour--Tuffet [Wed, 2 Aug 2017 14:37:11 +0000 (16:37 +0200)]
macosx: remove spaces from blank line

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>
23 months agodemux:mkv: get the track directly from FindTrackByBlock
Steve Lhomme [Wed, 2 Aug 2017 15:07:26 +0000 (17:07 +0200)]
demux:mkv: get the track directly from FindTrackByBlock

And use const is places where the track is not modified.

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>
23 months agodemux:mkv: don't rely on the iterator to get the track number
Steve Lhomme [Wed, 2 Aug 2017 15:07:25 +0000 (17:07 +0200)]
demux:mkv: don't rely on the iterator to get the track number

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>
23 months agodemux:mkv: use an enum for the seekpoint trust level
Steve Lhomme [Wed, 2 Aug 2017 13:56:05 +0000 (15:56 +0200)]
demux:mkv: use an enum for the seekpoint trust level

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>
23 months agodemux:mkv: do not try to use a seekpoint for a track that doesn't exist
Steve Lhomme [Wed, 2 Aug 2017 13:56:04 +0000 (15:56 +0200)]
demux:mkv: do not try to use a seekpoint for a track that doesn't exist

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>
23 months agodemux:mkv: don't add seekpoints for tracks that don't exist
Steve Lhomme [Wed, 2 Aug 2017 15:06:57 +0000 (17:06 +0200)]
demux:mkv: don't add seekpoints for tracks that don't exist

Fixes #18596

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>