vlc.git
6 years agoXCB/window: fix potential use-after-free
Rémi Denis-Courmont [Sun, 16 Mar 2014 09:54:23 +0000 (11:54 +0200)]
XCB/window: fix potential use-after-free

6 years agoQt: remove buffering info from TimeLabel
Francois Cartegnie [Sun, 16 Mar 2014 01:24:42 +0000 (02:24 +0100)]
Qt: remove buffering info from TimeLabel

6 years agoQt: SeekStyle: fix boundaries truncated handle glitch
Francois Cartegnie [Sun, 16 Mar 2014 01:12:57 +0000 (02:12 +0100)]
Qt: SeekStyle: fix boundaries truncated handle glitch

6 years agovideo_format_TransformBy: fix and preserve video offsets
Rémi Denis-Courmont [Sat, 15 Mar 2014 12:38:53 +0000 (14:38 +0200)]
video_format_TransformBy: fix and preserve video offsets

In general, the picture buffer contains, in memory order:
- cropped top scan lines,
- visible scan lines,
- cropped bottom scan lines,
- extra codec lines,
- padding lines.

This order needs to be preserved when flipping vertically or rotating
180 degrees, since filters and displays rely on this. In particular,
the picture plane structure so far has no provisions for non-zero
offsets, so filters expect visible pixels at the top left of each
pixels plane. Effectively, non-zero offsets only work for cropping
after filtering. Lets assume that the number of cropped lines are
identical at the top and bottom, and keep the X and Y offsets as are.

This fixes green lines at the bottom on R180 and VFLIP.

If support for non-centered cropping is ever required, I believe
offsets will need to be added to plane_t. This would break many video
filters though.

6 years agoes_format: reorder two functions
Rémi Denis-Courmont [Sat, 15 Mar 2014 12:29:40 +0000 (14:29 +0200)]
es_format: reorder two functions

6 years agoXCB/XVideo: fix crop (fixes #10973)
Rémi Denis-Courmont [Sat, 15 Mar 2014 10:49:57 +0000 (12:49 +0200)]
XCB/XVideo: fix crop (fixes #10973)

6 years agodemux: mkv: fix unnamed segments names
Francois Cartegnie [Fri, 14 Mar 2014 22:26:28 +0000 (23:26 +0100)]
demux: mkv: fix unnamed segments names

6 years agodemux: mkv: fix single track opus playback
Francois Cartegnie [Fri, 14 Mar 2014 21:56:38 +0000 (22:56 +0100)]
demux: mkv: fix single track opus playback

Only first frame in a block has timestamp, then (0) last_dts is never valid,
(1) PCR never sent, (2) track never selected by core, goto 1;

6 years agodemux: mkv: fix seek segfault with invalid chapters
Francois Cartegnie [Fri, 14 Mar 2014 18:34:19 +0000 (19:34 +0100)]
demux: mkv: fix seek segfault with invalid chapters

6 years agowasapi: fix inverted logic
Rémi Denis-Courmont [Fri, 14 Mar 2014 16:56:02 +0000 (18:56 +0200)]
wasapi: fix inverted logic

6 years agoDirectFB: reorient video
Rémi Denis-Courmont [Fri, 14 Mar 2014 16:34:41 +0000 (18:34 +0200)]
DirectFB: reorient video

6 years agoLinux FB: reorient video
Rémi Denis-Courmont [Fri, 14 Mar 2014 16:37:52 +0000 (18:37 +0200)]
Linux FB: reorient video

6 years agoyuv: reorient video
Rémi Denis-Courmont [Fri, 14 Mar 2014 16:37:06 +0000 (18:37 +0200)]
yuv: reorient video

6 years agovmem: reorient video
Rémi Denis-Courmont [Fri, 14 Mar 2014 16:38:25 +0000 (18:38 +0200)]
vmem: reorient video

So far, the callbacks have no way to access and use the orientation, so
better fix it.

6 years agoes_format: fix warnings and simplify
Rémi Denis-Courmont [Fri, 14 Mar 2014 16:23:06 +0000 (18:23 +0200)]
es_format: fix warnings and simplify

6 years agoReverse parameters order of video_format_ApplyRotation()
Rémi Denis-Courmont [Fri, 14 Mar 2014 16:14:27 +0000 (18:14 +0200)]
Reverse parameters order of video_format_ApplyRotation()

6 years agoMake sdl vout module handle rotated movies.
Matthias Keiser [Fri, 14 Mar 2014 00:00:10 +0000 (01:00 +0100)]
Make sdl vout module handle rotated movies.

Signed-off-by: Rémi Denis-Courmont <remi@remlab.net>
6 years agotrivial: fix upmixing case and handle dualmono
Ilkka Ollakka [Thu, 13 Mar 2014 09:49:44 +0000 (11:49 +0200)]
trivial: fix upmixing case and handle dualmono

Earlier commit for dualmono (from 2003) seemed to miss some cases
and reordering the if cases as I assume dualmono isn't most common
case in filter.

Ref #7261

6 years agotranscode: cleanup channel setup and allow upmixing
Ilkka Ollakka [Tue, 11 Mar 2014 11:35:45 +0000 (13:35 +0200)]
transcode: cleanup channel setup and allow upmixing

Allow channel upmixing as we have channel mixer that is able to do it.

Fixes #7261

6 years agocaopengllayer: fail if no gl context exists
David Fuhrmann [Fri, 14 Mar 2014 10:26:01 +0000 (11:26 +0100)]
caopengllayer: fail if no gl context exists

6 years agodemux: ogg: map language to fmt desc
Francois Cartegnie [Fri, 14 Mar 2014 01:27:26 +0000 (02:27 +0100)]
demux: ogg: map language to fmt desc

refs #4175

6 years agodemux: xiph comments: allow setting fmt descs
Francois Cartegnie [Fri, 14 Mar 2014 01:26:33 +0000 (02:26 +0100)]
demux: xiph comments: allow setting fmt descs

6 years agodemux: mkv: enforce valid frame rate
Francois Cartegnie [Thu, 13 Mar 2014 22:58:56 +0000 (23:58 +0100)]
demux: mkv: enforce valid frame rate

6 years agodemux: mkv: ensure timescale is always valid
Francois Cartegnie [Thu, 13 Mar 2014 22:47:27 +0000 (23:47 +0100)]
demux: mkv: ensure timescale is always valid

6 years agodemux: mkv: fix opus block truncation (fix #10176)
Francois Cartegnie [Thu, 13 Mar 2014 22:40:37 +0000 (23:40 +0100)]
demux: mkv: fix opus block truncation (fix #10176)

6 years agomacosx: fix main window positioning on startup (close #9818)
David Fuhrmann [Thu, 13 Mar 2014 21:41:21 +0000 (22:41 +0100)]
macosx: fix main window positioning on startup (close #9818)

6 years agoXCB/XVideo: reorient video
Rémi Denis-Courmont [Thu, 13 Mar 2014 20:26:25 +0000 (22:26 +0200)]
XCB/XVideo: reorient video

6 years agoXCB/X11: reorient video
Matthias Keiser [Thu, 6 Mar 2014 00:12:32 +0000 (01:12 +0100)]
XCB/X11: reorient video

(Note that the pointer position is not reoriented, this comes with a
later patch in the series for all XCB video outputs.)

Modified-and-...
Signed-off-by: Rémi Denis-Courmont <remi@remlab.net>
6 years agovideo output: support rotated movies
Matthias Keiser [Thu, 6 Mar 2014 00:12:25 +0000 (01:12 +0100)]
video output: support rotated movies

Signed-off-by: Rémi Denis-Courmont <remi@remlab.net>
6 years agovideo output: fix offsets and visible dimensions of filtered video
Rémi Denis-Courmont [Thu, 13 Mar 2014 19:03:57 +0000 (21:03 +0200)]
video output: fix offsets and visible dimensions of filtered video

This parameter copy was working around broken format-changing video
filters, but it broke filters updating the format correctly
(deinterlace, transform and croppadd).

Refs #10745. Note that transform is still not working correctly: the
aspect ratio is broken for transpositation and quarter rotations. This
latent bug should vanish with the video orientation support later.
Otherwise the proper fix is to allow the filters chain to change the
format.

6 years agomacosx: robustify playlist table columns initialization
David Fuhrmann [Thu, 13 Mar 2014 18:06:58 +0000 (19:06 +0100)]
macosx: robustify playlist table columns initialization

Unknown columns might occur if the prefs are written
by a newer VLC version.

close #10664

6 years agomediacodec: use a circular buffer of timestamps as a workaround for DTS only samples
Felix Abecassis [Wed, 12 Mar 2014 22:29:22 +0000 (23:29 +0100)]
mediacodec: use a circular buffer of timestamps as a workaround for DTS only samples

6 years agomediacodec: cosmetics
Felix Abecassis [Thu, 13 Mar 2014 17:59:03 +0000 (18:59 +0100)]
mediacodec: cosmetics

6 years agovideo output: support rotated movies (SPU)
Matthias Keiser [Thu, 13 Mar 2014 13:49:02 +0000 (14:49 +0100)]
video output: support rotated movies (SPU)

Signed-off-by: Rémi Denis-Courmont <remi@remlab.net>
6 years agocontrib/bootstrap: don't assume cc is GCC
Sean McGovern [Thu, 13 Mar 2014 17:50:25 +0000 (13:50 -0400)]
contrib/bootstrap: don't assume cc is GCC

Signed-off-by: Rémi Denis-Courmont <remi@remlab.net>
6 years agoextras/ios: enable vorbis since it is needed by the ogg demuxer
Felix Paul Kühne [Thu, 13 Mar 2014 12:38:29 +0000 (13:38 +0100)]
extras/ios: enable vorbis since it is needed by the ogg demuxer

6 years agowasapi: fix overflow after a few hours
Rémi Denis-Courmont [Wed, 12 Mar 2014 20:44:30 +0000 (22:44 +0200)]
wasapi: fix overflow after a few hours

6 years agowasapi: write timings to debug log
Rémi Denis-Courmont [Wed, 12 Mar 2014 20:43:38 +0000 (22:43 +0200)]
wasapi: write timings to debug log

6 years agowasapi: sleep for half a period as hinted in MSDN
Rémi Denis-Courmont [Wed, 12 Mar 2014 20:05:16 +0000 (22:05 +0200)]
wasapi: sleep for half a period as hinted in MSDN

6 years agodemux: mkv: fix leak
Francois Cartegnie [Wed, 12 Mar 2014 18:50:13 +0000 (19:50 +0100)]
demux: mkv: fix leak

cid 1048915

6 years agodemux: mp4: fix memleak
Francois Cartegnie [Wed, 12 Mar 2014 18:23:41 +0000 (19:23 +0100)]
demux: mp4: fix memleak

cid 1048916

6 years agoRemove remnant
Felix Paul Kühne [Wed, 12 Mar 2014 18:37:53 +0000 (19:37 +0100)]
Remove remnant

6 years agochain: handle movie rotations
Matthias Keiser [Thu, 6 Mar 2014 00:12:29 +0000 (01:12 +0100)]
chain: handle movie rotations

Signed-off-by: Rémi Denis-Courmont <remi@remlab.net>
6 years agoRemove the CoreGraphics video output modules since it was only a skeleton for the...
Felix Paul Kühne [Wed, 12 Mar 2014 18:27:11 +0000 (19:27 +0100)]
Remove the CoreGraphics video output modules since it was only a skeleton for the CoreAnimation Layer module, so it's not needed anymore

6 years agoWin32: the dimensions of the unclipped source rectangle should be the original format...
Felix Abecassis [Wed, 12 Mar 2014 15:48:17 +0000 (16:48 +0100)]
Win32: the dimensions of the unclipped source rectangle should be the original format of the video

Fix #10886

6 years agotransform: make filter work with chain where format change permitted
Matthias Keiser [Thu, 6 Mar 2014 22:08:53 +0000 (23:08 +0100)]
transform: make filter work with chain where format change permitted

Signed-off-by: Rémi Denis-Courmont <remi@remlab.net>
6 years agoaccess: cdda: fix resource leak
Francois Cartegnie [Wed, 12 Mar 2014 17:41:35 +0000 (18:41 +0100)]
access: cdda: fix resource leak

cid 403219
ioctl isn't released

6 years agostream_filter: smooth: fix negative array access
Francois Cartegnie [Wed, 12 Mar 2014 17:30:31 +0000 (18:30 +0100)]
stream_filter: smooth: fix negative array access

cid #1048853

6 years agocodec: vorbix: max channels is 8
Francois Cartegnie [Wed, 12 Mar 2014 17:25:40 +0000 (18:25 +0100)]
codec: vorbix: max channels is 8

fix cid #1048883

6 years agodemux: avi: missing initializers
Francois Cartegnie [Wed, 12 Mar 2014 17:00:00 +0000 (18:00 +0100)]
demux: avi: missing initializers

really unlikely (malloc fails)
cid #1049010 #1049009 #1049008 #1049007 #1049006

6 years agowin32: fix warning
Rémi Denis-Courmont [Wed, 12 Mar 2014 17:06:00 +0000 (19:06 +0200)]
win32: fix warning

6 years agowin32: fix starting the single interface backend (fixes #10494)
Rémi Denis-Courmont [Wed, 12 Mar 2014 17:00:25 +0000 (19:00 +0200)]
win32: fix starting the single interface backend (fixes #10494)

6 years agowinmsg: fix name
Rémi Denis-Courmont [Wed, 12 Mar 2014 17:00:04 +0000 (19:00 +0200)]
winmsg: fix name

6 years agocodec: opus: don't support more than 8 channels
Francois Cartegnie [Wed, 12 Mar 2014 16:50:31 +0000 (17:50 +0100)]
codec: opus: don't support more than 8 channels

We have no mapping for > 8 channels.
cid #1062574

6 years agoyuv: deal with crop (fixes #9160)
Rémi Denis-Courmont [Wed, 12 Mar 2014 16:50:10 +0000 (18:50 +0200)]
yuv: deal with crop (fixes #9160)

6 years agomux: ogg: kill out of bound access warning for contenttypeless codecs.
Francois Cartegnie [Wed, 12 Mar 2014 16:41:43 +0000 (17:41 +0100)]
mux: ogg: kill out of bound access warning for contenttypeless codecs.

6 years agodemux: ogg: fix use after free
Francois Cartegnie [Wed, 12 Mar 2014 16:19:09 +0000 (17:19 +0100)]
demux: ogg: fix use after free

cid #1191891

6 years agodemux: ogg: clear reordering struct on early stream deletion
Francois Cartegnie [Wed, 12 Mar 2014 16:05:34 +0000 (17:05 +0100)]
demux: ogg: clear reordering struct on early stream deletion

6 years agodemux: ogg: wrong allocation size
Francois Cartegnie [Wed, 12 Mar 2014 16:04:23 +0000 (17:04 +0100)]
demux: ogg: wrong allocation size

cid #1191888

6 years agoextras/ios: fix compilation with Xcode 5.1
Felix Paul Kühne [Wed, 12 Mar 2014 14:30:15 +0000 (15:30 +0100)]
extras/ios: fix compilation with Xcode 5.1

6 years agocaopengllayer: improved main thread synchronization and locking
Florent Pillet [Tue, 11 Mar 2014 22:52:13 +0000 (23:52 +0100)]
caopengllayer: improved main thread synchronization and locking

Grouping of 2 sync calls into one, use of CATransaction lock / unlock instead of being / commit and introduction of GCD

Signed-off-by: Felix Paul Kühne <fkuehne@videolan.org>
6 years agorawvideo: use chroma desc, follow dimensions set by the demuxer
Rémi Denis-Courmont [Tue, 11 Mar 2014 20:34:50 +0000 (22:34 +0200)]
rawvideo: use chroma desc, follow dimensions set by the demuxer

Refs #10722, refs #10723. Also fix a small leak on error.

6 years agopicture_Setup: missing const
Rémi Denis-Courmont [Tue, 11 Mar 2014 21:48:57 +0000 (23:48 +0200)]
picture_Setup: missing const

6 years agovdpau: adjust SPU position and size (fixes #10909)
Rémi Denis-Courmont [Tue, 11 Mar 2014 19:39:11 +0000 (21:39 +0200)]
vdpau: adjust SPU position and size (fixes #10909)

6 years agoqt: support for Qt5 windows build
Rafaël Carré [Tue, 11 Mar 2014 10:17:14 +0000 (11:17 +0100)]
qt: support for Qt5 windows build

6 years agoqt4: fix windows build after 6ea38362e66
Rafaël Carré [Tue, 11 Mar 2014 08:11:12 +0000 (09:11 +0100)]
qt4: fix windows build after 6ea38362e66

6 years agoinput: correct default value check for $demux (fixes #10475)
Rémi Denis-Courmont [Mon, 10 Mar 2014 20:29:13 +0000 (22:29 +0200)]
input: correct default value check for $demux (fixes #10475)

6 years agoinput: factor if and add error handling to demux_New()
Rémi Denis-Courmont [Mon, 10 Mar 2014 20:00:40 +0000 (22:00 +0200)]
input: factor if and add error handling to demux_New()

6 years agoContribs: patch iconv for WinRT
Jean-Baptiste Kempf [Mon, 10 Mar 2014 19:40:49 +0000 (20:40 +0100)]
Contribs: patch iconv for WinRT

6 years agoQt: SeekSlider: don't show buffering < 1s
Francois Cartegnie [Mon, 10 Mar 2014 19:41:05 +0000 (20:41 +0100)]
Qt: SeekSlider: don't show buffering < 1s

6 years agoQt: seekstyle: pass parameters through options.
Francois Cartegnie [Mon, 10 Mar 2014 19:34:31 +0000 (20:34 +0100)]
Qt: seekstyle: pass parameters through options.

6 years agoplaylist: remove b_auto_preparse
Rémi Denis-Courmont [Mon, 10 Mar 2014 19:35:58 +0000 (21:35 +0200)]
playlist: remove b_auto_preparse

6 years agoplaylist: use playlist preparser for playlist items (fixes #10344)
Rémi Denis-Courmont [Mon, 10 Mar 2014 19:32:13 +0000 (21:32 +0200)]
playlist: use playlist preparser for playlist items (fixes #10344)

6 years agoprojectm: fix NULL or uninitialized pointer dereference
Rafaël Carré [Mon, 10 Mar 2014 18:44:17 +0000 (19:44 +0100)]
projectm: fix NULL or uninitialized pointer dereference

6 years agolib: reset the audio output when selecting amem or custom plugin
Rémi Denis-Courmont [Mon, 10 Mar 2014 17:18:43 +0000 (19:18 +0200)]
lib: reset the audio output when selecting amem or custom plugin

6 years agoresource: add input_resource_ResetAout()
Rémi Denis-Courmont [Mon, 10 Mar 2014 17:18:18 +0000 (19:18 +0200)]
resource: add input_resource_ResetAout()

6 years agoaout: fix potential crash if changing device on aout being deleted
Rémi Denis-Courmont [Mon, 10 Mar 2014 16:35:44 +0000 (18:35 +0200)]
aout: fix potential crash if changing device on aout being deleted

6 years agoresource: simplify & reduce aout locking
Rémi Denis-Courmont [Mon, 10 Mar 2014 16:31:54 +0000 (18:31 +0200)]
resource: simplify & reduce aout locking

6 years agoavcodec: use PRIx64 to print uint64_t
Rafaël Carré [Mon, 10 Mar 2014 16:39:10 +0000 (17:39 +0100)]
avcodec: use PRIx64 to print uint64_t

6 years agodemux: ogg: add more divbyzero checks and fix oggds ones
Francois Cartegnie [Mon, 10 Mar 2014 12:36:39 +0000 (13:36 +0100)]
demux: ogg: add more divbyzero checks and fix oggds ones

cid 1191737

6 years agodemux: ogg: rewrite pts and pts computation (fix #9828)
Francois Cartegnie [Fri, 28 Feb 2014 01:03:15 +0000 (02:03 +0100)]
demux: ogg: rewrite pts and pts computation (fix #9828)

- Previous algorithm was unable to guess the first packet
pts because of ogg design (some codecs/opus/vorbis have total
sample at page granule and only granule on last packet. You
then need to compute first packet pts backward using packets
duration).
So we were stuck either assuming a start at pts/pcr zero, or
be unable to handle ogg streaming (non zero start) correctly,
or had to always drop the 0..N-1 packets for first page.
We need libvorbis to correcly compute those durations (code
is far more complex than opus's one).
- Refactorized to discard the tons of cases appended
with each new codec.
- lots of other fixes in many places

6 years agodemux: dvdnav: always update chapter variable after title change. (fix
Francois Cartegnie [Sun, 9 Mar 2014 23:25:16 +0000 (00:25 +0100)]
demux: dvdnav: always update chapter variable after title change. (fix

Because event will rebuild chapter variable.

6 years agoxcb/glx: correct viewport position (fixes #10907)
Rémi Denis-Courmont [Sun, 9 Mar 2014 21:25:22 +0000 (23:25 +0200)]
xcb/glx: correct viewport position (fixes #10907)

6 years agoopengl: correct view port position
Rémi Denis-Courmont [Sun, 9 Mar 2014 21:25:09 +0000 (23:25 +0200)]
opengl: correct view port position

6 years agometaengine: folder: test uri against folder first. (fix #10380)
Francois Cartegnie [Sun, 9 Mar 2014 20:50:34 +0000 (21:50 +0100)]
metaengine: folder: test uri against folder first. (fix #10380)

because make_path strips last segment

6 years agov4l2: implement --v4l2-fps for real (fixes #7395)
Rémi Denis-Courmont [Sun, 9 Mar 2014 20:30:09 +0000 (22:30 +0200)]
v4l2: implement --v4l2-fps for real (fixes #7395)

6 years agomacosx: cleanup blocked shortcuts
David Fuhrmann [Sat, 8 Mar 2014 09:30:31 +0000 (10:30 +0100)]
macosx: cleanup blocked shortcuts

6 years agomacosx: increase size of dvd menu button for l10n
David Fuhrmann [Sat, 8 Mar 2014 09:08:58 +0000 (10:08 +0100)]
macosx: increase size of dvd menu button for l10n

6 years agomacosx: remove open BDMV folder button
David Fuhrmann [Sat, 8 Mar 2014 08:54:58 +0000 (09:54 +0100)]
macosx: remove open BDMV folder button

Two different buttons signify to the user that there is an
actual difference in using either of these. But in fact,
both call the same code and if the folder is misnamed, even
the BDMV button would classify the folder as a DVD type.

stringcount--

6 years agomacosx: removed 6 strings
David Fuhrmann [Sat, 8 Mar 2014 08:31:50 +0000 (09:31 +0100)]
macosx: removed 6 strings

6 years agoConfigure.ac: fix check for 32 bit luac on some platforms
David Fuhrmann [Thu, 6 Mar 2014 15:38:48 +0000 (16:38 +0100)]
Configure.ac: fix check for 32 bit luac on some platforms

6 years agoQt: VLCModel/TreeView: delegate cover rendering (fix #10206)
Francois Cartegnie [Sat, 8 Mar 2014 19:01:30 +0000 (20:01 +0100)]
Qt: VLCModel/TreeView: delegate cover rendering (fix #10206)

6 years agodemux: ogg: keep searching for 1st page if incomplete
Francois Cartegnie [Fri, 7 Mar 2014 02:33:15 +0000 (03:33 +0100)]
demux: ogg: keep searching for 1st page if incomplete

6 years agoextras/ios: disable addon manager modules
Felix Paul Kühne [Sat, 8 Mar 2014 13:02:01 +0000 (14:02 +0100)]
extras/ios: disable addon manager modules

6 years agoxcb/glx: remove stray libraries
Rémi Denis-Courmont [Sat, 8 Mar 2014 08:57:16 +0000 (10:57 +0200)]
xcb/glx: remove stray libraries

6 years agoMP4 demux: only set fragmented flag if filecontains movie fragment atoms.
Matthias Keiser [Fri, 7 Mar 2014 22:16:31 +0000 (23:16 +0100)]
MP4 demux: only set fragmented flag if filecontains movie fragment atoms.

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>
6 years agoprojectM: make GL context current
Rémi Denis-Courmont [Fri, 7 Mar 2014 19:40:20 +0000 (21:40 +0200)]
projectM: make GL context current

6 years agovsxu: make GL context current
Rémi Denis-Courmont [Fri, 7 Mar 2014 19:38:33 +0000 (21:38 +0200)]
vsxu: make GL context current

6 years agoglspectrum: bind GL context when needed
Rémi Denis-Courmont [Fri, 7 Mar 2014 19:36:56 +0000 (21:36 +0200)]
glspectrum: bind GL context when needed

6 years agoxcb/glx: reuse the GLX provider code and eliminate a lot of code
Rémi Denis-Courmont [Fri, 7 Mar 2014 19:01:04 +0000 (21:01 +0200)]
xcb/glx: reuse the GLX provider code and eliminate a lot of code