vlc.git
4 years agomacOS: Correct Xcode build files
Marvin Scholz [Sun, 7 May 2017 21:06:47 +0000 (23:06 +0200)]
macOS: Correct Xcode build files

Some files were missing and .h files were in this section but shouldn't,
same for XIB files. So those are removed by this commit and the missing
files were added.

4 years agodarwinvlc: Clarify comment about PSN argument
Marvin Scholz [Sun, 7 May 2017 17:36:36 +0000 (19:36 +0200)]
darwinvlc: Clarify comment about PSN argument

4 years agoavcodec: unbreak libav hardware acceleration (fixes #18170)
Rémi Denis-Courmont [Fri, 5 May 2017 17:04:51 +0000 (20:04 +0300)]
avcodec: unbreak libav hardware acceleration (fixes #18170)

Regression from commit 869db8d97312545567506a4c06df045c14c6d02d.

4 years agocontribs: faad: add patched define in header
Francois Cartegnie [Thu, 4 May 2017 11:53:19 +0000 (13:53 +0200)]
contribs: faad: add patched define in header

4 years agocodec: faad2: hotfix unpatched 3F3R 6.1 channel repeat
Francois Cartegnie [Thu, 4 May 2017 11:51:42 +0000 (13:51 +0200)]
codec: faad2: hotfix unpatched 3F3R 6.1 channel repeat

4 years agoaudio_output: add 3F3R 6.1 description
Francois Cartegnie [Thu, 4 May 2017 10:33:43 +0000 (12:33 +0200)]
audio_output: add 3F3R 6.1 description

4 years agolibVLC: comment the ranges for viewpoint
Jean-Baptiste Kempf [Wed, 3 May 2017 20:14:05 +0000 (22:14 +0200)]
libVLC: comment the ranges for viewpoint

4 years agohotkeys: Implement reverse sub track cycling
Mohammed (Shaan) Huzaifa Danish [Wed, 3 May 2017 05:36:49 +0000 (22:36 -0700)]
hotkeys: Implement reverse sub track cycling

Pressing 'v' to change the cycle track, we now use 'Alt+v' to cycle in the reverse direction.

Close #8958

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>
4 years agod3d11va: CreateVideoDecoderOutputView() shouldn't fail because of incorrect init
Steve Lhomme [Tue, 2 May 2017 11:52:02 +0000 (13:52 +0200)]
d3d11va: CreateVideoDecoderOutputView() shouldn't fail because of incorrect init

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>
4 years agomacOS: Set correct fullscreen window level
Andreas Mieke [Tue, 2 May 2017 19:15:00 +0000 (21:15 +0200)]
macOS: Set correct fullscreen window level

Setting the correct fullscreen window level to hide menu bar
when other apps are active, according to
https://developer.apple.com/library/content/documentation/GraphicsImaging/Conceptual/OpenGL-MacProgGuide/opengl_fullscreen/opengl_cgl.html

Fix #18117

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>
4 years agodemux: ts: don't update hw filters in es add loops
Francois Cartegnie [Wed, 3 May 2017 12:52:24 +0000 (14:52 +0200)]
demux: ts: don't update hw filters in es add loops

4 years agodemux: mp4: simplify map trun contexes
Francois Cartegnie [Tue, 2 May 2017 17:43:41 +0000 (19:43 +0200)]
demux: mp4: simplify map trun contexes

4 years agodemux: mp4: use sidx index for seeking
Francois Cartegnie [Tue, 2 May 2017 13:49:50 +0000 (15:49 +0200)]
demux: mp4: use sidx index for seeking

4 years agodemux: mp4: don't use mvhd duration for seek
Francois Cartegnie [Tue, 2 May 2017 13:46:09 +0000 (15:46 +0200)]
demux: mp4: don't use mvhd duration for seek

4 years agodemux: mp4: set as fragmented if sidx
Francois Cartegnie [Tue, 2 May 2017 12:59:17 +0000 (14:59 +0200)]
demux: mp4: set as fragmented if sidx

4 years agodemux: mp4: remove temporary scaling in parse trun
Francois Cartegnie [Tue, 2 May 2017 11:57:23 +0000 (13:57 +0200)]
demux: mp4: remove temporary scaling in parse trun

4 years agoqt: Ensure categories name is always displayed
Hugo Beauzée-Luyssen [Wed, 3 May 2017 12:28:09 +0000 (14:28 +0200)]
qt: Ensure categories name is always displayed

4 years agovout opengl: Change non-error to a debug message
Marvin Scholz [Wed, 3 May 2017 09:41:16 +0000 (11:41 +0200)]
vout opengl: Change non-error to a debug message

Replace msg_Err with msg_Dbg, as it is reported that PBO support is
enabled, which is not an error.

Signed-off-by: Hugo Beauzée-Luyssen <hugo@beauzee.fr>
4 years agosubtitle: Fix potential memory leaks
Hugo Beauzée-Luyssen [Wed, 3 May 2017 10:34:56 +0000 (12:34 +0200)]
subtitle: Fix potential memory leaks

4 years agomkv: Don't attempt to print null strings
Hugo Beauzée-Luyssen [Wed, 3 May 2017 09:13:52 +0000 (11:13 +0200)]
mkv: Don't attempt to print null strings

4 years agomkv: Fix potential memory leaks
Hugo Beauzée-Luyssen [Wed, 3 May 2017 09:04:45 +0000 (11:04 +0200)]
mkv: Fix potential memory leaks

4 years agomkv: matroska_segment_parse: Remove trailing whitespace
Hugo Beauzée-Luyssen [Wed, 3 May 2017 08:23:03 +0000 (10:23 +0200)]
mkv: matroska_segment_parse: Remove trailing whitespace

4 years agomkv: Constify ParseTrackEntry parameter
Hugo Beauzée-Luyssen [Wed, 3 May 2017 08:22:26 +0000 (10:22 +0200)]
mkv: Constify ParseTrackEntry parameter

4 years agovout: win32: Always check for a rect update when autoscale/zoom changes
Hugo Beauzée-Luyssen [Tue, 2 May 2017 16:58:12 +0000 (18:58 +0200)]
vout: win32: Always check for a rect update when autoscale/zoom changes

refs #18258

4 years agod3d9: Remove useless ControlResetDevice intermediate function
Hugo Beauzée-Luyssen [Tue, 2 May 2017 16:53:30 +0000 (18:53 +0200)]
d3d9: Remove useless ControlResetDevice intermediate function

4 years agocontrib: Use libmicrodns 0.0.6
Hugo Beauzée-Luyssen [Tue, 2 May 2017 09:52:24 +0000 (11:52 +0200)]
contrib: Use libmicrodns 0.0.6

4 years agoconfigure: Improve detection of ibtool
Marvin Scholz [Tue, 25 Apr 2017 13:27:24 +0000 (15:27 +0200)]
configure: Improve detection of ibtool

Previously there was no error handling if ibtool was not found
and xcrun was not used to find it, but the path that xcrun provides
should be preferred, as on some systems and earlier macOS versions
it might not be in the PATH.

4 years agodirect3d11: allow allocating textures for a processor input without display support
Steve Lhomme [Fri, 28 Apr 2017 15:46:23 +0000 (17:46 +0200)]
direct3d11: allow allocating textures for a processor input without display support

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>
4 years agoqt: Use native events to notify of a video widget resize
Hugo Beauzée-Luyssen [Tue, 25 Apr 2017 09:10:16 +0000 (11:10 +0200)]
qt: Use native events to notify of a video widget resize

This method can't be used for Wayland as Qt won't invoke
QWidget::nativeEvent when Wayland is used.
Fix #18211

4 years agodemux: mkv: parse language codes with embedded country codes
Shaleen Jain [Thu, 27 Apr 2017 16:52:28 +0000 (22:22 +0530)]
demux: mkv: parse language codes with embedded country codes

fixes bug: https://trac.videolan.org/vlc/ticket/11813
mkv spec: https://www.matroska.org/technical/specs/index.html#languages

Signed-off-by: Hugo Beauzée-Luyssen <hugo@beauzee.fr>
4 years agoqt: extended_panels: Remove empty destructor
Hugo Beauzée-Luyssen [Fri, 28 Apr 2017 12:32:48 +0000 (14:32 +0200)]
qt: extended_panels: Remove empty destructor

4 years agodirect3d11: split the FindD3D11Format calls into more logical calls
Steve Lhomme [Fri, 28 Apr 2017 15:46:22 +0000 (17:46 +0200)]
direct3d11: split the FindD3D11Format calls into more logical calls

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>
4 years agodirect3d11: factorize the code to find an appropriate texture format
Steve Lhomme [Fri, 28 Apr 2017 15:46:21 +0000 (17:46 +0200)]
direct3d11: factorize the code to find an appropriate texture format

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>
4 years agodirect3d11: factorize code to check if a format supports some features
Steve Lhomme [Fri, 28 Apr 2017 15:46:20 +0000 (17:46 +0200)]
direct3d11: factorize code to check if a format supports some features

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>
4 years agodirect3d11: make sure the decoder pool format supports decoder output
Steve Lhomme [Fri, 28 Apr 2017 15:46:19 +0000 (17:46 +0200)]
direct3d11: make sure the decoder pool format supports decoder output

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>
4 years agodirect3d11: make sure the device created supports HW decoding for opaque inputs
Steve Lhomme [Fri, 28 Apr 2017 15:46:18 +0000 (17:46 +0200)]
direct3d11: make sure the device created supports HW decoding for opaque inputs

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>
4 years agodirect3d11: don't request specific feature levels
Steve Lhomme [Fri, 28 Apr 2017 15:46:17 +0000 (17:46 +0200)]
direct3d11: don't request specific feature levels

Windows 7 doesn't give a proper device otherwise. We don't use any specific
feature above 11 so we let the OS/driver decide what's best.

Close #18237

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>
4 years agodirect3d11: don't use D3D11_MAP_WRITE_NO_OVERWRITE as it's not needed
Steve Lhomme [Fri, 28 Apr 2017 15:46:16 +0000 (17:46 +0200)]
direct3d11: don't use D3D11_MAP_WRITE_NO_OVERWRITE as it's not needed

And not always supported.

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>
4 years agodirect3d11: use same texture size for the staging texture as the decoding one
Steve Lhomme [Fri, 28 Apr 2017 15:46:15 +0000 (17:46 +0200)]
direct3d11: use same texture size for the staging texture as the decoding one

Fixes some positioning issues when the staging texture is used.

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>
4 years agottml: remove nonsensical pointer cast
Rémi Denis-Courmont [Sun, 30 Apr 2017 16:17:43 +0000 (19:17 +0300)]
ttml: remove nonsensical pointer cast

The difference between the integer representation of two pointers has
no particular meaning in general (the result is platform-dependent),
other than zero meaning equality. It is only really useful when dealing
with data alignment.

In this case, both operands point into the same object, so the pointer
difference is well-defined anyhow.

4 years agottml: remove bogus casts
Rémi Denis-Courmont [Sun, 30 Apr 2017 16:14:51 +0000 (19:14 +0300)]
ttml: remove bogus casts

ptrdiff_t is the result type for a substraction of pointers, not the
operands type for the substraction. The cast made no sense.

To convert pointers to signed integers, intptr_t shall be used. But
there is no point in casting here: equality and inequality are always
well-defined for valid and/or NULL pointers.

4 years agoyadif: fix linking
Rémi Denis-Courmont [Sat, 29 Apr 2017 19:33:39 +0000 (22:33 +0300)]
yadif: fix linking

This fixes the following error on x86:

In function `yadif_filter_line_ssse3.lto_priv.4':
modules/video_filter/deinterlace/yadif_template.h:262:
 undefined reference to `pw_1'
relocation R_X86_64_PC32 against undefined symbol `pw_1' can not be used
when making a shared object; recompile with -fPIC

This also fixes run-time with compilers other than MSVC and GCC.

4 years agodemux: mp4: force track timescale to nonzero
Francois Cartegnie [Sat, 29 Apr 2017 10:24:59 +0000 (12:24 +0200)]
demux: mp4: force track timescale to nonzero

4 years agodemux: mp4: split track init/setup/clean
Francois Cartegnie [Sat, 29 Apr 2017 10:19:19 +0000 (12:19 +0200)]
demux: mp4: split track init/setup/clean

4 years agodemux: mp4: early reject invalid timescale
Francois Cartegnie [Sat, 29 Apr 2017 10:36:11 +0000 (12:36 +0200)]
demux: mp4: early reject invalid timescale

4 years agodemux: mp4: check fragmentation after tracks creation
Francois Cartegnie [Sat, 29 Apr 2017 09:44:41 +0000 (11:44 +0200)]
demux: mp4: check fragmentation after tracks creation

4 years agodemux: mp4: check fragments
Francois Cartegnie [Sat, 29 Apr 2017 09:44:12 +0000 (11:44 +0200)]
demux: mp4: check fragments

4 years agopacketizer: dts: rewrite 18166 fix
Francois Cartegnie [Fri, 28 Apr 2017 16:15:32 +0000 (18:15 +0200)]
packetizer: dts: rewrite 18166 fix

4 years agoinput: decoder: fix cc decoders reference leak
Francois Cartegnie [Fri, 28 Apr 2017 12:25:10 +0000 (14:25 +0200)]
input: decoder: fix cc decoders reference leak

decoder_QueueVideoWithCc regression

4 years agosubtitle: Fix potential heap buffer overflow
Hugo Beauzée-Luyssen [Fri, 28 Apr 2017 11:56:46 +0000 (13:56 +0200)]
subtitle: Fix potential heap buffer overflow

Reported-by: Yannay Livneh <yannayl@checkpoint.com>
             Omri Herscovici <omrih@checkpoint.com>
             Omer Gull <omergu@checkpoint.com>

4 years agomp4: Fix use after free
Hugo Beauzée-Luyssen [Fri, 28 Apr 2017 11:23:36 +0000 (13:23 +0200)]
mp4: Fix use after free

4 years agosubtitle: Fix potential heap buffer overflow
Hugo Beauzée-Luyssen [Fri, 28 Apr 2017 08:00:11 +0000 (10:00 +0200)]
subtitle: Fix potential heap buffer overflow

Reported-by: Yannay Livneh <yannayl@checkpoint.com>
             Omri Herscovici <omrih@checkpoint.com>
             Omer Gull <omergu@checkpoint.com>

4 years agodemux: hls: fix null deref warning (cid #1405538)
Francois Cartegnie [Fri, 28 Apr 2017 08:36:04 +0000 (10:36 +0200)]
demux: hls: fix null deref warning (cid #1405538)

4 years agodemux: ttml: uninit illegal access (cid #1405678)
Francois Cartegnie [Fri, 28 Apr 2017 08:33:26 +0000 (10:33 +0200)]
demux: ttml: uninit illegal access (cid #1405678)

4 years agoaccess: bluray: use stored pid instead of fmt.id
Francois Cartegnie [Fri, 28 Apr 2017 08:30:51 +0000 (10:30 +0200)]
access: bluray: use stored pid instead of fmt.id

no guarantee ts will set id it to pid

4 years agovout: update interlacing handling
Victorien Le Couviour--Tuffet [Tue, 25 Apr 2017 19:21:57 +0000 (21:21 +0200)]
vout: update interlacing handling

Remove deinterlace from 'video-filter' vlc string variable, now handling it
with a boolean.

This fixes a bug that happened when deinterlacing a video and applying a new
filter: the deinterlace filter was not reapplied when rebuilding the filter
chain.

We couldn't retrieve this var from the GUI as the presence of this filter can
change at any time, considering that a video can be partially interlaced many
times.

It's also cleaner to handle the presence of the deinterlace filter without
using a VLC variable as we only need to know if it's there in the video output
module.

Signed-off-by: Thomas Guillem <thomas@gllm.fr>
4 years agovout: remove xmalloc
Victorien Le Couviour--Tuffet [Tue, 25 Apr 2017 19:21:56 +0000 (21:21 +0200)]
vout: remove xmalloc

Signed-off-by: Thomas Guillem <thomas@gllm.fr>
4 years agoaccess: bluray: also flag discontinuity on SET_SEEKPOINT
Thomas Guillem [Fri, 28 Apr 2017 06:24:16 +0000 (08:24 +0200)]
access: bluray: also flag discontinuity on SET_SEEKPOINT

4 years agottml: correct element style resolution order
Remita Amine [Mon, 24 Apr 2017 12:57:11 +0000 (13:57 +0100)]
ttml: correct element style resolution order

the element style resolution order should start with Inline Styling
than Referential Styling than Region Style Inheritance without
overriding.

if we have:
<style xml:id="captionStyle" tts:color="red"/>
and:
<span style="captionStyle" tts:color="green">test</span>

so in the example the color should be green not red.

Signed-off-by: Francois Cartegnie <fcvlcdev@free.fr>
4 years agodemux: ttml: probe extra namespaces
Francois Cartegnie [Thu, 27 Apr 2017 18:02:44 +0000 (20:02 +0200)]
demux: ttml: probe extra namespaces

4 years agoaccess: bluray: flag discontinuity on seek
Francois Cartegnie [Thu, 27 Apr 2017 16:19:46 +0000 (18:19 +0200)]
access: bluray: flag discontinuity on seek

Note: this can't prevent all other issues due
to stream_demux

4 years agodemux: ts: flag discontinuity on explicit discontinuity
Francois Cartegnie [Thu, 27 Apr 2017 17:39:40 +0000 (19:39 +0200)]
demux: ts: flag discontinuity on explicit discontinuity

4 years agodemux: ts: flag discontinuity on post flush output
Francois Cartegnie [Thu, 27 Apr 2017 17:17:24 +0000 (19:17 +0200)]
demux: ts: flag discontinuity on post flush output

4 years agodirect3d9: Don't create a new picture pool for each frame
Hugo Beauzée-Luyssen [Thu, 27 Apr 2017 15:18:30 +0000 (17:18 +0200)]
direct3d9: Don't create a new picture pool for each frame

This "might" explain the recent performance complains...

4 years agodemux: ttml: probe UTF-16
Francois Cartegnie [Thu, 27 Apr 2017 15:21:45 +0000 (17:21 +0200)]
demux: ttml: probe UTF-16

4 years agovlc_block: renumber flags
Francois Cartegnie [Wed, 12 Apr 2017 15:07:45 +0000 (17:07 +0200)]
vlc_block: renumber flags

4 years agovlc_block: add BLOCK_FLAG_SINGLE_FIELD
Francois Cartegnie [Wed, 12 Apr 2017 15:07:44 +0000 (17:07 +0200)]
vlc_block: add BLOCK_FLAG_SINGLE_FIELD

4 years agovlc_block: remove BLOCK_FLAG_END_OF_FRAME
Francois Cartegnie [Wed, 12 Apr 2017 15:07:43 +0000 (17:07 +0200)]
vlc_block: remove BLOCK_FLAG_END_OF_FRAME

4 years agovlc_block: remove BLOCK_FLAG_NO_KEYFRAME
Francois Cartegnie [Wed, 12 Apr 2017 15:07:42 +0000 (17:07 +0200)]
vlc_block: remove BLOCK_FLAG_NO_KEYFRAME

only used internally by ts muxer

4 years agodemux: hls: add keystore (fix #18259)
Francois Cartegnie [Wed, 26 Apr 2017 16:38:24 +0000 (18:38 +0200)]
demux: hls: add keystore (fix #18259)

4 years agodemux: mp4: remove fragments storage
Francois Cartegnie [Thu, 20 Apr 2017 13:10:27 +0000 (15:10 +0200)]
demux: mp4: remove fragments storage

not compatible with sout, so was disabled
in that case. We also can remove it for
regular playback and just create an index
when people try to seek.

4 years agovsxu: ensure that the GL context is attached
Thomas Guillem [Tue, 25 Apr 2017 11:52:01 +0000 (13:52 +0200)]
vsxu: ensure that the GL context is attached

4 years agoprojectm: ensure that the GL context is attached
Thomas Guillem [Tue, 25 Apr 2017 11:51:53 +0000 (13:51 +0200)]
projectm: ensure that the GL context is attached

4 years agoglspectrum: ensure that the GL context is attached
Thomas Guillem [Tue, 25 Apr 2017 11:51:47 +0000 (13:51 +0200)]
glspectrum: ensure that the GL context is attached

4 years agovout/ios: ensure that the GL context is attached
Thomas Guillem [Tue, 25 Apr 2017 11:51:24 +0000 (13:51 +0200)]
vout/ios: ensure that the GL context is attached

4 years agovout/macosx: ensure that the GL context is attached
Thomas Guillem [Tue, 25 Apr 2017 11:50:35 +0000 (13:50 +0200)]
vout/macosx: ensure that the GL context is attached

4 years agovout/gl: ensure that the GL context is attached
Thomas Guillem [Tue, 25 Apr 2017 11:49:48 +0000 (13:49 +0200)]
vout/gl: ensure that the GL context is attached

4 years agosnapcraft: Don't use desktop-qt5 part
Hugo Beauzée-Luyssen [Tue, 25 Apr 2017 11:51:27 +0000 (13:51 +0200)]
snapcraft: Don't use desktop-qt5 part

It requires deprecated (and removed on yaketty) packages, and we don't
need all the packages included there

4 years agosnapcraft: libschroedinger-dev isn't packaged anymore
Hugo Beauzée-Luyssen [Tue, 25 Apr 2017 09:31:09 +0000 (11:31 +0200)]
snapcraft: libschroedinger-dev isn't packaged anymore

4 years agoqt: Privatize VOLUME_MAX
Hugo Beauzée-Luyssen [Mon, 24 Apr 2017 14:33:55 +0000 (16:33 +0200)]
qt: Privatize VOLUME_MAX

4 years agoqt: Use the correct maximum volume
Hugo Beauzée-Luyssen [Mon, 24 Apr 2017 14:33:17 +0000 (16:33 +0200)]
qt: Use the correct maximum volume

So we can go back to a "3 state" volume icon

4 years agoqt: Use HighDPI pixmaps
Hugo Beauzée-Luyssen [Mon, 24 Apr 2017 14:25:57 +0000 (16:25 +0200)]
qt: Use HighDPI pixmaps

4 years agoqt: Merge extremely similar clear/quit pixmaps into one
Hugo Beauzée-Luyssen [Mon, 24 Apr 2017 13:51:51 +0000 (15:51 +0200)]
qt: Merge extremely similar clear/quit pixmaps into one

4 years agoqt: Remove unused pixmap
Hugo Beauzée-Luyssen [Mon, 24 Apr 2017 13:19:32 +0000 (15:19 +0200)]
qt: Remove unused pixmap

4 years agomacosx: update allowed subtitle file extensions
Gonzalo Higuera Díaz [Sat, 22 Apr 2017 22:27:46 +0000 (00:27 +0200)]
macosx: update allowed subtitle file extensions

Make the list match the one found at include/vlc_interface.h.

Signed-off-by: Felix Paul Kühne <fkuehne@videolan.org>
4 years agovideotoolbox: abort when restart fails from Malfunction
Thomas Guillem [Mon, 24 Apr 2017 15:46:30 +0000 (17:46 +0200)]
videotoolbox: abort when restart fails from Malfunction

4 years agovideotoolbox: simplify error handling
Thomas Guillem [Mon, 24 Apr 2017 15:45:14 +0000 (17:45 +0200)]
videotoolbox: simplify error handling

4 years agovideotoolbox: remove goto reload
Thomas Guillem [Mon, 24 Apr 2017 15:44:05 +0000 (17:44 +0200)]
videotoolbox: remove goto reload

4 years agotests: add more dictionary tests
Francois Cartegnie [Sun, 23 Apr 2017 13:38:53 +0000 (15:38 +0200)]
tests: add more dictionary tests

4 years agovlc_arrays: fix vlc_dictionary_has_key
Francois Cartegnie [Sun, 23 Apr 2017 13:39:37 +0000 (15:39 +0200)]
vlc_arrays: fix vlc_dictionary_has_key

broken untested function went under the radar
and is testing index from hash instead of key.
50% false positive due to hash % size pos.

fixes random behaviour in ttml #18250
and probably playlist fetcher, dbus control

4 years agoextractor: fix invalid dereference
Rémi Denis-Courmont [Sat, 22 Apr 2017 15:47:32 +0000 (18:47 +0300)]
extractor: fix invalid dereference

4 years agomacosx: left-to-right alignment for titlebar views
David Fuhrmann [Sat, 22 Apr 2017 15:44:15 +0000 (17:44 +0200)]
macosx: left-to-right alignment for titlebar views

4 years agomacosx: main window: Natural alignment for sidebar items
David Fuhrmann [Sat, 22 Apr 2017 15:39:54 +0000 (17:39 +0200)]
macosx: main window: Natural alignment for sidebar items

4 years agomacosx: main window: integrate podcast bar into main window layout
David Fuhrmann [Sat, 22 Apr 2017 15:29:04 +0000 (17:29 +0200)]
macosx: main window: integrate podcast bar into main window layout

Use same mechanism to hide and show the bar as with bottom and
title bar.

4 years agomacosx: main window: integrate titlebar view, fix native fullscreen
David Fuhrmann [Sat, 22 Apr 2017 15:10:15 +0000 (17:10 +0200)]
macosx: main window: integrate titlebar view, fix native fullscreen

This is done the same way as with detached video window.

4 years agomacosx: main window: Hide prev and next button like all the others
David Fuhrmann [Sat, 22 Apr 2017 14:29:49 +0000 (16:29 +0200)]
macosx: main window: Hide prev and next button like all the others

Add those buttons in interface builder, and hide them like the
others. Remove custom creation code for these buttons.

4 years agomacosx: Switch to strong outlets for NSWindow and NSPanel
David Fuhrmann [Sat, 22 Apr 2017 14:01:42 +0000 (16:01 +0200)]
macosx: Switch to strong outlets for NSWindow and NSPanel

OS X 10.7 does not support weak outlets for those objects.

4 years agomacosx: main window: remove ambigous constraint in section bar
David Fuhrmann [Sat, 22 Apr 2017 14:01:17 +0000 (16:01 +0200)]
macosx: main window: remove ambigous constraint in section bar

4 years agomacosx: main window: Hiding of shuffle, repeat and effect buttons
David Fuhrmann [Sat, 22 Apr 2017 11:47:40 +0000 (13:47 +0200)]
macosx: main window: Hiding of shuffle, repeat and effect buttons

Now, just a constraint for width = 0 will be added or removed. All
the other magic happens with auto layout.

4 years agomacosx: main window: use autolayout to remove fullscreen button
David Fuhrmann [Sat, 22 Apr 2017 10:58:36 +0000 (12:58 +0200)]
macosx: main window: use autolayout to remove fullscreen button

Like in detached video window, use optional constraint to hide
fullscreen button if needed.