vlc.git
6 years agoxcb: remove unused parameter
Rémi Denis-Courmont [Sat, 8 Jun 2013 17:16:32 +0000 (20:16 +0300)]
xcb: remove unused parameter

6 years agoGLX: create window with same depth and visual as root
Rémi Denis-Courmont [Sat, 8 Jun 2013 17:13:34 +0000 (20:13 +0300)]
GLX: create window with same depth and visual as root

...rather than the parent window. This should work better if the parent
window is transparent or has whatever other unusual property. Also pass
a proper visual ID.

6 years agoxcb: clean up non-static function names
Rémi Denis-Courmont [Sat, 8 Jun 2013 16:58:27 +0000 (19:58 +0300)]
xcb: clean up non-static function names

6 years agoopensles: fix mismatch object lifecycle between open/close and start/stop
Rafaël Carré [Sat, 8 Jun 2013 11:16:44 +0000 (13:16 +0200)]
opensles: fix mismatch object lifecycle between open/close and start/stop

Refs: #8579

6 years agoopensles: do not set volume if aout start failed
Rafaël Carré [Sat, 8 Jun 2013 11:08:49 +0000 (13:08 +0200)]
opensles: do not set volume if aout start failed

Close: #8579

6 years agoDecklink access: set physical channels config
Rafaël Carré [Thu, 6 Jun 2013 11:41:37 +0000 (13:41 +0200)]
Decklink access: set physical channels config

6 years agomacosx: move fullscreen-related method to VideoWindowCommon class
David Fuhrmann [Thu, 6 Jun 2013 19:05:55 +0000 (21:05 +0200)]
macosx: move fullscreen-related method to VideoWindowCommon class

No functional changes, code is still inactive

6 years agomacosx: add missing retains when exchanging views
David Fuhrmann [Thu, 6 Jun 2013 19:04:18 +0000 (21:04 +0200)]
macosx: add missing retains when exchanging views

6 years agomacosx: remove recursive lock from fullscreen animation
David Fuhrmann [Wed, 5 Jun 2013 09:53:22 +0000 (11:53 +0200)]
macosx: remove recursive lock from fullscreen animation

This code is needless and had no effect for the last five years, already.

6 years agomacosx: try to correctly hide fspanel
David Fuhrmann [Sun, 2 Jun 2013 10:00:18 +0000 (12:00 +0200)]
macosx: try to correctly hide fspanel

hopefully fixes #8489

6 years agoNewer pot file
Christoph Miebach [Thu, 6 Jun 2013 15:44:11 +0000 (17:44 +0200)]
Newer pot file

6 years agoavcodec: support private options
Rafaël Carré [Wed, 5 Jun 2013 13:14:59 +0000 (15:14 +0200)]
avcodec: support private options

Usage:
--avcodec-options='{lowres=3,foobar=baz}'
--sout-avcodec-options='{threads=42}'

For now the decoder options are global, they apply to audio/video/subtitles decoder.
encoder options can be set in the sout chain, specific to each ES

6 years agolua http: make string easier to translate
Rafaël Carré [Thu, 6 Jun 2013 11:40:55 +0000 (13:40 +0200)]
lua http: make string easier to translate

6 years agoUse _WIN32 rather than WIN32 (same for WIN64)
Rafaël Carré [Wed, 5 Jun 2013 13:41:18 +0000 (15:41 +0200)]
Use _WIN32 rather than WIN32 (same for WIN64)

http://msdn.microsoft.com/en-us/library/b0084kay(v=vs.80).aspx only
mentions the _ prefixed variable.

gcc will always define the _ prefixed variable, like Visual Studio.
The prefixless one is defined in some language standards, e.g. gnu99
but not c99.

6 years agol10n: Czech update
Tomáš Chvátal [Wed, 5 Jun 2013 12:22:59 +0000 (14:22 +0200)]
l10n: Czech update

Signed-off-by: Christoph Miebach <christoph.miebach@web.de>
6 years agopo: correct Qt4 Ctrl+{H,L} translations
Rémi Denis-Courmont [Mon, 27 May 2013 15:58:40 +0000 (18:58 +0300)]
po: correct Qt4 Ctrl+{H,L} translations

(This should maybe not be marked for translation at all. Only Russian
defines it to something different than Ctrl+{H,L}.)

Adding whitespaces or translating "Ctrl" breaks Qt4 internals.

6 years agosgimb: use after free (fixes #8724)
Rémi Denis-Courmont [Tue, 4 Jun 2013 20:44:13 +0000 (23:44 +0300)]
sgimb: use after free (fixes #8724)

6 years agofaad decoder: fix decoding with some samples
Rafaël Carré [Tue, 4 Jun 2013 12:45:16 +0000 (14:45 +0200)]
faad decoder: fix decoding with some samples

6 years agoTS mux: use DTS if PTS is not available
Rafaël Carré [Fri, 31 May 2013 10:49:22 +0000 (12:49 +0200)]
TS mux: use DTS if PTS is not available

Ensure video can be decoded by VLC

6 years agoavcodec encoder: disable multithreading
Rafaël Carré [Tue, 28 May 2013 09:29:07 +0000 (11:29 +0200)]
avcodec encoder: disable multithreading

More work is needed before we can support it
Close #8544

6 years agopo: correct default encoding for Hebrew subtitles (fixes #7474)
Rémi Denis-Courmont [Sun, 16 Sep 2012 17:42:15 +0000 (20:42 +0300)]
po: correct default encoding for Hebrew subtitles (fixes #7474)

(cherry picked from commit f2d861c7341f75ee223b7859c6960d10bafdd1bf)

Conflicts:
po/he.po

6 years agofr: fix spelling of "aiguë(s)"
Rémi Denis-Courmont [Thu, 27 Dec 2012 15:03:04 +0000 (17:03 +0200)]
fr: fix spelling of "aiguë(s)"

(cherry picked from commit 57aa116198fcf231c1e424beed1f45969fbf4a17)

6 years agoglx: make context current before setting swap interval (fixes #8738)
Rémi Denis-Courmont [Thu, 30 May 2013 15:42:53 +0000 (18:42 +0300)]
glx: make context current before setting swap interval (fixes #8738)

6 years agoopengl: release current context before destroying it
Rémi Denis-Courmont [Thu, 30 May 2013 15:42:33 +0000 (18:42 +0300)]
opengl: release current context before destroying it

6 years agoopengl: add missing callback to release the (current) context
Rémi Denis-Courmont [Thu, 30 May 2013 15:38:47 +0000 (18:38 +0300)]
opengl: add missing callback to release the (current) context

6 years agoavcodec: set pkt_pts in old libavcodec versions
Rafaël Carré [Mon, 27 May 2013 07:19:03 +0000 (09:19 +0200)]
avcodec: set pkt_pts in old libavcodec versions

This is only meaningful in custom get_buffer callback that we use for direct rendering
Close #8711

Signed-off-by: Rémi Denis-Courmont <remi@remlab.net>
6 years agoavcodec video dec: remove useless assignement in destructor
Rafaël Carré [Mon, 27 May 2013 07:19:02 +0000 (09:19 +0200)]
avcodec video dec: remove useless assignement in destructor

Signed-off-by: Rémi Denis-Courmont <remi@remlab.net>
6 years agoavcodec: remove dummy EndSubtitleDec
Rafaël Carré [Mon, 27 May 2013 07:19:01 +0000 (09:19 +0200)]
avcodec: remove dummy EndSubtitleDec

Signed-off-by: Rémi Denis-Courmont <remi@remlab.net>
6 years agoffmpeg_GetFrameBuf: split out some direct rendering code
Rafaël Carré [Mon, 27 May 2013 07:19:00 +0000 (09:19 +0200)]
ffmpeg_GetFrameBuf: split out some direct rendering code

Signed-off-by: Rémi Denis-Courmont <remi@remlab.net>
6 years agoffmpeg_GetFrameBuf: simplify
Rafaël Carré [Mon, 27 May 2013 07:18:59 +0000 (09:18 +0200)]
ffmpeg_GetFrameBuf: simplify

Signed-off-by: Rémi Denis-Courmont <remi@remlab.net>
6 years agoffmpeg_GetFrameBuf: split out va code
Rafaël Carré [Mon, 27 May 2013 07:18:58 +0000 (09:18 +0200)]
ffmpeg_GetFrameBuf: split out va code

Signed-off-by: Rémi Denis-Courmont <remi@remlab.net>
6 years agoffmpeg_GetFrameBuf: simplify
Rafaël Carré [Mon, 27 May 2013 07:18:57 +0000 (09:18 +0200)]
ffmpeg_GetFrameBuf: simplify

Signed-off-by: Rémi Denis-Courmont <remi@remlab.net>
6 years agoffmpeg_ReleaseFrameBuf: simplify
Rafaël Carré [Mon, 27 May 2013 07:18:56 +0000 (09:18 +0200)]
ffmpeg_ReleaseFrameBuf: simplify

Signed-off-by: Rémi Denis-Courmont <remi@remlab.net>
6 years agoffmpeg_GetFormat: deindent
Rafaël Carré [Mon, 27 May 2013 07:18:55 +0000 (09:18 +0200)]
ffmpeg_GetFormat: deindent

Signed-off-by: Rémi Denis-Courmont <remi@remlab.net>
6 years agoTS demux: fix uninitialized language description
Rafaël Carré [Fri, 31 May 2013 12:35:37 +0000 (14:35 +0200)]
TS demux: fix uninitialized language description

Bug introduced by me in 12edd19f71

Signed-off-by: Rémi Denis-Courmont <remi@remlab.net>
6 years agoUpdate gettext to 0.18.2
Rémi Denis-Courmont [Fri, 31 May 2013 17:30:21 +0000 (20:30 +0300)]
Update gettext to 0.18.2

This supersedes commit 53c901581b3b44ea04f0058d4be0eb915704babf.

6 years agoRemove old unused recursive variables - make automake happy
Rémi Denis-Courmont [Fri, 31 May 2013 17:27:31 +0000 (20:27 +0300)]
Remove old unused recursive variables - make automake happy

6 years agoios: don't use absolute uninstalled prefix for gas-preprocessor.pl
Rafaël Carré [Tue, 4 Jun 2013 14:55:47 +0000 (14:55 +0000)]
ios: don't use absolute uninstalled prefix for gas-preprocessor.pl

It is already available in $PATH

Signed-off-by: Felix Paul Kühne <fkuehne@videolan.org>
7 years agol10n: Import translations
Christoph Miebach [Tue, 28 May 2013 16:54:42 +0000 (18:54 +0200)]
l10n: Import translations

7 years agoUpdating vlc.pot
Christoph Miebach [Tue, 28 May 2013 11:00:27 +0000 (13:00 +0200)]
Updating vlc.pot

7 years agoUse glEnable/glDisable with GL_TEXTURE_2D only for fixed pipeline(GLES 1.x)
Gleb Pinigin [Mon, 27 May 2013 08:15:49 +0000 (15:15 +0700)]
Use glEnable/glDisable with GL_TEXTURE_2D only for fixed pipeline(GLES 1.x)

Signed-off-by: Felix Paul Kühne <fkuehne@videolan.org>
7 years agoinhibit: dbus: add org.mate
Francois Cartegnie [Mon, 27 May 2013 13:42:40 +0000 (15:42 +0200)]
inhibit: dbus: add org.mate

7 years agomacosx: adapt setter for freetype settings
David Fuhrmann [Sun, 26 May 2013 17:49:24 +0000 (19:49 +0200)]
macosx: adapt setter for freetype settings

7 years agofreetype: do not cache variables for relative font size, background opacity, backgrou...
David Fuhrmann [Sun, 26 May 2013 16:48:00 +0000 (18:48 +0200)]
freetype: do not cache variables for relative font size, background opacity, background color, outline thickness and text color

fixes #8630

Signed-off-by: Rémi Denis-Courmont <remi@remlab.net>
7 years agoRevert "freetype: allow on-the-fly changes of relative font size, background opacity...
David Fuhrmann [Sun, 26 May 2013 15:57:15 +0000 (17:57 +0200)]
Revert "freetype: allow on-the-fly changes of relative font size, background opacity, background color, outline thickness and text color"

This reverts commit 269a40cbf9d15b7cdfcf58d205a41a25e66f714c.

Conflicts:
modules/text_renderer/freetype.c

Signed-off-by: Rémi Denis-Courmont <remi@remlab.net>
7 years agoauhal: remove some unused variables
David Fuhrmann [Sun, 26 May 2013 15:44:39 +0000 (17:44 +0200)]
auhal: remove some unused variables

7 years agoauhal: locking for access to i_selected_device
David Fuhrmann [Sun, 26 May 2013 15:36:03 +0000 (17:36 +0200)]
auhal: locking for access to i_selected_device

7 years agoauhal: restart aout only if necessary (fixes #8556)
David Fuhrmann [Sun, 26 May 2013 15:12:45 +0000 (17:12 +0200)]
auhal: restart aout only if necessary (fixes #8556)

This commit fixes multiple regressions introduced in
2b0891bbb3ccc17d12ae7f79bb012382996693d2.

7 years agoContribs: fix building libbluray 0.3.0 for Windows
Jean-Baptiste Kempf [Sun, 26 May 2013 10:08:34 +0000 (12:08 +0200)]
Contribs: fix building libbluray 0.3.0 for Windows

7 years agosmf: cosmetics
Rémi Denis-Courmont [Sat, 25 May 2013 19:36:07 +0000 (22:36 +0300)]
smf: cosmetics

7 years agovout_ios2: remove debug
Felix Paul Kühne [Sat, 25 May 2013 16:15:59 +0000 (18:15 +0200)]
vout_ios2: remove debug

7 years agoRedistribute omxil/OMX_Broadcom.h
Nicolas Chauvet [Sat, 25 May 2013 15:33:03 +0000 (17:33 +0200)]
Redistribute omxil/OMX_Broadcom.h

Signed-off-by: Rémi Denis-Courmont <remi@remlab.net>
7 years agovout: separate scale and autoscale callbacks
Rémi Denis-Courmont [Sat, 25 May 2013 08:56:48 +0000 (11:56 +0300)]
vout: separate scale and autoscale callbacks

7 years agozoom is a float
Rémi Denis-Courmont [Sat, 25 May 2013 08:07:24 +0000 (11:07 +0300)]
zoom is a float

7 years agovout: unused parameter
Rémi Denis-Courmont [Sat, 25 May 2013 07:57:37 +0000 (10:57 +0300)]
vout: unused parameter

7 years agoQt4: unused parameter
Rémi Denis-Courmont [Sat, 25 May 2013 07:56:20 +0000 (10:56 +0300)]
Qt4: unused parameter

7 years agorawdv: fix unused function
Rémi Denis-Courmont [Sat, 25 May 2013 07:55:03 +0000 (10:55 +0300)]
rawdv: fix unused function

7 years agoQt4: missing parentheses
Rémi Denis-Courmont [Sat, 25 May 2013 07:49:28 +0000 (10:49 +0300)]
Qt4: missing parentheses

7 years agoavodec: unused variable
Rémi Denis-Courmont [Sat, 25 May 2013 07:49:18 +0000 (10:49 +0300)]
avodec: unused variable

7 years agoFix warning with automake 1.12
Rémi Denis-Courmont [Sat, 25 May 2013 07:38:52 +0000 (10:38 +0300)]
Fix warning with automake 1.12

7 years agonsis: refuse to run on Windows < XP SP2
Rafaël Carré [Sat, 25 May 2013 01:11:37 +0000 (03:11 +0200)]
nsis: refuse to run on Windows < XP SP2

7 years agomsi: fix symlink
Rafaël Carré [Sat, 25 May 2013 01:10:15 +0000 (03:10 +0200)]
msi: fix symlink

7 years agoALSA: remove non-forward compatible assertion (fixes #8692)
Rémi Denis-Courmont [Fri, 24 May 2013 19:10:19 +0000 (22:10 +0300)]
ALSA: remove non-forward compatible assertion (fixes #8692)

7 years agoavcodec: handle leftover samples properly
Ilkka Ollakka [Thu, 23 May 2013 19:42:14 +0000 (22:42 +0300)]
avcodec: handle leftover samples properly

Don't mess up deinterleaving if there is leftover-samples and keep
leftover samples in interleaved format. Fixes #8570

7 years agomacosx: adapt to new stereo-mode text
David Fuhrmann [Thu, 23 May 2013 16:50:18 +0000 (18:50 +0200)]
macosx: adapt to new stereo-mode text

7 years agorevert text for stereo-mode
David Fuhrmann [Thu, 23 May 2013 16:49:40 +0000 (18:49 +0200)]
revert text for stereo-mode

7 years agoskins2: fix mouse cursor shape change and mouse cursor position on OS/2
KO Myung-Hun [Sun, 12 May 2013 08:33:29 +0000 (17:33 +0900)]
skins2: fix mouse cursor shape change and mouse cursor position on OS/2

Signed-off-by: Rafaël Carré <funman@videolan.org>
7 years agoAdd -lm for audiobargraph_v
Jean-Baptiste Kempf [Thu, 23 May 2013 10:51:46 +0000 (12:51 +0200)]
Add -lm for audiobargraph_v

7 years agoAudioBar: display the bars in dBFS according to IEC 268-18 standard
Ramon Gabarró [Tue, 21 May 2013 17:19:23 +0000 (19:19 +0200)]
AudioBar: display the bars in dBFS according to IEC 268-18 standard

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>
7 years agofaad: cosmetic
Rémi Denis-Courmont [Wed, 22 May 2013 17:24:54 +0000 (20:24 +0300)]
faad: cosmetic

7 years agoaout: remove legacy HAVE_FPU checks
Rémi Denis-Courmont [Wed, 22 May 2013 17:23:12 +0000 (20:23 +0300)]
aout: remove legacy HAVE_FPU checks

The new audio filter API deals with these cases automatically.

7 years agoskins2: add OS/2 support
KO Myung-Hun [Fri, 17 May 2013 08:39:08 +0000 (17:39 +0900)]
skins2: add OS/2 support

Signed-off-by: Rafaël Carré <funman@videolan.org>
7 years agoALSA: fix typo leading to a NULL dereference
Rémi Denis-Courmont [Wed, 22 May 2013 15:50:02 +0000 (18:50 +0300)]
ALSA: fix typo leading to a NULL dereference

7 years agovout_macosx: add error messages on failure
David Fuhrmann [Tue, 21 May 2013 19:47:31 +0000 (21:47 +0200)]
vout_macosx: add error messages on failure

7 years agogrowl: fix crash when trying to read null object (fixes #8659)
David Fuhrmann [Tue, 21 May 2013 19:23:40 +0000 (21:23 +0200)]
growl: fix crash when trying to read null object (fixes #8659)

7 years agoFix text for stereo-mode variable
David Fuhrmann [Thu, 16 May 2013 20:13:54 +0000 (22:13 +0200)]
Fix text for stereo-mode variable

The text needs to be always set, as its used by the GUI.

7 years agoWinstore app: don't use GetModuleFileName
Rafaël Carré [Tue, 21 May 2013 13:05:55 +0000 (15:05 +0200)]
Winstore app: don't use GetModuleFileName

7 years agomux/mpeg/ts.c: correct typo
Jean-Paul Saman [Tue, 21 May 2013 08:08:57 +0000 (10:08 +0200)]
mux/mpeg/ts.c: correct typo

Never do a last minute refactoring of common parts without a build test.
Fix a typo in dvbpsi_compat.h header and ts-muxer for the move to libdvbpsi >= 1.0.0.

7 years agoHLS: resolve relative URLs (/a/b/../c -> /a/c)
Rafaël Carré [Mon, 20 May 2013 23:09:34 +0000 (01:09 +0200)]
HLS: resolve relative URLs (/a/b/../c -> /a/c)

7 years agovout_ios2: minor code optimization
Felix Paul Kühne [Mon, 20 May 2013 18:44:53 +0000 (20:44 +0200)]
vout_ios2: minor code optimization

7 years agomacosx/SPMediaKeyTap: update list of collaborating apps (close #8644)
Felix Paul Kühne [Mon, 20 May 2013 17:34:04 +0000 (19:34 +0200)]
macosx/SPMediaKeyTap: update list of collaborating apps (close #8644)

7 years agoQt: Seek/SoundSlider: handle hijacked released mouse state (fix #8583)
Francois Cartegnie [Sat, 18 May 2013 11:36:53 +0000 (13:36 +0200)]
Qt: Seek/SoundSlider: handle hijacked released mouse state (fix #8583)

7 years agoiOS: enable fribidi, libxml and libass
Jean-Baptiste Kempf [Sun, 19 May 2013 10:24:10 +0000 (12:24 +0200)]
iOS: enable fribidi, libxml and libass

7 years agoContribs: correctly compile libass for iOS
Jean-Baptiste Kempf [Sun, 19 May 2013 10:23:41 +0000 (12:23 +0200)]
Contribs: correctly compile libass for iOS

7 years agoios: enable freetype
Felix Paul Kühne [Thu, 2 May 2013 19:30:35 +0000 (20:30 +0100)]
ios: enable freetype

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>
7 years agofreetype: fixed compilation for non-Mac darwin platforms
Felix Paul Kühne [Thu, 2 May 2013 21:23:14 +0000 (22:23 +0100)]
freetype: fixed compilation for non-Mac darwin platforms

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>
7 years agoFix potential crash when sending notification to deallocated object
Gleb Pinigin [Fri, 17 May 2013 16:13:06 +0000 (23:13 +0700)]
Fix potential crash when sending notification to deallocated object

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>
7 years agoios_vout2: fix crash when trying to draw OpenGL changes while the app is in the backg...
Felix Paul Kühne [Thu, 28 Mar 2013 11:34:46 +0000 (12:34 +0100)]
ios_vout2: fix crash when trying to draw OpenGL changes while the app is in the background

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>
7 years agoiOS: more building fixes
Jean-Baptiste Kempf [Sun, 19 May 2013 08:53:50 +0000 (10:53 +0200)]
iOS: more building fixes

7 years agoiOS: try to build armv7 and armv7s contribs without clashing
Jean-Baptiste Kempf [Sat, 18 May 2013 17:28:17 +0000 (19:28 +0200)]
iOS: try to build armv7 and armv7s contribs without clashing

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>
7 years agoAvcodec: map ICOD
Jean-Baptiste Kempf [Sat, 18 May 2013 15:38:45 +0000 (17:38 +0200)]
Avcodec: map ICOD

Close #5567

7 years agoIntroduce ICOD fourCC
Jean-Baptiste Kempf [Sat, 18 May 2013 15:34:50 +0000 (17:34 +0200)]
Introduce ICOD fourCC

Ref #5567

7 years agomacosx: fix build script
Felix Paul Kühne [Sat, 18 May 2013 17:00:58 +0000 (19:00 +0200)]
macosx: fix build script

7 years agoQt: improve ToolsBar if run as a dialogProvider
Erwan Tulou [Sat, 18 May 2013 13:17:05 +0000 (15:17 +0200)]
Qt: improve ToolsBar if run as a dialogProvider

The "Customize Interface" menu entry is not relevant if qt4 is solely
run as a dialog provider.

7 years agoQt: add entries in the popupmenu for lua extensions (dialog provider only)
Erwan Tulou [Sat, 18 May 2013 13:21:42 +0000 (15:21 +0200)]
Qt: add entries in the popupmenu for lua extensions (dialog provider only)

7 years agoQt: make the extensionsManager also available for qt4 as a dialog provider.
Erwan Tulou [Sat, 18 May 2013 13:39:27 +0000 (15:39 +0200)]
Qt: make the extensionsManager also available for qt4 as a dialog provider.

7 years agoReduce iOS.m priority
Jean-Baptiste Kempf [Sat, 18 May 2013 12:54:51 +0000 (14:54 +0200)]
Reduce iOS.m priority

7 years agoQt: SimplePreferences: Don't use QButtonGroup (fix #8609)
Francois Cartegnie [Sat, 18 May 2013 12:40:52 +0000 (14:40 +0200)]
Qt: SimplePreferences: Don't use QButtonGroup (fix #8609)

7 years agoWin32: use ld options rather than a perl script to set PE flags
Rafaël Carré [Sat, 18 May 2013 11:05:17 +0000 (13:05 +0200)]
Win32: use ld options rather than a perl script to set PE flags

7 years agomacosx: bump plist version to avoid exceptions when upgrading from 2.0.x or 2.1-git
Felix Paul Kühne [Fri, 17 May 2013 21:19:36 +0000 (23:19 +0200)]
macosx: bump plist version to avoid exceptions when upgrading from 2.0.x or 2.1-git

No explicit settings performed by the user are affected, so most won't notice except for reset window positions