Revert "configure: Do not use -no-undefined with sanitizers on darwin"
authorMarvin Scholz <epirat07@gmail.com>
Thu, 5 Oct 2017 17:12:32 +0000 (19:12 +0200)
committerMarvin Scholz <epirat07@gmail.com>
Fri, 6 Oct 2017 13:28:14 +0000 (15:28 +0200)
This reverts commit 76118f582697ef0776f87ca6d69c4048a3fefe02.

It turns out this is actually an issue with libtool, cleaning the flags
when in link mode and removing the sanitizer flag.

It was fixed in libtool a5c6466528c060cc4660ad0319c00740db0e42ba
but there was no release since this fix.

configure.ac
lib/Makefile.am
modules/audio_output/Makefile.am
modules/common.am
modules/hw/vdpau/Makefile.am
modules/video_output/Makefile.am
src/Makefile.am

index b4b731a..9057500 100644 (file)
@@ -1136,12 +1136,6 @@ AC_CACHE_CHECK([if linker supports -z,defs], [ac_cv_ld_z_defs], [
 ])
 AS_IF([test "${ac_cv_ld_z_defs}" = "no" -o "${with_sanitizer}" != "no"], [VLC_RESTORE_FLAGS])
 
-AM_COND_IF([HAVE_DARWIN], [], [
-  AS_IF([test "${with_sanitizer}" = "no"], [
-    AC_SUBST([LDFLAGS_no_undefined], [-no-undefined])
-  ])
-])
-
 dnl Check for __attribute__((packed))
 AC_CACHE_CHECK([for __attribute__((packed))],
   [ac_cv_c_attribute_packed],
index f0060e1..59571d8 100644 (file)
@@ -60,7 +60,7 @@ libvlc_la_LIBADD = \
        ../src/libvlccore.la ../compat/libcompat.la $(LIBPTHREAD) $(LIBM)
 libvlc_la_LDFLAGS = \
        $(LDFLAGS_libvlc) \
-       $(LDFLAGS_no_undefined) \
+       -no-undefined \
        -version-info 10:0:5 \
        -export-symbols $(srcdir)/libvlc.sym
 libvlc_la_DEPENDENCIES = libvlc.sym
index 9080083..4cffed5 100644 (file)
@@ -42,7 +42,7 @@ libvlc_pulse_la_CPPFLAGS = -DMODULE_STRING=\"pulse\"
 libvlc_pulse_la_CFLAGS = $(AM_CFLAGS) $(PULSE_CFLAGS)
 libvlc_pulse_la_LIBADD = $(PULSE_LIBS) $(LTLIBVLCCORE)
 libvlc_pulse_la_LDFLAGS = \
-       $(LDFLAGS_no_undefined) \
+       -no-undefined \
        -export-symbols-regex ^vlc_pa_ \
        -version-info 0:0:0
 libpulse_plugin_la_SOURCES = audio_output/pulse.c
index 97ff8f2..7d3ce16 100644 (file)
@@ -30,7 +30,7 @@ AM_LDFLAGS = \
        -avoid-version -module \
        -export-symbols-regex ^vlc_entry \
        -shrext $(LIBEXT) \
-       $(LDFLAGS_no_undefined) \
+       -no-undefined \
        $(top_builddir)/compat/libcompat.la $(LTLIBVLCCORE) 
 if HAVE_WIN32
 AM_LDFLAGS += $(top_builddir)/modules/module.rc.lo -Wc,-static
index 6164b88..0c527cf 100644 (file)
@@ -5,7 +5,7 @@ libvlc_vdpau_la_CFLAGS = $(VDPAU_CFLAGS)
 libvlc_vdpau_la_LIBADD = $(X_LIBS) $(X_PRE_LIBS) -lX11 \
        $(LIBDL) $(LIBPTHREAD)
 libvlc_vdpau_la_LDFLAGS = \
-       $(LDFLAGS_no_undefined) \
+       -no-undefined \
        -export-symbols-regex ^vdp_ \
        -version-info 0:0:0
 
index 166edde..b778249 100644 (file)
@@ -114,7 +114,7 @@ libvlc_xcb_events_la_SOURCES = \
 libvlc_xcb_events_la_CPPFLAGS = -DMODULE_STRING=\"xcb\"
 libvlc_xcb_events_la_CFLAGS = $(AM_CFLAGS) $(XCB_CFLAGS)
 libvlc_xcb_events_la_LDFLAGS = \
-       $(LDFLAGS_no_undefined) \
+       -no-undefined \
        -export-symbols-regex ^vlc_xcb_ \
        -version-info 0:0:0
 libvlc_xcb_events_la_LIBADD = $(XCB_LIBS) $(LTLIBVLCCORE)
index 42b6235..87ea540 100644 (file)
@@ -462,7 +462,7 @@ endif
 
 libvlccore_la_LDFLAGS = \
        $(LDFLAGS_libvlccore) \
-       $(LDFLAGS_no_undefined) \
+       -no-undefined \
        -export-symbols $(srcdir)/libvlccore.sym \
        -version-info 8:0:0
 libvlccore_la_DEPENDENCIES = libvlccore.sym