contrib/growl: Add growl patch that comments out logging
authorMarvin Scholz <epirat07@gmail.com>
Fri, 16 Oct 2015 16:42:23 +0000 (18:42 +0200)
committerFelix Paul Kühne <fkuehne@videolan.org>
Sat, 17 Oct 2015 20:10:41 +0000 (22:10 +0200)
The patch comments out logging which causes a warning log message
when setting the growl bridge delegate to nil. This is a problem,
as we need to set it to nil, so that the growl bridge will release
our delegate. Else it will never be released and dealloc will
not get called.

Signed-off-by: Felix Paul Kühne <fkuehne@videolan.org>
contrib/src/growl/growl-log-delegate.patch [new file with mode: 0644]
contrib/src/growl/rules.mak

diff --git a/contrib/src/growl/growl-log-delegate.patch b/contrib/src/growl/growl-log-delegate.patch
new file mode 100644 (file)
index 0000000..869e8db
--- /dev/null
@@ -0,0 +1,14 @@
+diff -ru growl/Framework/Source/GrowlApplicationBridge.m growl-patched/Framework/Source/GrowlApplicationBridge.m
+--- growl/Framework/Source/GrowlApplicationBridge.m    2011-05-25 04:10:27.000000000 +0200
++++ growl-patched/Framework/Source/GrowlApplicationBridge.m    2015-10-15 15:26:27.000000000 +0200
+@@ -398,8 +398,8 @@
+       NSDictionary *registrationDictionary = [self registrationDictionaryFromDelegate];
+       if (!registrationDictionary) {
+               registrationDictionary = [self registrationDictionaryFromBundle:nil];
+-              if (!registrationDictionary)
+-                      NSLog(@"GrowlApplicationBridge: The Growl delegate did not supply a registration dictionary, and the app bundle at %@ does not have one. Please tell this application's developer.", [[NSBundle mainBundle] bundlePath]);
++              //if (!registrationDictionary)
++                      //NSLog(@"GrowlApplicationBridge: The Growl delegate did not supply a registration dictionary, and the app bundle at %@ does not have one. Please tell this application's developer.", [[NSBundle mainBundle] bundlePath]);
+       }
+       return [self registrationDictionaryByFillingInDictionary:registrationDictionary];
index ddc0159..3e6dabb 100644 (file)
@@ -16,6 +16,7 @@ growl: growl-$(GROWL_VERSION).tar.bz2 .sum-growl
        $(UNPACK)
        mv Growl-1.2.2-src growl-1.2.2
        $(APPLY) $(SRC)/growl/growl-xcode5.patch
+       $(APPLY) $(SRC)/growl/growl-log-delegate.patch
        sed -i.orig -e s/"REVISION \$$REV"/"REVISION 0x\$$REV"/g growl-1.2.2/generateHgRevision.sh
        $(MOVE)