* ALL: separation of the SPU engine from the VOUT.
[vlc.git] / src / video_output / video_output.c
1 /*****************************************************************************
2  * video_output.c : video output thread
3  * This module describes the programming interface for video output threads.
4  * It includes functions allowing to open a new thread, send pictures to a
5  * thread, and destroy a previously oppened video output thread.
6  *****************************************************************************
7  * Copyright (C) 2000-2004 VideoLAN
8  * $Id$
9  *
10  * Authors: Vincent Seguin <seguin@via.ecp.fr>
11  *
12  * This program is free software; you can redistribute it and/or modify
13  * it under the terms of the GNU General Public License as published by
14  * the Free Software Foundation; either version 2 of the License, or
15  * (at your option) any later version.
16  *
17  * This program is distributed in the hope that it will be useful,
18  * but WITHOUT ANY WARRANTY; without even the implied warranty of
19  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
20  * GNU General Public License for more details.
21  *
22  * You should have received a copy of the GNU General Public License
23  * along with this program; if not, write to the Free Software
24  * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA  02111, USA.
25  *****************************************************************************/
26
27 /*****************************************************************************
28  * Preamble
29  *****************************************************************************/
30 #include <stdlib.h>                                                /* free() */
31
32 #include <vlc/vlc.h>
33
34 #ifdef HAVE_SYS_TIMES_H
35 #   include <sys/times.h>
36 #endif
37
38 #include "vlc_video.h"
39 #include "video_output.h"
40 #include "vlc_spu.h"
41 #include <vlc/input.h>                 /* for input_thread_t and i_pts_delay */
42
43 #if defined( SYS_DARWIN )
44 #include "darwin_specific.h"
45 #endif
46
47 /*****************************************************************************
48  * Local prototypes
49  *****************************************************************************/
50 static int      InitThread        ( vout_thread_t * );
51 static void     RunThread         ( vout_thread_t * );
52 static void     ErrorThread       ( vout_thread_t * );
53 static void     EndThread         ( vout_thread_t * );
54 static void     DestroyThread     ( vout_thread_t * );
55
56 static void     AspectRatio       ( int, int *, int * );
57 static int      BinaryLog         ( uint32_t );
58 static void     MaskToShift       ( int *, int *, uint32_t );
59 static void     InitWindowSize    ( vout_thread_t *, int *, int * );
60
61 /* Object variables callbacks */
62 static int DeinterlaceCallback( vlc_object_t *, char const *,
63                                 vlc_value_t, vlc_value_t, void * );
64 static int FilterCallback( vlc_object_t *, char const *,
65                            vlc_value_t, vlc_value_t, void * );
66
67 /*****************************************************************************
68  * vout_Request: find a video output thread, create one, or destroy one.
69  *****************************************************************************
70  * This function looks for a video output thread matching the current
71  * properties. If not found, it spawns a new one.
72  *****************************************************************************/
73 vout_thread_t * __vout_Request ( vlc_object_t *p_this, vout_thread_t *p_vout,
74                                  unsigned int i_width, unsigned int i_height,
75                                  vlc_fourcc_t i_chroma, unsigned int i_aspect )
76 {
77     if( !i_width || !i_height || !i_chroma )
78     {
79         /* Reattach video output to input before bailing out */
80         if( p_vout )
81         {
82             vlc_object_t *p_playlist;
83
84             p_playlist = vlc_object_find( p_this, VLC_OBJECT_PLAYLIST,
85                                           FIND_ANYWHERE );
86
87             if( p_playlist )
88             {
89                 spu_Attach( p_vout->p_spu, p_this, VLC_FALSE );
90                 vlc_object_detach( p_vout );
91                 vlc_object_attach( p_vout, p_playlist );
92
93                 vlc_object_release( p_playlist );
94             }
95             else
96             {
97                 msg_Dbg( p_this, "cannot find playlist, destroying vout" );
98                 vlc_object_detach( p_vout );
99                 vout_Destroy( p_vout );
100             }
101         }
102         return NULL;
103     }
104
105     /* If a video output was provided, lock it, otherwise look for one. */
106     if( p_vout )
107     {
108         vlc_object_yield( p_vout );
109     }
110     else
111     {
112         p_vout = vlc_object_find( p_this, VLC_OBJECT_VOUT, FIND_CHILD );
113
114         if( !p_vout )
115         {
116             vlc_object_t *p_playlist;
117
118             p_playlist = vlc_object_find( p_this,
119                                           VLC_OBJECT_PLAYLIST, FIND_ANYWHERE );
120             if( p_playlist )
121             {
122                 p_vout = vlc_object_find( p_playlist,
123                                           VLC_OBJECT_VOUT, FIND_CHILD );
124                 /* only first children of p_input for unused vout */
125                 if( p_vout && p_vout->p_parent != p_playlist )
126                 {
127                     vlc_object_release( p_vout );
128                     p_vout = NULL;
129                 }
130                 vlc_object_release( p_playlist );
131             }
132         }
133     }
134
135     /* If we now have a video output, check it has the right properties */
136     if( p_vout )
137     {
138         char *psz_filter_chain;
139
140         /* We don't directly check for the "filter" variable for obvious
141          * performance reasons. */
142         if( p_vout->b_filter_change )
143         {
144             psz_filter_chain = config_GetPsz( p_this, "filter" );
145
146             if( psz_filter_chain && !*psz_filter_chain )
147             {
148                 free( psz_filter_chain );
149                 psz_filter_chain = NULL;
150             }
151             if( p_vout->psz_filter_chain && !*p_vout->psz_filter_chain )
152             {
153                 free( p_vout->psz_filter_chain );
154                 p_vout->psz_filter_chain = NULL;
155             }
156
157             if( ( !psz_filter_chain && !p_vout->psz_filter_chain ) ||
158                 ( psz_filter_chain && p_vout->psz_filter_chain &&
159                   !strcmp( psz_filter_chain, p_vout->psz_filter_chain ) ) )
160             {
161                 p_vout->b_filter_change = VLC_FALSE;
162             }
163
164             if( psz_filter_chain ) free( psz_filter_chain );
165         }
166
167         if( ( p_vout->render.i_width != i_width ) ||
168             ( p_vout->render.i_height != i_height ) ||
169             ( p_vout->render.i_chroma != i_chroma ) ||
170             ( p_vout->render.i_aspect != i_aspect
171                     && !p_vout->b_override_aspect ) ||
172             p_vout->b_filter_change )
173         {
174             /* We are not interested in this format, close this vout */
175             vlc_object_detach( p_vout );
176             vlc_object_release( p_vout );
177             vout_Destroy( p_vout );
178             p_vout = NULL;
179         }
180         else
181         {
182             /* This video output is cool! Hijack it. */
183             vlc_object_detach( p_vout );
184             spu_Attach( p_vout->p_spu, p_this, VLC_TRUE );
185             vlc_object_attach( p_vout, p_this );
186             vlc_object_release( p_vout );
187         }
188     }
189
190     if( !p_vout )
191     {
192         msg_Dbg( p_this, "no usable vout present, spawning one" );
193
194         p_vout = vout_Create( p_this, i_width, i_height, i_chroma, i_aspect );
195     }
196
197     return p_vout;
198 }
199
200 /*****************************************************************************
201  * vout_Create: creates a new video output thread
202  *****************************************************************************
203  * This function creates a new video output thread, and returns a pointer
204  * to its description. On error, it returns NULL.
205  *****************************************************************************/
206 vout_thread_t * __vout_Create( vlc_object_t *p_parent,
207                                unsigned int i_width, unsigned int i_height,
208                                vlc_fourcc_t i_chroma, unsigned int i_aspect )
209 {
210     vout_thread_t  * p_vout;                            /* thread descriptor */
211     input_thread_t * p_input_thread;
212     int              i_index;                               /* loop variable */
213     char           * psz_plugin;
214     vlc_value_t      val, text;
215
216     /* Allocate descriptor */
217     p_vout = vlc_object_create( p_parent, VLC_OBJECT_VOUT );
218     if( p_vout == NULL )
219     {
220         msg_Err( p_parent, "out of memory" );
221         return NULL;
222     }
223
224     /* Initialize pictures - translation tables and functions
225      * will be initialized later in InitThread */
226     for( i_index = 0; i_index < 2 * VOUT_MAX_PICTURES + 1; i_index++)
227     {
228         p_vout->p_picture[i_index].pf_lock = NULL;
229         p_vout->p_picture[i_index].pf_unlock = NULL;
230         p_vout->p_picture[i_index].i_status = FREE_PICTURE;
231         p_vout->p_picture[i_index].i_type   = EMPTY_PICTURE;
232         p_vout->p_picture[i_index].b_slow   = 0;
233     }
234
235     /* No images in the heap */
236     p_vout->i_heap_size = 0;
237
238     /* Initialize the rendering heap */
239     I_RENDERPICTURES = 0;
240     p_vout->render.i_width    = i_width;
241     p_vout->render.i_height   = i_height;
242     p_vout->render.i_chroma   = i_chroma;
243     p_vout->render.i_aspect   = i_aspect;
244
245     p_vout->render.i_rmask    = 0;
246     p_vout->render.i_gmask    = 0;
247     p_vout->render.i_bmask    = 0;
248
249     p_vout->render.i_last_used_pic = -1;
250     p_vout->render.b_allow_modify_pics = 1;
251
252     /* Zero the output heap */
253     I_OUTPUTPICTURES = 0;
254     p_vout->output.i_width    = 0;
255     p_vout->output.i_height   = 0;
256     p_vout->output.i_chroma   = 0;
257     p_vout->output.i_aspect   = 0;
258
259     p_vout->output.i_rmask    = 0;
260     p_vout->output.i_gmask    = 0;
261     p_vout->output.i_bmask    = 0;
262
263     /* Initialize misc stuff */
264     p_vout->i_changes    = 0;
265     p_vout->f_gamma      = 0;
266     p_vout->b_grayscale  = 0;
267     p_vout->b_info       = 0;
268     p_vout->b_interface  = 0;
269     p_vout->b_scale      = 1;
270     p_vout->b_fullscreen = 0;
271     p_vout->i_alignment  = 0;
272     p_vout->render_time  = 10;
273     p_vout->c_fps_samples = 0;
274     p_vout->b_filter_change = 0;
275     p_vout->pf_control = 0;
276     p_vout->p_parent_intf = 0;
277
278     /* Initialize locks */
279     vlc_mutex_init( p_vout, &p_vout->picture_lock );
280     vlc_mutex_init( p_vout, &p_vout->change_lock );
281
282     /* Mouse coordinates */
283     var_Create( p_vout, "mouse-x", VLC_VAR_INTEGER );
284     var_Create( p_vout, "mouse-y", VLC_VAR_INTEGER );
285     var_Create( p_vout, "mouse-button-down", VLC_VAR_INTEGER );
286     var_Create( p_vout, "mouse-moved", VLC_VAR_BOOL );
287     var_Create( p_vout, "mouse-clicked", VLC_VAR_INTEGER );
288
289     /* Initialize subpicture unit */
290     p_vout->p_spu = spu_Init( p_vout );
291     spu_Attach( p_vout->p_spu, p_parent, VLC_TRUE );
292
293     /* Attach the new object now so we can use var inheritance below */
294     vlc_object_attach( p_vout, p_parent );
295
296     /* Take care of some "interface/control" related initialisations */
297     vout_IntfInit( p_vout );
298
299     p_vout->b_override_aspect = VLC_FALSE;
300
301     /* If the parent is not a VOUT object, that means we are at the start of
302      * the video output pipe */
303     if( p_parent->i_object_type != VLC_OBJECT_VOUT )
304     {
305         var_Get( p_vout, "aspect-ratio", &val );
306
307         /* Check whether the user tried to override aspect ratio */
308         if( val.psz_string )
309         {
310             unsigned int i_new_aspect = i_aspect;
311             char *psz_parser = strchr( val.psz_string, ':' );
312
313             if( psz_parser )
314             {
315                 *psz_parser++ = '\0';
316                 i_new_aspect = atoi( val.psz_string ) * VOUT_ASPECT_FACTOR
317                                                       / atoi( psz_parser );
318             }
319             else
320             {
321                 i_new_aspect = i_width * VOUT_ASPECT_FACTOR
322                                        * atof( val.psz_string )
323                                        / i_height;
324             }
325
326             free( val.psz_string );
327
328             if( i_new_aspect && i_new_aspect != i_aspect )
329             {
330                 int i_aspect_x, i_aspect_y;
331
332                 AspectRatio( i_new_aspect, &i_aspect_x, &i_aspect_y );
333
334                 msg_Dbg( p_vout, "overriding source aspect ratio to %i:%i",
335                          i_aspect_x, i_aspect_y );
336
337                 p_vout->render.i_aspect = i_new_aspect;
338
339                 p_vout->b_override_aspect = VLC_TRUE;
340             }
341         }
342
343         /* Look for the default filter configuration */
344         var_Create( p_vout, "filter", VLC_VAR_STRING | VLC_VAR_DOINHERIT );
345         var_Get( p_vout, "filter", &val );
346         p_vout->psz_filter_chain = val.psz_string;
347     }
348     else
349     {
350         /* continue the parent's filter chain */
351         char *psz_end;
352
353         psz_end = strchr( ((vout_thread_t *)p_parent)->psz_filter_chain, ':' );
354         if( psz_end && *(psz_end+1) )
355             p_vout->psz_filter_chain = strdup( psz_end+1 );
356         else p_vout->psz_filter_chain = NULL;
357     }
358
359     /* Choose the video output module */
360     if( !p_vout->psz_filter_chain || !*p_vout->psz_filter_chain )
361     {
362         var_Create( p_vout, "vout", VLC_VAR_STRING | VLC_VAR_DOINHERIT );
363         var_Get( p_vout, "vout", &val );
364         psz_plugin = val.psz_string;
365     }
366     else
367     {
368         /* the filter chain is a string list of filters separated by double
369          * colons */
370         char *psz_end;
371
372         psz_end = strchr( p_vout->psz_filter_chain, ':' );
373         if( psz_end )
374             psz_plugin = strndup( p_vout->psz_filter_chain,
375                                   psz_end - p_vout->psz_filter_chain );
376         else psz_plugin = strdup( p_vout->psz_filter_chain );
377     }
378
379     /* Initialize the dimensions of the video window */
380     InitWindowSize( p_vout, &p_vout->i_window_width,
381                     &p_vout->i_window_height );
382
383     /* Create the vout thread */
384     p_vout->p_module = module_Need( p_vout,
385         ( p_vout->psz_filter_chain && *p_vout->psz_filter_chain ) ?
386         "video filter" : "video output", psz_plugin, 0 );
387
388     if( psz_plugin ) free( psz_plugin );
389     if( p_vout->p_module == NULL )
390     {
391         msg_Err( p_vout, "no suitable vout module" );
392         vlc_object_detach( p_vout );
393         vlc_object_destroy( p_vout );
394         return NULL;
395     }
396
397     /* Create a few object variables for interface interaction */
398     var_Create( p_vout, "deinterlace", VLC_VAR_STRING | VLC_VAR_HASCHOICE );
399     text.psz_string = _("Deinterlace");
400     var_Change( p_vout, "deinterlace", VLC_VAR_SETTEXT, &text, NULL );
401     val.psz_string = ""; text.psz_string = _("Disable");
402     var_Change( p_vout, "deinterlace", VLC_VAR_ADDCHOICE, &val, &text );
403     val.psz_string = "discard"; text.psz_string = _("Discard");
404     var_Change( p_vout, "deinterlace", VLC_VAR_ADDCHOICE, &val, &text );
405     val.psz_string = "blend"; text.psz_string = _("Blend");
406     var_Change( p_vout, "deinterlace", VLC_VAR_ADDCHOICE, &val, &text );
407     val.psz_string = "mean"; text.psz_string = _("Mean");
408     var_Change( p_vout, "deinterlace", VLC_VAR_ADDCHOICE, &val, &text );
409     val.psz_string = "bob"; text.psz_string = _("Bob");
410     var_Change( p_vout, "deinterlace", VLC_VAR_ADDCHOICE, &val, &text );
411     val.psz_string = "linear"; text.psz_string = _("Linear");
412     var_Change( p_vout, "deinterlace", VLC_VAR_ADDCHOICE, &val, &text );
413     if( var_Get( p_vout, "deinterlace-mode", &val ) == VLC_SUCCESS )
414     {
415         var_Set( p_vout, "deinterlace", val );
416         if( val.psz_string ) free( val.psz_string );
417     }
418     var_AddCallback( p_vout, "deinterlace", DeinterlaceCallback, NULL );
419
420
421     var_Create( p_vout, "filter", VLC_VAR_STRING );
422     text.psz_string = _("Filters");
423     var_Change( p_vout, "filter", VLC_VAR_SETTEXT, &text, NULL );
424     var_Change( p_vout, "filter", VLC_VAR_INHERITVALUE, &val, NULL );
425     if( val.psz_string )
426     {
427         var_Set( p_vout, "filter", val );
428         free( val.psz_string );
429     }
430     var_AddCallback( p_vout, "filter", FilterCallback, NULL );
431
432     /* Calculate delay created by internal caching */
433     p_input_thread = (input_thread_t *)vlc_object_find( p_vout,
434                                            VLC_OBJECT_INPUT, FIND_ANYWHERE );
435     if( p_input_thread )
436     {
437         p_vout->i_pts_delay = p_input_thread->i_pts_delay;
438         vlc_object_release( p_input_thread );
439     }
440     else
441     {
442         p_vout->i_pts_delay = DEFAULT_PTS_DELAY;
443     }
444
445     if( vlc_thread_create( p_vout, "video output", RunThread,
446                            VLC_THREAD_PRIORITY_OUTPUT, VLC_TRUE ) )
447     {
448         msg_Err( p_vout, "out of memory" );
449         module_Unneed( p_vout, p_vout->p_module );
450         vlc_object_detach( p_vout );
451         vlc_object_destroy( p_vout );
452         return NULL;
453     }
454
455     if( p_vout->b_error )
456     {
457         msg_Err( p_vout, "video output creation failed" );
458
459         /* Make sure the thread is destroyed */
460         p_vout->b_die = VLC_TRUE;
461
462         vlc_thread_join( p_vout );
463
464         vlc_object_detach( p_vout );
465         vlc_object_destroy( p_vout );
466         return NULL;
467     }
468
469     return p_vout;
470 }
471
472 /*****************************************************************************
473  * vout_Destroy: destroys a previously created video output
474  *****************************************************************************
475  * Destroy a terminated thread.
476  * The function will request a destruction of the specified thread. If pi_error
477  * is NULL, it will return once the thread is destroyed. Else, it will be
478  * update using one of the THREAD_* constants.
479  *****************************************************************************/
480 void vout_Destroy( vout_thread_t *p_vout )
481 {
482     vlc_object_t *p_playlist;
483
484     /* Request thread destruction */
485     p_vout->b_die = VLC_TRUE;
486     vlc_thread_join( p_vout );
487
488     var_Destroy( p_vout, "intf-change" );
489
490     p_playlist = vlc_object_find( p_vout, VLC_OBJECT_PLAYLIST,
491                                   FIND_ANYWHERE );
492
493     if( p_vout->psz_filter_chain ) free( p_vout->psz_filter_chain );
494
495     /* Free structure */
496     vlc_object_destroy( p_vout );
497
498     /* If it was the last vout, tell the interface to show up */
499     if( p_playlist != NULL )
500     {
501         vout_thread_t *p_another_vout = vlc_object_find( p_playlist,
502                                             VLC_OBJECT_VOUT, FIND_ANYWHERE );
503         if( p_another_vout == NULL )
504         {
505             vlc_value_t val;
506             val.b_bool = VLC_TRUE;
507             var_Set( p_playlist, "intf-show", val );
508         }
509         else
510         {
511             vlc_object_release( p_another_vout );
512         }
513         vlc_object_release( p_playlist );
514     }
515 }
516
517 /*****************************************************************************
518  * InitThread: initialize video output thread
519  *****************************************************************************
520  * This function is called from RunThread and performs the second step of the
521  * initialization. It returns 0 on success. Note that the thread's flag are not
522  * modified inside this function.
523  *****************************************************************************/
524 static int InitThread( vout_thread_t *p_vout )
525 {
526     int i, i_aspect_x, i_aspect_y;
527
528     vlc_mutex_lock( &p_vout->change_lock );
529
530 #ifdef STATS
531     p_vout->c_loops = 0;
532 #endif
533
534     /* Initialize output method, it allocates direct buffers for us */
535     if( p_vout->pf_init( p_vout ) )
536     {
537         vlc_mutex_unlock( &p_vout->change_lock );
538         return VLC_EGENERIC;
539     }
540
541     if( !I_OUTPUTPICTURES )
542     {
543         msg_Err( p_vout, "plugin was unable to allocate at least "
544                          "one direct buffer" );
545         p_vout->pf_end( p_vout );
546         vlc_mutex_unlock( &p_vout->change_lock );
547         return VLC_EGENERIC;
548     }
549
550     if( I_OUTPUTPICTURES > VOUT_MAX_PICTURES )
551     {
552         msg_Err( p_vout, "plugin allocated too many direct buffers, "
553                          "our internal buffers must have overflown." );
554         p_vout->pf_end( p_vout );
555         vlc_mutex_unlock( &p_vout->change_lock );
556         return VLC_EGENERIC;
557     }
558
559     msg_Dbg( p_vout, "got %i direct buffer(s)", I_OUTPUTPICTURES );
560
561 #if 0
562     if( !p_vout->psz_filter_chain )
563     {
564         char *psz_aspect = config_GetPsz( p_vout, "pixel-ratio" );
565
566         if( psz_aspect )
567         {
568             int i_new_aspect = p_vout->output.i_width * VOUT_ASPECT_FACTOR
569                                                       * atof( psz_aspect )
570                                                       / p_vout->output.i_height;
571             free( psz_aspect );
572
573             if( i_new_aspect && i_new_aspect != p_vout->output.i_aspect )
574             {
575                 AspectRatio( i_new_aspect, &i_aspect_x, &i_aspect_y );
576
577                 msg_Dbg( p_vout, "output ratio forced to %i:%i\n",
578                          i_aspect_x, i_aspect_y );
579                 p_vout->output.i_aspect = i_new_aspect;
580             }
581         }
582     }
583 #endif
584
585     AspectRatio( p_vout->render.i_aspect, &i_aspect_x, &i_aspect_y );
586     msg_Dbg( p_vout,
587              "picture in %ix%i, chroma 0x%.8x (%4.4s), aspect ratio %i:%i",
588              p_vout->render.i_width, p_vout->render.i_height,
589              p_vout->render.i_chroma, (char*)&p_vout->render.i_chroma,
590              i_aspect_x, i_aspect_y );
591
592     AspectRatio( p_vout->output.i_aspect, &i_aspect_x, &i_aspect_y );
593     msg_Dbg( p_vout,
594              "picture out %ix%i, chroma 0x%.8x (%4.4s), aspect ratio %i:%i",
595              p_vout->output.i_width, p_vout->output.i_height,
596              p_vout->output.i_chroma, (char*)&p_vout->output.i_chroma,
597              i_aspect_x, i_aspect_y );
598
599     /* Calculate shifts from system-updated masks */
600     MaskToShift( &p_vout->output.i_lrshift, &p_vout->output.i_rrshift,
601                  p_vout->output.i_rmask );
602     MaskToShift( &p_vout->output.i_lgshift, &p_vout->output.i_rgshift,
603                  p_vout->output.i_gmask );
604     MaskToShift( &p_vout->output.i_lbshift, &p_vout->output.i_rbshift,
605                  p_vout->output.i_bmask );
606
607     /* Check whether we managed to create direct buffers similar to
608      * the render buffers, ie same size and chroma */
609     if( ( p_vout->output.i_width == p_vout->render.i_width )
610      && ( p_vout->output.i_height == p_vout->render.i_height )
611      && ( vout_ChromaCmp( p_vout->output.i_chroma, p_vout->render.i_chroma ) ) )
612     {
613         /* Cool ! We have direct buffers, we can ask the decoder to
614          * directly decode into them ! Map the first render buffers to
615          * the first direct buffers, but keep the first direct buffer
616          * for memcpy operations */
617         p_vout->b_direct = 1;
618
619         for( i = 1; i < VOUT_MAX_PICTURES; i++ )
620         {
621             if( p_vout->p_picture[ i ].i_type != DIRECT_PICTURE &&
622                 I_RENDERPICTURES >= VOUT_MIN_DIRECT_PICTURES - 1 &&
623                 p_vout->p_picture[ i - 1 ].i_type == DIRECT_PICTURE )
624             {
625                 /* We have enough direct buffers so there's no need to
626                  * try to use system memory buffers. */
627                 break;
628             }
629             PP_RENDERPICTURE[ I_RENDERPICTURES ] = &p_vout->p_picture[ i ];
630             I_RENDERPICTURES++;
631         }
632
633         msg_Dbg( p_vout, "direct render, mapping "
634                  "render pictures 0-%i to system pictures 1-%i",
635                  VOUT_MAX_PICTURES - 2, VOUT_MAX_PICTURES - 1 );
636     }
637     else
638     {
639         /* Rats... Something is wrong here, we could not find an output
640          * plugin able to directly render what we decode. See if we can
641          * find a chroma plugin to do the conversion */
642         p_vout->b_direct = 0;
643
644         /* Choose the best module */
645         p_vout->chroma.p_module = module_Need( p_vout, "chroma", NULL, 0 );
646
647         if( p_vout->chroma.p_module == NULL )
648         {
649             msg_Err( p_vout, "no chroma module for %4.4s to %4.4s",
650                      (char*)&p_vout->render.i_chroma,
651                      (char*)&p_vout->output.i_chroma );
652             p_vout->pf_end( p_vout );
653             vlc_mutex_unlock( &p_vout->change_lock );
654             return VLC_EGENERIC;
655         }
656
657         msg_Dbg( p_vout, "indirect render, mapping "
658                  "render pictures 0-%i to system pictures %i-%i",
659                  VOUT_MAX_PICTURES - 1, I_OUTPUTPICTURES,
660                  I_OUTPUTPICTURES + VOUT_MAX_PICTURES - 1 );
661
662         /* Append render buffers after the direct buffers */
663         for( i = I_OUTPUTPICTURES; i < 2 * VOUT_MAX_PICTURES; i++ )
664         {
665             PP_RENDERPICTURE[ I_RENDERPICTURES ] = &p_vout->p_picture[ i ];
666             I_RENDERPICTURES++;
667
668             /* Check if we have enough render pictures */
669             if( I_RENDERPICTURES == VOUT_MAX_PICTURES )
670                 break;
671         }
672     }
673
674     /* Link pictures back to their heap */
675     for( i = 0 ; i < I_RENDERPICTURES ; i++ )
676     {
677         PP_RENDERPICTURE[ i ]->p_heap = &p_vout->render;
678     }
679
680     for( i = 0 ; i < I_OUTPUTPICTURES ; i++ )
681     {
682         PP_OUTPUTPICTURE[ i ]->p_heap = &p_vout->output;
683     }
684
685 /* XXX XXX mark thread ready */
686     return VLC_SUCCESS;
687 }
688
689 /*****************************************************************************
690  * RunThread: video output thread
691  *****************************************************************************
692  * Video output thread. This function does only returns when the thread is
693  * terminated. It handles the pictures arriving in the video heap and the
694  * display device events.
695  *****************************************************************************/
696 static void RunThread( vout_thread_t *p_vout)
697 {
698     int             i_index;                                /* index in heap */
699     int             i_idle_loops = 0;  /* loops without displaying a picture */
700     mtime_t         current_date;                            /* current date */
701     mtime_t         display_date;                            /* display date */
702
703     picture_t *     p_picture;                            /* picture pointer */
704     picture_t *     p_last_picture = NULL;                   /* last picture */
705     picture_t *     p_directbuffer;              /* direct buffer to display */
706
707     subpicture_t *  p_subpic;                          /* subpicture pointer */
708
709     /*
710      * Initialize thread
711      */
712     p_vout->b_error = InitThread( p_vout );
713
714     /* signal the creation of the vout */
715     vlc_thread_ready( p_vout );
716
717     if( p_vout->b_error )
718     {
719         /* Destroy thread structures allocated by Create and InitThread */
720         DestroyThread( p_vout );
721         return;
722     }
723
724     /*
725      * Main loop - it is not executed if an error occurred during
726      * initialization
727      */
728     while( (!p_vout->b_die) && (!p_vout->b_error) )
729     {
730         /* Initialize loop variables */
731         p_picture = NULL;
732         display_date = 0;
733         current_date = mdate();
734
735 #if 0
736         p_vout->c_loops++;
737         if( !(p_vout->c_loops % VOUT_STATS_NB_LOOPS) )
738         {
739             msg_Dbg( p_vout, "picture heap: %d/%d",
740                      I_RENDERPICTURES, p_vout->i_heap_size );
741         }
742 #endif
743
744         /*
745          * Find the picture to display (the one with the earliest date).
746          * This operation does not need lock, since only READY_PICTUREs
747          * are handled. */
748         for( i_index = 0; i_index < I_RENDERPICTURES; i_index++ )
749         {
750             if( (PP_RENDERPICTURE[i_index]->i_status == READY_PICTURE)
751                 && ( (p_picture == NULL) ||
752                      (PP_RENDERPICTURE[i_index]->date < display_date) ) )
753             {
754                 p_picture = PP_RENDERPICTURE[i_index];
755                 display_date = p_picture->date;
756             }
757         }
758
759         if( p_picture )
760         {
761             /* If we met the last picture, parse again to see whether there is
762              * a more appropriate one. */
763             if( p_picture == p_last_picture )
764             {
765                 for( i_index = 0; i_index < I_RENDERPICTURES; i_index++ )
766                 {
767                     if( (PP_RENDERPICTURE[i_index]->i_status == READY_PICTURE)
768                         && (PP_RENDERPICTURE[i_index] != p_last_picture)
769                         && ((p_picture == p_last_picture) ||
770                             (PP_RENDERPICTURE[i_index]->date < display_date)) )
771                     {
772                         p_picture = PP_RENDERPICTURE[i_index];
773                         display_date = p_picture->date;
774                     }
775                 }
776             }
777
778             /* If we found better than the last picture, destroy it */
779             if( p_last_picture && p_picture != p_last_picture )
780             {
781                 vlc_mutex_lock( &p_vout->picture_lock );
782                 if( p_last_picture->i_refcount )
783                 {
784                     p_last_picture->i_status = DISPLAYED_PICTURE;
785                 }
786                 else
787                 {
788                     p_last_picture->i_status = DESTROYED_PICTURE;
789                     p_vout->i_heap_size--;
790                 }
791                 vlc_mutex_unlock( &p_vout->picture_lock );
792                 p_last_picture = NULL;
793             }
794
795             /* Compute FPS rate */
796             p_vout->p_fps_sample[ p_vout->c_fps_samples++ % VOUT_FPS_SAMPLES ]
797                 = display_date;
798
799             if( !p_picture->b_force &&
800                 p_picture != p_last_picture &&
801                 display_date < current_date + p_vout->render_time )
802             {
803                 /* Picture is late: it will be destroyed and the thread
804                  * will directly choose the next picture */
805                 vlc_mutex_lock( &p_vout->picture_lock );
806                 if( p_picture->i_refcount )
807                 {
808                     /* Pretend we displayed the picture, but don't destroy
809                      * it since the decoder might still need it. */
810                     p_picture->i_status = DISPLAYED_PICTURE;
811                 }
812                 else
813                 {
814                     /* Destroy the picture without displaying it */
815                     p_picture->i_status = DESTROYED_PICTURE;
816                     p_vout->i_heap_size--;
817                 }
818                 msg_Warn( p_vout, "late picture skipped ("I64Fd")",
819                                   current_date - display_date );
820                 vlc_mutex_unlock( &p_vout->picture_lock );
821
822                 continue;
823             }
824
825             if( display_date >
826                 current_date + p_vout->i_pts_delay + VOUT_BOGUS_DELAY )
827             {
828                 /* Picture is waaay too early: it will be destroyed */
829                 vlc_mutex_lock( &p_vout->picture_lock );
830                 if( p_picture->i_refcount )
831                 {
832                     /* Pretend we displayed the picture, but don't destroy
833                      * it since the decoder might still need it. */
834                     p_picture->i_status = DISPLAYED_PICTURE;
835                 }
836                 else
837                 {
838                     /* Destroy the picture without displaying it */
839                     p_picture->i_status = DESTROYED_PICTURE;
840                     p_vout->i_heap_size--;
841                 }
842                 msg_Warn( p_vout, "vout warning: early picture skipped "
843                           "("I64Fd")", display_date - current_date
844                           - p_vout->i_pts_delay );
845                 vlc_mutex_unlock( &p_vout->picture_lock );
846
847                 continue;
848             }
849
850             if( display_date > current_date + VOUT_DISPLAY_DELAY )
851             {
852                 /* A picture is ready to be rendered, but its rendering date
853                  * is far from the current one so the thread will perform an
854                  * empty loop as if no picture were found. The picture state
855                  * is unchanged */
856                 p_picture    = NULL;
857                 display_date = 0;
858             }
859             else if( p_picture == p_last_picture )
860             {
861                 /* We are asked to repeat the previous picture, but we first
862                  * wait for a couple of idle loops */
863                 if( i_idle_loops < 4 )
864                 {
865                     p_picture    = NULL;
866                     display_date = 0;
867                 }
868                 else
869                 {
870                     /* We set the display date to something high, otherwise
871                      * we'll have lots of problems with late pictures */
872                     display_date = current_date + p_vout->render_time;
873                 }
874             }
875         }
876
877         if( p_picture == NULL )
878         {
879             i_idle_loops++;
880         }
881
882         /*
883          * Check for subpictures to display
884          */
885         p_subpic = spu_SortSubpictures( p_vout->p_spu, display_date );
886
887         /*
888          * Perform rendering
889          */
890         p_directbuffer = vout_RenderPicture( p_vout, p_picture, p_subpic );
891
892         /*
893          * Call the plugin-specific rendering method if there is one
894          */
895         if( p_picture != NULL && p_directbuffer != NULL && p_vout->pf_render )
896         {
897             /* Render the direct buffer returned by vout_RenderPicture */
898             p_vout->pf_render( p_vout, p_directbuffer );
899         }
900
901         /*
902          * Sleep, wake up
903          */
904         if( display_date != 0 && p_directbuffer != NULL )
905         {
906             mtime_t current_render_time = mdate() - current_date;
907             /* if render time is very large we don't include it in the mean */
908             if( current_render_time < p_vout->render_time +
909                 VOUT_DISPLAY_DELAY )
910             {
911                 /* Store render time using a sliding mean weighting to
912                  * current value in a 3 to 1 ratio*/
913                 p_vout->render_time *= 3;
914                 p_vout->render_time += current_render_time;
915                 p_vout->render_time >>= 2;
916             }
917         }
918
919         /* Give back change lock */
920         vlc_mutex_unlock( &p_vout->change_lock );
921
922         /* Sleep a while or until a given date */
923         if( display_date != 0 )
924         {
925             /* If there are filters in the chain, better give them the picture
926              * in advance */
927             if( !p_vout->psz_filter_chain || !*p_vout->psz_filter_chain )
928             {
929                 mwait( display_date - VOUT_MWAIT_TOLERANCE );
930             }
931         }
932         else
933         {
934             msleep( VOUT_IDLE_SLEEP );
935         }
936
937         /* On awakening, take back lock and send immediately picture
938          * to display. */
939         vlc_mutex_lock( &p_vout->change_lock );
940
941         /*
942          * Display the previously rendered picture
943          */
944         if( p_picture != NULL && p_directbuffer != NULL )
945         {
946             /* Display the direct buffer returned by vout_RenderPicture */
947             if( p_vout->pf_display )
948             {
949                 p_vout->pf_display( p_vout, p_directbuffer );
950             }
951
952             /* Tell the vout this was the last picture and that it does not
953              * need to be forced anymore. */
954             p_last_picture = p_picture;
955             p_last_picture->b_force = 0;
956         }
957
958         if( p_picture != NULL )
959         {
960             /* Reinitialize idle loop count */
961             i_idle_loops = 0;
962         }
963
964         /*
965          * Check events and manage thread
966          */
967         if( p_vout->pf_manage && p_vout->pf_manage( p_vout ) )
968         {
969             /* A fatal error occurred, and the thread must terminate
970              * immediately, without displaying anything - setting b_error to 1
971              * causes the immediate end of the main while() loop. */
972             p_vout->b_error = 1;
973         }
974
975         if( p_vout->i_changes & VOUT_SIZE_CHANGE )
976         {
977             /* this must only happen when the vout plugin is incapable of
978              * rescaling the picture itself. In this case we need to destroy
979              * the current picture buffers and recreate new ones with the right
980              * dimensions */
981             int i;
982
983             p_vout->i_changes &= ~VOUT_SIZE_CHANGE;
984
985             p_vout->pf_end( p_vout );
986             for( i = 0; i < I_OUTPUTPICTURES; i++ )
987                  p_vout->p_picture[ i ].i_status = FREE_PICTURE;
988
989             I_OUTPUTPICTURES = 0;
990             if( p_vout->pf_init( p_vout ) )
991             {
992                 msg_Err( p_vout, "cannot resize display" );
993                 /* FIXME: pf_end will be called again in EndThread() */
994                 p_vout->b_error = 1;
995             }
996
997             /* Need to reinitialise the chroma plugin */
998             if( p_vout->chroma.p_module )
999             {
1000                 if( p_vout->chroma.p_module->pf_deactivate )
1001                     p_vout->chroma.p_module->pf_deactivate( VLC_OBJECT(p_vout) );
1002                 p_vout->chroma.p_module->pf_activate( VLC_OBJECT(p_vout) );
1003             }
1004         }
1005
1006         if( p_vout->i_changes & VOUT_PICTURE_BUFFERS_CHANGE )
1007         {
1008             /* This happens when the picture buffers need to be recreated.
1009              * This is useful on multimonitor displays for instance.
1010              *
1011              * Warning: This only works when the vout creates only 1 picture
1012              * buffer!! */
1013             p_vout->i_changes &= ~VOUT_PICTURE_BUFFERS_CHANGE;
1014
1015             if( !p_vout->b_direct )
1016             {
1017                 module_Unneed( p_vout, p_vout->chroma.p_module );
1018             }
1019
1020             vlc_mutex_lock( &p_vout->picture_lock );
1021
1022             p_vout->pf_end( p_vout );
1023
1024             I_OUTPUTPICTURES = I_RENDERPICTURES = 0;
1025
1026             p_vout->b_error = InitThread( p_vout );
1027
1028             vlc_mutex_unlock( &p_vout->picture_lock );
1029         }
1030     }
1031
1032     /*
1033      * Error loop - wait until the thread destruction is requested
1034      */
1035     if( p_vout->b_error )
1036     {
1037         ErrorThread( p_vout );
1038     }
1039
1040     /* End of thread */
1041     EndThread( p_vout );
1042
1043     /* Destroy thread structures allocated by CreateThread */
1044     DestroyThread( p_vout );
1045 }
1046
1047 /*****************************************************************************
1048  * ErrorThread: RunThread() error loop
1049  *****************************************************************************
1050  * This function is called when an error occurred during thread main's loop.
1051  * The thread can still receive feed, but must be ready to terminate as soon
1052  * as possible.
1053  *****************************************************************************/
1054 static void ErrorThread( vout_thread_t *p_vout )
1055 {
1056     /* Wait until a `die' order */
1057     while( !p_vout->b_die )
1058     {
1059         /* Sleep a while */
1060         msleep( VOUT_IDLE_SLEEP );
1061     }
1062 }
1063
1064 /*****************************************************************************
1065  * EndThread: thread destruction
1066  *****************************************************************************
1067  * This function is called when the thread ends after a sucessful
1068  * initialization. It frees all resources allocated by InitThread.
1069  *****************************************************************************/
1070 static void EndThread( vout_thread_t *p_vout )
1071 {
1072     int     i_index;                                        /* index in heap */
1073
1074 #ifdef STATS
1075     {
1076         struct tms cpu_usage;
1077         times( &cpu_usage );
1078
1079         msg_Dbg( p_vout, "cpu usage (user: %d, system: %d)",
1080                  cpu_usage.tms_utime, cpu_usage.tms_stime );
1081     }
1082 #endif
1083
1084     if( !p_vout->b_direct )
1085     {
1086         module_Unneed( p_vout, p_vout->chroma.p_module );
1087     }
1088
1089     /* Destroy all remaining pictures */
1090     for( i_index = 0; i_index < 2 * VOUT_MAX_PICTURES + 1; i_index++ )
1091     {
1092         if ( p_vout->p_picture[i_index].i_type == MEMORY_PICTURE )
1093         {
1094             free( p_vout->p_picture[i_index].p_data_orig );
1095         }
1096     }
1097
1098     /* Destroy subpicture unit */
1099     spu_Attach( p_vout->p_spu, VLC_OBJECT(p_vout), VLC_FALSE );
1100     spu_Destroy( p_vout->p_spu );
1101
1102     /* Destroy translation tables */
1103     p_vout->pf_end( p_vout );
1104
1105     /* Release the change lock */
1106     vlc_mutex_unlock( &p_vout->change_lock );
1107 }
1108
1109 /*****************************************************************************
1110  * DestroyThread: thread destruction
1111  *****************************************************************************
1112  * This function is called when the thread ends. It frees all ressources
1113  * allocated by CreateThread. Status is available at this stage.
1114  *****************************************************************************/
1115 static void DestroyThread( vout_thread_t *p_vout )
1116 {
1117     /* Destroy the locks */
1118     vlc_mutex_destroy( &p_vout->picture_lock );
1119     vlc_mutex_destroy( &p_vout->change_lock );
1120
1121     /* Release the module */
1122     if( p_vout && p_vout->p_module )
1123     {
1124         module_Unneed( p_vout, p_vout->p_module );
1125     }
1126 }
1127
1128 /* following functions are local */
1129
1130 static int ReduceHeight( int i_ratio )
1131 {
1132     int i_dummy = VOUT_ASPECT_FACTOR;
1133     int i_pgcd  = 1;
1134
1135     if( !i_ratio )
1136     {
1137         return i_pgcd;
1138     }
1139
1140     /* VOUT_ASPECT_FACTOR is (2^7 * 3^3 * 5^3), we just check for 2, 3 and 5 */
1141     while( !(i_ratio & 1) && !(i_dummy & 1) )
1142     {
1143         i_ratio >>= 1;
1144         i_dummy >>= 1;
1145         i_pgcd  <<= 1;
1146     }
1147
1148     while( !(i_ratio % 3) && !(i_dummy % 3) )
1149     {
1150         i_ratio /= 3;
1151         i_dummy /= 3;
1152         i_pgcd  *= 3;
1153     }
1154
1155     while( !(i_ratio % 5) && !(i_dummy % 5) )
1156     {
1157         i_ratio /= 5;
1158         i_dummy /= 5;
1159         i_pgcd  *= 5;
1160     }
1161
1162     return i_pgcd;
1163 }
1164
1165 static void AspectRatio( int i_aspect, int *i_aspect_x, int *i_aspect_y )
1166 {
1167     unsigned int i_pgcd = ReduceHeight( i_aspect );
1168     *i_aspect_x = i_aspect / i_pgcd;
1169     *i_aspect_y = VOUT_ASPECT_FACTOR / i_pgcd;
1170 }
1171
1172 /*****************************************************************************
1173  * BinaryLog: computes the base 2 log of a binary value
1174  *****************************************************************************
1175  * This functions is used by MaskToShift, to get a bit index from a binary
1176  * value.
1177  *****************************************************************************/
1178 static int BinaryLog( uint32_t i )
1179 {
1180     int i_log = 0;
1181
1182     if( i == 0 ) return -31337;
1183
1184     if( i & 0xffff0000 ) i_log += 16;
1185     if( i & 0xff00ff00 ) i_log += 8;
1186     if( i & 0xf0f0f0f0 ) i_log += 4;
1187     if( i & 0xcccccccc ) i_log += 2;
1188     if( i & 0xaaaaaaaa ) i_log += 1;
1189
1190     return i_log;
1191 }
1192
1193 /*****************************************************************************
1194  * MaskToShift: transform a color mask into right and left shifts
1195  *****************************************************************************
1196  * This function is used for obtaining color shifts from masks.
1197  *****************************************************************************/
1198 static void MaskToShift( int *pi_left, int *pi_right, uint32_t i_mask )
1199 {
1200     uint32_t i_low, i_high;            /* lower hand higher bits of the mask */
1201
1202     if( !i_mask )
1203     {
1204         *pi_left = *pi_right = 0;
1205         return;
1206     }
1207
1208     /* Get bits */
1209     i_low =  i_mask & (- (int32_t)i_mask);          /* lower bit of the mask */
1210     i_high = i_mask + i_low;                       /* higher bit of the mask */
1211
1212     /* Transform bits into an index */
1213     i_low =  BinaryLog (i_low);
1214     i_high = BinaryLog (i_high);
1215
1216     /* Update pointers and return */
1217     *pi_left =   i_low;
1218     *pi_right = (8 - i_high + i_low);
1219 }
1220
1221 /*****************************************************************************
1222  * InitWindowSize: find the initial dimensions the video window should have.
1223  *****************************************************************************
1224  * This function will check the "width", "height" and "zoom" config options and
1225  * will calculate the size that the video window should have.
1226  *****************************************************************************/
1227 static void InitWindowSize( vout_thread_t *p_vout, int *pi_width,
1228                             int *pi_height )
1229 {
1230     vlc_value_t val;
1231     int i_width, i_height;
1232     uint64_t ll_zoom;
1233
1234 #define FP_FACTOR 1000                             /* our fixed point factor */
1235
1236     var_Get( p_vout, "align", &val );
1237     p_vout->i_alignment = val.i_int;
1238
1239     var_Get( p_vout, "width", &val );
1240     i_width = val.i_int;
1241     var_Get( p_vout, "height", &val );
1242     i_height = val.i_int;
1243     var_Get( p_vout, "zoom", &val );
1244     ll_zoom = (uint64_t)( FP_FACTOR * val.f_float );
1245
1246     if( i_width > 0 && i_height > 0)
1247     {
1248         *pi_width = (int)( i_width * ll_zoom / FP_FACTOR );
1249         *pi_height = (int)( i_height * ll_zoom / FP_FACTOR );
1250         return;
1251     }
1252     else if( i_width > 0 )
1253     {
1254         *pi_width = (int)( i_width * ll_zoom / FP_FACTOR );
1255         *pi_height = (int)( i_width * ll_zoom * VOUT_ASPECT_FACTOR /
1256                             p_vout->render.i_aspect / FP_FACTOR );
1257         return;
1258     }
1259     else if( i_height > 0 )
1260     {
1261         *pi_height = (int)( i_height * ll_zoom / FP_FACTOR );
1262         *pi_width = (int)( i_height * ll_zoom * p_vout->render.i_aspect /
1263                            VOUT_ASPECT_FACTOR / FP_FACTOR );
1264         return;
1265     }
1266
1267     if( p_vout->render.i_height * p_vout->render.i_aspect
1268         >= p_vout->render.i_width * VOUT_ASPECT_FACTOR )
1269     {
1270         *pi_width = (int)( p_vout->render.i_height * ll_zoom
1271           * p_vout->render.i_aspect / VOUT_ASPECT_FACTOR / FP_FACTOR );
1272         *pi_height = (int)( p_vout->render.i_height * ll_zoom / FP_FACTOR );
1273     }
1274     else
1275     {
1276         *pi_width = (int)( p_vout->render.i_width * ll_zoom / FP_FACTOR );
1277         *pi_height = (int)( p_vout->render.i_width * ll_zoom
1278           * VOUT_ASPECT_FACTOR / p_vout->render.i_aspect / FP_FACTOR );
1279     }
1280
1281 #undef FP_FACTOR
1282 }
1283
1284 /*****************************************************************************
1285  * vout_VarCallback: generic callback for intf variables
1286  *****************************************************************************/
1287 int vout_VarCallback( vlc_object_t * p_this, const char * psz_variable,
1288                       vlc_value_t old_value, vlc_value_t new_value,
1289                       void * unused )
1290 {
1291     vout_thread_t * p_vout = (vout_thread_t *)p_this;
1292     vlc_value_t val;
1293     val.b_bool = VLC_TRUE;
1294     var_Set( p_vout, "intf-change", val );
1295     return VLC_SUCCESS;
1296 }
1297
1298 /*****************************************************************************
1299  * object variables callbacks: a bunch of object variables are used by the
1300  * interfaces to interact with the vout.
1301  *****************************************************************************/
1302 static int DeinterlaceCallback( vlc_object_t *p_this, char const *psz_cmd,
1303                        vlc_value_t oldval, vlc_value_t newval, void *p_data )
1304 {
1305     vout_thread_t *p_vout = (vout_thread_t *)p_this;
1306     input_thread_t *p_input;
1307     vlc_value_t val;
1308
1309     char *psz_mode = newval.psz_string;
1310     char *psz_filter;
1311
1312     psz_filter = config_GetPsz( p_vout, "filter" );
1313
1314     if( !psz_mode || !*psz_mode )
1315     {
1316         config_PutPsz( p_vout, "filter", "" );
1317     }
1318     else
1319     {
1320         if( !psz_filter || !*psz_filter )
1321         {
1322             config_PutPsz( p_vout, "filter", "deinterlace" );
1323         }
1324         else
1325         {
1326             if( strstr( psz_filter, "deinterlace" ) == NULL )
1327             {
1328                 psz_filter = realloc( psz_filter, strlen( psz_filter ) + 20 );
1329                 strcat( psz_filter, ",deinterlace" );
1330             }
1331             config_PutPsz( p_vout, "filter", psz_filter );
1332         }
1333     }
1334
1335     if( psz_filter ) free( psz_filter );
1336
1337
1338     p_input = (input_thread_t *)vlc_object_find( p_this, VLC_OBJECT_INPUT,
1339                                                  FIND_PARENT );
1340     if( !p_input ) return VLC_EGENERIC;
1341
1342     if( psz_mode && *psz_mode )
1343     {
1344         val.psz_string = psz_mode;
1345         var_Set( p_vout, "deinterlace-mode", val );
1346         /* Modify input as well because the vout might have to be restarted */
1347         var_Create( p_input, "deinterlace-mode", VLC_VAR_STRING );
1348         var_Set( p_input, "deinterlace-mode", val );
1349     }
1350
1351     /* Now restart current video stream */
1352     var_Get( p_input, "video-es", &val );
1353     if( val.i_int >= 0 )
1354     {
1355         p_vout->b_filter_change = VLC_TRUE;
1356         var_Set( p_input, "video-es", (vlc_value_t)-VIDEO_ES );
1357         var_Set( p_input, "video-es", val );
1358     }
1359
1360     vlc_object_release( p_input );
1361
1362     val.b_bool = VLC_TRUE;
1363     var_Set( p_vout, "intf-change", val );
1364     return VLC_SUCCESS;
1365 }
1366
1367 static int FilterCallback( vlc_object_t *p_this, char const *psz_cmd,
1368                        vlc_value_t oldval, vlc_value_t newval, void *p_data )
1369 {
1370     vout_thread_t *p_vout = (vout_thread_t *)p_this;
1371     input_thread_t *p_input;
1372     vlc_value_t val;
1373
1374     p_input = (input_thread_t *)vlc_object_find( p_this, VLC_OBJECT_INPUT,
1375                                                  FIND_PARENT );
1376
1377     if (!p_input)
1378     {
1379         msg_Err( p_vout, "Input not found" );
1380         return( VLC_EGENERIC );
1381     }
1382
1383     /* Now restart current video stream */
1384     var_Get( p_input, "video-es", &val );
1385     if( val.i_int >= 0 )
1386     {
1387         p_vout->b_filter_change = VLC_TRUE;
1388         var_Set( p_input, "video-es", (vlc_value_t)-VIDEO_ES );
1389         var_Set( p_input, "video-es", val );
1390     }
1391
1392     vlc_object_release( p_input );
1393
1394     val.b_bool = VLC_TRUE;
1395     var_Set( p_vout, "intf-change", val );
1396     return VLC_SUCCESS;
1397 }