ffmpeg.git
8 months agodoc/ffmpeg: -timelimit is in user time
Lou Logan [Thu, 26 Sep 2019 18:18:57 +0000 (10:18 -0800)]
doc/ffmpeg: -timelimit is in user time

Signed-off-by: Lou Logan <lou@lrcd.com>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
8 months agoavcodec/nvenc: make use of new GetLastErrorString function
Timo Rothenpieler [Fri, 27 Sep 2019 17:09:11 +0000 (19:09 +0200)]
avcodec/nvenc: make use of new GetLastErrorString function

Signed-off-by: Timo Rothenpieler <timo@rothenpieler.org>
8 months agoavcodec/nvenc: pass CUstream to nvenc when available
Timo Rothenpieler [Fri, 27 Sep 2019 16:30:10 +0000 (18:30 +0200)]
avcodec/nvenc: pass CUstream to nvenc when available

Signed-off-by: Timo Rothenpieler <timo@rothenpieler.org>
8 months agoavcodec/nvenc: add multiple reference frames support
Roman Arzumanyan [Fri, 27 Sep 2019 15:56:11 +0000 (17:56 +0200)]
avcodec/nvenc: add multiple reference frames support

Signed-off-by: Timo Rothenpieler <timo@rothenpieler.org>
8 months agoavcodec/nvenc: switch to dedicated dpb_size option
Timo Rothenpieler [Fri, 27 Sep 2019 15:55:23 +0000 (17:55 +0200)]
avcodec/nvenc: switch to dedicated dpb_size option

Signed-off-by: Timo Rothenpieler <timo@rothenpieler.org>
8 months agolibavformat/rtsp: return error if rtsp_hd_out is null instead of crash
Ross Nicholson [Thu, 19 Sep 2019 15:12:33 +0000 (16:12 +0100)]
libavformat/rtsp: return error if rtsp_hd_out is null instead of crash

Signed-off-by: Aman Gupta <aman@tmm1.net>
8 months agolavu/qsv: remove redundant version query
Zhong Li [Thu, 19 Sep 2019 20:45:25 +0000 (04:45 +0800)]
lavu/qsv: remove redundant version query

Signed-off-by: Zhong Li <zhong.li@intel.com>
8 months agolavc/mpeg4audio: add chan_config check to avoid indeterminate channels
Jun Zhao [Sat, 21 Sep 2019 11:29:47 +0000 (19:29 +0800)]
lavc/mpeg4audio: add chan_config check to avoid indeterminate channels

add chan_config check to avoid indeterminate channels.

Signed-off-by: Jun Zhao <barryjzhao@tencent.com>
Signed-off-by: James Almer <jamrial@gmail.com>
8 months agoavcodec/mpeg4audio: fix doxy for ff_mpeg4audio_get_config_gb()
James Almer [Fri, 27 Sep 2019 13:43:36 +0000 (10:43 -0300)]
avcodec/mpeg4audio: fix doxy for ff_mpeg4audio_get_config_gb()

Signed-off-by: James Almer <jamrial@gmail.com>
8 months agoavformat: use avpriv_mpeg4audio_get_config2()
James Almer [Sat, 21 Sep 2019 23:06:48 +0000 (20:06 -0300)]
avformat: use avpriv_mpeg4audio_get_config2()

Signed-off-by: James Almer <jamrial@gmail.com>
8 months agoavcodec: use avpriv_mpeg4audio_get_config2()
James Almer [Sat, 21 Sep 2019 23:04:33 +0000 (20:04 -0300)]
avcodec: use avpriv_mpeg4audio_get_config2()

Signed-off-by: James Almer <jamrial@gmail.com>
8 months agoavcodec/mpeg4audio: add avpriv_mpeg4audio_get_config2()
James Almer [Sat, 21 Sep 2019 22:57:11 +0000 (19:57 -0300)]
avcodec/mpeg4audio: add avpriv_mpeg4audio_get_config2()

Identical to avpriv_mpeg4audio_get_config() except taking a size argument in
bytes, and featuring a new logging context paremeter.

Schedule avpriv_mpeg4audio_get_config() for removal as soon as major is bumped
as well.

Signed-off-by: James Almer <jamrial@gmail.com>
8 months agoavformat/dhav: fix demuxer since recent breakage
Paul B Mahol [Fri, 27 Sep 2019 12:25:18 +0000 (14:25 +0200)]
avformat/dhav: fix demuxer since recent breakage

8 months agoavformat/g729dec: set packet duration and correctly set timebase info
Paul B Mahol [Fri, 27 Sep 2019 10:38:23 +0000 (12:38 +0200)]
avformat/g729dec: set packet duration and correctly set timebase info

Fixes #6704.

8 months agoavformat/nut: add pcm_s64 support
Paul B Mahol [Fri, 27 Sep 2019 10:12:42 +0000 (12:12 +0200)]
avformat/nut: add pcm_s64 support

8 months agoswscale/swscale: cosmetics
Limin Wang [Thu, 26 Sep 2019 15:44:59 +0000 (23:44 +0800)]
swscale/swscale: cosmetics

Signed-off-by: Limin Wang <lance.lmwang@gmail.com>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
8 months agoavfilter/vf_scale: cosmetics
Limin Wang [Thu, 26 Sep 2019 15:36:54 +0000 (23:36 +0800)]
avfilter/vf_scale: cosmetics

Signed-off-by: Limin Wang <lance.lmwang@gmail.com>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
8 months agoavcodec/4xm: Check index in decode_i_block() also in the path where its not used.
Michael Niedermayer [Tue, 17 Sep 2019 17:53:45 +0000 (19:53 +0200)]
avcodec/4xm: Check index in decode_i_block() also in the path where its not used.

Fixes: Infinite loop
Fixes: signed integer overflow: 2147483644 + 16 cannot be represented in type 'int'
Fixes: 16169/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_FOURXM_fuzzer-5662570416963584
Fixes: 16782/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_FOURXM_fuzzer-5743163859271680
Fixes: 17641/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_FOURXM_fuzzer-5711603562971136

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Reviewed-by: Paul B Mahol <onemda@gmail.com>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
8 months agoavcodec/loco: Check for end of input in the first line
Michael Niedermayer [Wed, 25 Sep 2019 19:48:26 +0000 (21:48 +0200)]
avcodec/loco: Check for end of input in the first line

Fixes: Timeout (85sec -> 0.1sec)
Fixes: 17634/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_LOCO_fuzzer-5666410809786368

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Reviewed-by: Paul B Mahol <onemda@gmail.com>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
8 months agoavcodec/atrac3: Check block_align
Michael Niedermayer [Wed, 25 Sep 2019 18:51:22 +0000 (20:51 +0200)]
avcodec/atrac3: Check block_align

Fixes: Infinite loop
Fixes: 17620/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ATRAC3_fuzzer-5086123012915200

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Reviewed-by: Paul B Mahol <onemda@gmail.com>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
8 months agotools/target_dec_fuzzer: Print samples decoded like pixels
Michael Niedermayer [Wed, 25 Sep 2019 18:41:42 +0000 (20:41 +0200)]
tools/target_dec_fuzzer: Print samples decoded like pixels

Reviewed-by: Paul B Mahol <onemda@gmail.com>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
8 months agotools/target_dec_fuzzer: Check number of all samples decoded too, like max pixels
Michael Niedermayer [Wed, 25 Sep 2019 18:40:55 +0000 (20:40 +0200)]
tools/target_dec_fuzzer: Check number of all samples decoded too, like max pixels

Reviewed-by: Paul B Mahol <onemda@gmail.com>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
8 months agoavcodec/alsdec: Avoid dereferencing context pointer in inner interleave loop
Michael Niedermayer [Wed, 25 Sep 2019 18:31:50 +0000 (20:31 +0200)]
avcodec/alsdec: Avoid dereferencing context pointer in inner interleave loop

This makes the decoder faster

Improves/Fixes: Timeout (22sec -> 20sec)
Testcase: 17619/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ALS_fuzzer-5078510820917248

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Reviewed-by: Paul B Mahol <onemda@gmail.com>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
8 months agoavcodec/hcom: Check that there are dictionary entries
Michael Niedermayer [Wed, 25 Sep 2019 16:38:03 +0000 (18:38 +0200)]
avcodec/hcom: Check that there are dictionary entries

Fixes: out of array read
Fixes: 17617/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_HCOM_fuzzer-5674970478280704

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Reviewed-by: Paul B Mahol <onemda@gmail.com>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
8 months agoavcodec/fitsdec: Prevent division by 0 with huge data_max
Michael Niedermayer [Mon, 15 Jul 2019 21:42:42 +0000 (23:42 +0200)]
avcodec/fitsdec: Prevent division by 0 with huge data_max

Fixes: division by 0
Fixes: 15657/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_FITS_fuzzer-5738154838982656

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Reviewed-by: Paul B Mahol <onemda@gmail.com>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
8 months agoavcodec/dstdec: Fix integer overflow in samples_per_frame computation
Michael Niedermayer [Wed, 25 Sep 2019 14:48:46 +0000 (16:48 +0200)]
avcodec/dstdec: Fix integer overflow in samples_per_frame computation

Fixes: Timeout (? -> 2ms)
Fixes: 17616/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_DST_fuzzer-5198057947267072

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Reviewed-by: Paul B Mahol <onemda@gmail.com>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
8 months agoavcodec/g729_parser: Check block_size
Michael Niedermayer [Tue, 24 Sep 2019 23:07:34 +0000 (01:07 +0200)]
avcodec/g729_parser: Check block_size

Fixes: Infinite loop
Fixes: 17611/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ACELP_KELVIN_fuzzer-5765134928052224

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Reviewed-by: Paul B Mahol <onemda@gmail.com>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
8 months agoavcodec/sbcdec: Initialize number of channels
Michael Niedermayer [Tue, 24 Sep 2019 21:50:23 +0000 (23:50 +0200)]
avcodec/sbcdec: Initialize number of channels

Fixes: out of array access
Fixes: 17609/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_SBC_fuzzer-5758729319874560

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Reviewed-by: Paul B Mahol <onemda@gmail.com>
Reviewed-by: Moritz Barsnick <barsnick@gmx.net>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
8 months agoavcodec/exr: Fix undefined left shifts of negative numbers
Andreas Rheinhardt [Tue, 24 Sep 2019 22:03:07 +0000 (00:03 +0200)]
avcodec/exr: Fix undefined left shifts of negative numbers

Affected the FATE-tests exr-rgb-scanline-pxr24-half-uint32-13x9 and
exr-rgb-scanline-pxr24-uint32.

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
8 months agoaformat/movenc: add missing padding to output track extradata
James Almer [Wed, 25 Sep 2019 17:21:07 +0000 (14:21 -0300)]
aformat/movenc: add missing padding to output track extradata

Fixes ticket #8183.

Tested-by: Thierry Foucu <tfoucu@gmail.com>
Signed-off-by: James Almer <jamrial@gmail.com>
8 months agodoc/filters: warn about gaps/overlaps in xstack
Gyan Doshi [Thu, 26 Sep 2019 16:16:55 +0000 (21:46 +0530)]
doc/filters: warn about gaps/overlaps in xstack

8 months agodoc/filters: add 4x4 layout example for xstack filter
Limin Wang [Thu, 26 Sep 2019 14:57:42 +0000 (22:57 +0800)]
doc/filters: add 4x4 layout example for xstack filter

Add layouts for existing examples.

Reviewed-by: Gyan <ffmpeg@gyani.pro>
Signed-off-by: Limin Wang <lance.lmwang@gmail.com>
8 months agoavfilter/vf_eq: fix compilation with x86 asm disabled
James Almer [Thu, 26 Sep 2019 15:12:33 +0000 (12:12 -0300)]
avfilter/vf_eq: fix compilation with x86 asm disabled

Signed-off-by: James Almer <jamrial@gmail.com>
8 months agofate: update hashes after ya16 change
Paul B Mahol [Thu, 26 Sep 2019 14:59:14 +0000 (16:59 +0200)]
fate: update hashes after ya16 change

8 months agoswresample/audioconvert: fix invalid left shift for 64bit sample format
Paul B Mahol [Thu, 26 Sep 2019 14:19:06 +0000 (16:19 +0200)]
swresample/audioconvert: fix invalid left shift for 64bit sample format

Fixes #8002.

8 months agoavcodec/hevc_ps: Remove dead code in vps_id check
Andriy Gelman [Sun, 22 Sep 2019 04:17:29 +0000 (00:17 -0400)]
avcodec/hevc_ps: Remove dead code in vps_id check

Since reading 4 bits always returns a value in the range [0, 15], the
check for vps_id >= HEVC_MAX_VPS_COUNT, where HEVC_MAX_VPS_COUNT = 16, is redundant.

Signed-off-by: Andriy Gelman <andriy.gelman@gmail.com>
Signed-off-by: James Almer <jamrial@gmail.com>
8 months agoavcodec/truespeech: fix left shift of negative value
Paul B Mahol [Thu, 26 Sep 2019 14:03:33 +0000 (16:03 +0200)]
avcodec/truespeech: fix left shift of negative value

8 months agoswscale/output: fix signed integer overflow for ya16
Paul B Mahol [Thu, 26 Sep 2019 13:55:03 +0000 (15:55 +0200)]
swscale/output: fix signed integer overflow for ya16

Fixes #7666.

8 months agoavformat/movenc: Fix undefined shift
Andreas Rheinhardt [Thu, 19 Sep 2019 22:17:03 +0000 (00:17 +0200)]
avformat/movenc: Fix undefined shift

Fixes the movenc FATE-test.

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com>
8 months agoavcodec/mpeg12dec: Sanitize start codes earlier
Andreas Rheinhardt [Thu, 19 Sep 2019 22:16:57 +0000 (00:16 +0200)]
avcodec/mpeg12dec: Sanitize start codes earlier

The MPEG-1/2 decoder uses avpriv_find_start_code to search for start
codes and worked with the resulting start code before checking that it
is really a start code of a slice. In particular, if the picture is so
big that a slice_vertical_position_extension is present, it added the
slice_vertical_position_extension as if it had a slice. Then a left
shift is performed, without making sure that the value to be shifted is
nonnegative.
Afterwards the end result is checked, but even if a start code of a
non-slice has been found, it might pass these checks: If
slice_vertical_position_extension is present a start code <
SLICE_MIN_START_CODE can lead to a macroblock-row index that appears
valid. Furthermore, the left shift might make an invalid start code
appear valid by discarding the highest bit.
This has been fixed by checking directly after avpriv_find_start_code
has returned.

Fixes ticket #8162 (which is about the undefined left shifts).

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com>
8 months agoavcodec/pcm: Cosmetics
Andreas Rheinhardt [Thu, 19 Sep 2019 22:17:02 +0000 (00:17 +0200)]
avcodec/pcm: Cosmetics

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com>
8 months agoavcodec/pcm: Fix undefined shifts
Andreas Rheinhardt [Thu, 19 Sep 2019 22:17:01 +0000 (00:17 +0200)]
avcodec/pcm: Fix undefined shifts

Fixes the acodec-pcm-u16[lb]e FATE-tests.

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com>
8 months agoavcodec/wavpackenc: Fix undefined shifts
Andreas Rheinhardt [Thu, 19 Sep 2019 22:16:58 +0000 (00:16 +0200)]
avcodec/wavpackenc: Fix undefined shifts

Fixes ticket #8161 and the acodec-wavpack FATE-test.

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com>
8 months agolavc/qsv: add memory type message
Zhong Li [Thu, 19 Sep 2019 20:45:27 +0000 (04:45 +0800)]
lavc/qsv: add memory type message

Signed-off-by: Zhong Li <zhong.li@intel.com>
8 months agolavc/qsv: Fix MSDK initialization failure in system memory mode
Zhong Li [Thu, 19 Sep 2019 20:45:26 +0000 (04:45 +0800)]
lavc/qsv: Fix MSDK initialization failure in system memory mode

MSDK does not create internal acceleration device on Linux,
So MFXVideoCORE_SetHandle() is necessary.
It has been added for ff_qsv_init_session_device().
But missed for ff_qsv_init_internal_session() due to commit
1f26a23 overwrited commit db89f45

Fix #7030

Signed-off-by: Zhong Li <zhong.li@intel.com>
8 months agoavformat/utils: ensure that all packets in AVPacketList are reference counted
Andreas Rheinhardt [Thu, 26 Sep 2019 00:05:58 +0000 (02:05 +0200)]
avformat/utils: ensure that all packets in AVPacketList are reference counted

This is done so that its data is really owned by the packet.
This was already true for the current callers.

Signed-off-by: James Almer <jamrial@gmail.com>
8 months agoavfilter/x86/vf_eq: add SSE2 version
Ting Fu [Wed, 18 Sep 2019 07:05:35 +0000 (15:05 +0800)]
avfilter/x86/vf_eq: add SSE2 version

Signed-off-by: Ting Fu <ting.fu@intel.com>
8 months agoavfilter/x86/vf_eq: Change inline assembly into nasm code
Ting Fu [Wed, 18 Sep 2019 07:05:34 +0000 (15:05 +0800)]
avfilter/x86/vf_eq: Change inline assembly into nasm code

Signed-off-by: Ting Fu <ting.fu@intel.com>
8 months agocheckasm/vf_eq: add test for vf_eq
Ting Fu [Wed, 18 Sep 2019 07:05:33 +0000 (15:05 +0800)]
checkasm/vf_eq: add test for vf_eq

Signed-off-by: Ting Fu <ting.fu@intel.com>
Signed-off-by: Ruiling Song <ruiling.song@intel.com>
8 months agoavformat/utils: Move the reference to the packet list
Andreas Rheinhardt [Fri, 20 Sep 2019 20:39:10 +0000 (22:39 +0200)]
avformat/utils: Move the reference to the packet list

Up until now, ff_packet_list_put had a flaw: When it moved a packet to
the list (meaning, when it ought to move the reference to the packet
list instead of creating a new one via av_packet_ref), it did not reset
the original packet, confusing the ownership of the data in the packet.
This has been done because some callers of this function were not
compatible with resetting the packet.

This commit changes these callers and fixes this flaw. In order to
indicate that the ownership of the packet has moved to the packet list,
pointers to constant AVPackets are used whenever the target of the
pointer might already be owned by the packet list.

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com>
Signed-off-by: James Almer <jamrial@gmail.com>
8 months agoavformat/utils: unref packet on AVInputFormat.read_packet() failure
James Almer [Fri, 20 Sep 2019 20:39:09 +0000 (22:39 +0200)]
avformat/utils: unref packet on AVInputFormat.read_packet() failure

Demuxers may have allocated a packet before encountering an error and aborting.

Fixes ticket #8150

Signed-off-by: James Almer <jamrial@gmail.com>
8 months agoavformat/utils: Fix memleaks
Andreas Rheinhardt [Tue, 24 Sep 2019 16:31:44 +0000 (18:31 +0200)]
avformat/utils: Fix memleaks

ff_read_packet had potential memleaks:
1. If av_packet_make_refcounted fails, it means that the packet is not
refcounted, but it could nevertheless carry side data and therefore
needs to be unreferenced.
2. If putting a packet on a packet list fails, it wasn't unreferenced.

Furthermore, read_frame_internal leaked a packet's (side) data if a
context update was required and failed.

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com>
Signed-off-by: James Almer <jamrial@gmail.com>
8 months agoavformat/utils: Assert that stream_index is valid
Andreas Rheinhardt [Tue, 24 Sep 2019 16:31:43 +0000 (18:31 +0200)]
avformat/utils: Assert that stream_index is valid

There is currently an ordinary check for this (which would lead to a
memleak), but given that no demuxer should ever return a packet with an
invalid stream_index it is more appropriate for this to be an assert.

FATE passes with this change.

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com>
Signed-off-by: James Almer <jamrial@gmail.com>
8 months agolavf/mov: Fix timestamp rescale on sidx atom
Jun Li [Thu, 9 May 2019 09:07:56 +0000 (02:07 -0700)]
lavf/mov: Fix timestamp rescale on sidx atom

Fix #5090
Fix the timestamp rescale issue, from sidx timebase to
stream's timebase.

8 months agoRevert "lavc/tiff: correct the default value of YCbCrSubsampling to 2x2"
Carl Eugen Hoyos [Wed, 25 Sep 2019 22:34:44 +0000 (00:34 +0200)]
Revert "lavc/tiff: correct the default value of YCbCrSubsampling to 2x2"

This reverts commit eb5d0f18ff609ba2280cea4e2c6286d216c8756b.

Together with 89f464e9, it breaks decoding of tiff files like fate-suite/exif/image_small.tiff

8 months agoavcodec/dnxhdenc: return error if av_malloc failed
Limin Wang [Mon, 23 Sep 2019 03:36:18 +0000 (11:36 +0800)]
avcodec/dnxhdenc: return error if av_malloc failed

Signed-off-by: Limin Wang <lance.lmwang@gmail.com>
Signed-off-by: James Almer <jamrial@gmail.com>
8 months agoavfilter/vf_zoompan: fix leaks
Paul B Mahol [Wed, 25 Sep 2019 19:39:49 +0000 (21:39 +0200)]
avfilter/vf_zoompan: fix leaks

8 months agoavfilter/vf_zoompan: forward status back from output to input
Paul B Mahol [Wed, 25 Sep 2019 19:37:26 +0000 (21:37 +0200)]
avfilter/vf_zoompan: forward status back from output to input

8 months agoavfilter/vf_stack: add slice threading
Paul B Mahol [Wed, 25 Sep 2019 17:02:57 +0000 (19:02 +0200)]
avfilter/vf_stack: add slice threading

8 months agoavfilter/vf_stack: simplify main processing path
Paul B Mahol [Wed, 25 Sep 2019 16:40:56 +0000 (18:40 +0200)]
avfilter/vf_stack: simplify main processing path

8 months agoavformat/sdsdec: fix undefined behaviour
Paul B Mahol [Wed, 25 Sep 2019 16:01:09 +0000 (18:01 +0200)]
avformat/sdsdec: fix undefined behaviour

Fixes #8163, #8164, #8165.

8 months agoavformat/aiffdec: fix signed integer overflow
Paul B Mahol [Wed, 25 Sep 2019 15:36:52 +0000 (17:36 +0200)]
avformat/aiffdec: fix signed integer overflow

Fixes #8151

8 months agoavcodec/decode: Check max_samples in get_buffer_internal()
Michael Niedermayer [Wed, 25 Sep 2019 14:18:32 +0000 (16:18 +0200)]
avcodec/decode: Check max_samples in get_buffer_internal()

This checks max_samples at the same level as max_pixels

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
8 months agotools/target_dec_fuzzer: Set max_samples
Michael Niedermayer [Mon, 2 Sep 2019 22:04:00 +0000 (00:04 +0200)]
tools/target_dec_fuzzer: Set max_samples

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
8 months agoavcodec: add max_samples
Michael Niedermayer [Mon, 2 Sep 2019 21:17:57 +0000 (23:17 +0200)]
avcodec: add max_samples

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
8 months agoavfilter/Makefile: fix case for sierpinski
Paul B Mahol [Wed, 25 Sep 2019 12:15:55 +0000 (14:15 +0200)]
avfilter/Makefile: fix case for sierpinski

8 months agoavfilter: add sierpinski video source
Paul B Mahol [Mon, 12 Aug 2019 07:20:08 +0000 (09:20 +0200)]
avfilter: add sierpinski video source

8 months agoavfilter/vf_premultiply: forward status back from output to all input links
Paul B Mahol [Wed, 25 Sep 2019 11:02:39 +0000 (13:02 +0200)]
avfilter/vf_premultiply: forward status back from output to all input links

8 months agoavfilter/vf_fieldmatch: forward status back from output to all input links
Paul B Mahol [Wed, 25 Sep 2019 10:55:43 +0000 (12:55 +0200)]
avfilter/vf_fieldmatch: forward status back from output to all input links

Fixes #8199.

8 months agoavfilter/vf_fieldmatch: fix more leaks
Paul B Mahol [Wed, 25 Sep 2019 10:35:33 +0000 (12:35 +0200)]
avfilter/vf_fieldmatch: fix more leaks

8 months agoavfilter/vf_v360: add sinusoidal format
Paul B Mahol [Wed, 25 Sep 2019 10:01:54 +0000 (12:01 +0200)]
avfilter/vf_v360: add sinusoidal format

8 months agolavc/tiff: correct the default value of YCbCrSubsampling to 2x2
Pavel Skakov [Wed, 25 Sep 2019 08:47:46 +0000 (10:47 +0200)]
lavc/tiff: correct the default value of YCbCrSubsampling to 2x2

8 months agolavf/4xm: fix memory leak in error handing path
Jun Zhao [Mon, 23 Sep 2019 02:50:21 +0000 (10:50 +0800)]
lavf/4xm: fix memory leak in error handing path

need to free the header in error path.

Reviewed-by: Michael Niedermayer <michael@niedermayer.cc>
Signed-off-by: Jun Zhao <barryjzhao@tencent.com>
8 months agolibavcodec/libx265: add a flag to output ROI warnings only once.
Guo, Yejun [Mon, 23 Sep 2019 02:02:35 +0000 (10:02 +0800)]
libavcodec/libx265: add a flag to output ROI warnings only once.

Signed-off-by: Guo, Yejun <yejun.guo@intel.com>
8 months agolibavcodec/libx264: add a flag to output ROI warnings only once.
Guo, Yejun [Mon, 23 Sep 2019 02:02:34 +0000 (10:02 +0800)]
libavcodec/libx264: add a flag to output ROI warnings only once.

Signed-off-by: Guo, Yejun <yejun.guo@intel.com>
8 months agoavcodec/utils: Optimize ff_color_frame() using memcpy()
Michael Niedermayer [Mon, 24 Dec 2018 00:14:51 +0000 (01:14 +0100)]
avcodec/utils: Optimize ff_color_frame() using memcpy()

4650975 -> 4493240 dezicycles

This optimizes lines 2 and later. Line 1 still uses av_memcpy_backptr()
This change originally fixed ossfuzz 10790 but this is now fixed by other
optimizations already

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
8 months agoavcodec/aacdec: Check if we run out of input in read_stream_mux_config()
Michael Niedermayer [Sun, 8 Sep 2019 19:08:31 +0000 (21:08 +0200)]
avcodec/aacdec: Check if we run out of input in read_stream_mux_config()

Fixes: Infinite loop
Fixes: 16920/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_AAC_LATM_fuzzer-5653421289373696

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
8 months agoavcodec/h264_slice: clear frame only on gaps when it is not otherwise initilaized
Michael Niedermayer [Sun, 8 Sep 2019 17:27:26 +0000 (19:27 +0200)]
avcodec/h264_slice: clear frame only on gaps when it is not otherwise initilaized

Fixes: Timeout (53sec -> 31sec)
Fixes: 16908/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_H264_fuzzer-5711207859748864

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
8 months agoavcodec/utils: Use av_memcpy_backptr() in ff_color_frame()
Michael Niedermayer [Sun, 8 Sep 2019 15:25:07 +0000 (17:25 +0200)]
avcodec/utils: Use av_memcpy_backptr() in ff_color_frame()

Fixes: Timeout (191sec -> 53sec)
Fixes: 16908/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_H264_fuzzer-5711207859748864
Fixes: 10709/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_H264_fuzzer-5630617975259136

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
8 months agoavcodec/smacker: Fix integer overflow in signed int multiply in SMK_BLK_FILL
Michael Niedermayer [Fri, 6 Sep 2019 08:55:26 +0000 (10:55 +0200)]
avcodec/smacker: Fix integer overflow in signed int multiply in SMK_BLK_FILL

Fixes: signed integer overflow: 238 * 16843009 cannot be represented in type 'int'
Fixes: 16958/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_SMACKER_fuzzer-5193905355620352

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
8 months agoavcodec/alac: Fix invalid shifts in 20/24 bps
Michael Niedermayer [Fri, 6 Sep 2019 08:46:38 +0000 (10:46 +0200)]
avcodec/alac: Fix invalid shifts in 20/24 bps

Fixes: left shift of negative value -256
Fixes: 16892/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ALAC_fuzzer-4880802642395136

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
8 months agoavcodec/alac: fix undefined behavior with INT_MIN in lpc_prediction()
Michael Niedermayer [Fri, 6 Sep 2019 08:36:43 +0000 (10:36 +0200)]
avcodec/alac: fix undefined behavior with INT_MIN in lpc_prediction()

Fixes: signed integer overflow: -2147483648 * -1 cannot be represented in type 'int'
Fixes: 16786/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ALAC_fuzzer-5632818851348480

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
8 months agoavformat/utils: Do not assume duration is non negative in compute_pkt_fields()
Michael Niedermayer [Thu, 5 Sep 2019 21:06:21 +0000 (23:06 +0200)]
avformat/utils: Do not assume duration is non negative in compute_pkt_fields()

Several subtitle demuxers set negative durations

Fixes: signed integer overflow: 9223372036854775807 - -1 cannot be represented in type 'long'
Fixes: 16925/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-5766519790764032

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
8 months agoavcodec/ffwavesynth: Fix integer overflow in timestamps
Michael Niedermayer [Thu, 5 Sep 2019 18:47:04 +0000 (20:47 +0200)]
avcodec/ffwavesynth: Fix integer overflow in timestamps

Fixes: signed integer overflow: 9223371075321077760 * 2 cannot be represented in type 'long'
Fixes: 16447/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_FFWAVESYNTH_fuzzer-5698937431785472

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
8 months agoavformat/vividas: Test size and packet numbers a bit more
Michael Niedermayer [Wed, 4 Sep 2019 14:30:00 +0000 (16:30 +0200)]
avformat/vividas: Test size and packet numbers a bit more

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
8 months agoavformat/vividas: Check n_sb_blocks against input space
Michael Niedermayer [Wed, 4 Sep 2019 14:18:35 +0000 (16:18 +0200)]
avformat/vividas: Check n_sb_blocks against input space

Fixes: OOM
Fixes: 16726/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-5719320750981120

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
8 months agoavcodec/aacdec_fixed: Add FF_CODEC_CAP_INIT_CLEANUP
Michael Niedermayer [Wed, 4 Sep 2019 13:19:46 +0000 (15:19 +0200)]
avcodec/aacdec_fixed: Add FF_CODEC_CAP_INIT_CLEANUP

Fixes: memleaks
Fixes: 16788/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_AAC_FIXED_fuzzer-5649873898045440

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
8 months agotools/target_dec_fuzzer: consider potential padding/edge in pixel threshold
Michael Niedermayer [Wed, 4 Sep 2019 12:24:48 +0000 (14:24 +0200)]
tools/target_dec_fuzzer: consider potential padding/edge in pixel threshold

Fixes: Timeout (73sec ->30ms)
Fixes: 16921/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_DIRAC_fuzzer-5689384594046976

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
8 months agolibavcodec/mpeg12dec: Check input for minimal frame size
Michael Niedermayer [Wed, 4 Sep 2019 13:09:09 +0000 (15:09 +0200)]
libavcodec/mpeg12dec: Check input for minimal frame size

Fixes: Timeout (35sec -> 6sec)
Fixes: 16901/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MPEGVIDEO_fuzzer-5729024726269952
Fixes: 16901/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MPEGVIDEO_fuzzer-5642388592132096

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
8 months agotools/target_dec_fuzzer: Adjust threshold for MSS2
Michael Niedermayer [Sun, 1 Sep 2019 18:33:58 +0000 (20:33 +0200)]
tools/target_dec_fuzzer: Adjust threshold for MSS2

The decoder is slow

Fixes: Timeout (94sec -> 7sec)
Fixes: 16417/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MSS2_fuzzer-5711668050395136

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
8 months agoavcodec/cbs_h264: Automatically free SEI payload on error
Andreas Rheinhardt [Wed, 11 Sep 2019 22:18:29 +0000 (00:18 +0200)]
avcodec/cbs_h264: Automatically free SEI payload on error

If adding an SEI message to an access unit fails, said SEI message was
not touched, so that the caller had to free any data associated with it
that might need to be freed. But given that ff_cbs_h264_add_sei_message
can simply call cbs_h264_free_sei_payload, one can easily free
the content of the SEI payload.

This fixes a memleak when inserting a user data unregistered string for
h264_metadata fails.

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com>
8 months agoavcodec/dxv: Check op_offset in both directions
Michael Niedermayer [Wed, 26 Jun 2019 22:29:06 +0000 (00:29 +0200)]
avcodec/dxv: Check op_offset in both directions

Fixes: signed integer overflow: 61 + 2147483647 cannot be represented in type 'int'
Fixes: 15311/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_DXV_fuzzer-5742552826773504

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
8 months agoavcodec/truespeech: Eliminate some left shifts
Michael Niedermayer [Fri, 20 Sep 2019 18:16:54 +0000 (20:16 +0200)]
avcodec/truespeech: Eliminate some left shifts

This avoids some invalid shifts

Reviewed-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
8 months agoavcodec/adpcm: Check number of channels for MTAF
Michael Niedermayer [Mon, 23 Sep 2019 21:52:04 +0000 (23:52 +0200)]
avcodec/adpcm: Check number of channels for MTAF

Fixes: out of array access
Fixes: 17608/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ADPCM_MTAF_fuzzer-5074936267276288

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Reviewed-by: Paul B Mahol <onemda@gmail.com>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
8 months agoavcodec/nvenc: fix typo in new Windows driver version
Timo Rothenpieler [Tue, 24 Sep 2019 10:00:00 +0000 (12:00 +0200)]
avcodec/nvenc: fix typo in new Windows driver version

Signed-off-by: Timo Rothenpieler <timo@rothenpieler.org>
8 months agoavfilter/vf_v360: do not use mod where it is not needed
Paul B Mahol [Tue, 24 Sep 2019 09:26:46 +0000 (11:26 +0200)]
avfilter/vf_v360: do not use mod where it is not needed

8 months agoavcodec/exr: cosmetics
Limin Wang [Mon, 23 Sep 2019 13:31:33 +0000 (21:31 +0800)]
avcodec/exr: cosmetics

Signed-off-by: Limin Wang <lance.lmwang@gmail.com>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
8 months agoavformat/hashenc: fix incorrect use of av_mallocz_array()
Moritz Barsnick [Sun, 22 Sep 2019 12:24:11 +0000 (14:24 +0200)]
avformat/hashenc: fix incorrect use of av_mallocz_array()

Fixes CID 1453867, CID 1453866, CID 1453865.

Signed-off-by: Moritz Barsnick <barsnick@gmx.net>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
8 months agoavcodec/nvenc: add driver version info for SDK 9.1
Timo Rothenpieler [Mon, 23 Sep 2019 13:47:27 +0000 (15:47 +0200)]
avcodec/nvenc: add driver version info for SDK 9.1

Signed-off-by: Timo Rothenpieler <timo@rothenpieler.org>
8 months agoavcodec/bsf: check that AVBSFInternal was allocated before dereferencing it
James Almer [Mon, 23 Sep 2019 02:55:49 +0000 (23:55 -0300)]
avcodec/bsf: check that AVBSFInternal was allocated before dereferencing it

This can happen when av_bsf_free() is called on av_bsf_alloc() failure.

Reviewed-by: Paul B Mahol <onemda@gmail.com>
Signed-off-by: James Almer <jamrial@gmail.com>