avformat/matroskadec: Fix float-cast-overflow undefined behavior in matroska_parse_tr...
authorNikolas Bowe <nbowe-at-google.com@ffmpeg.org>
Thu, 18 Jan 2018 23:21:56 +0000 (15:21 -0800)
committerMichael Niedermayer <michael@niedermayer.cc>
Fri, 19 Jan 2018 21:33:31 +0000 (22:33 +0100)
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
libavformat/matroskadec.c

index 496499b..158ce7a 100644 (file)
@@ -2096,8 +2096,16 @@ static int matroska_parse_tracks(AVFormatContext *s)
         }
 
         if (track->type == MATROSKA_TRACK_TYPE_VIDEO) {
-            if (!track->default_duration && track->video.frame_rate > 0)
-                track->default_duration = 1000000000 / track->video.frame_rate;
+            if (!track->default_duration && track->video.frame_rate > 0) {
+                double default_duration = 1000000000 / track->video.frame_rate;
+                if (default_duration > UINT64_MAX || default_duration < 0) {
+                    av_log(matroska->ctx, AV_LOG_WARNING,
+                         "Invalid frame rate %e. Cannot calculate default duration.\n",
+                         track->video.frame_rate);
+                } else {
+                    track->default_duration = default_duration;
+                }
+            }
             if (track->video.display_width == -1)
                 track->video.display_width = track->video.pixel_width;
             if (track->video.display_height == -1)