avformat/dss: Check sscanf() return value in dss_read_metadata_date()
authorMichael Niedermayer <michaelni@gmx.at>
Thu, 19 Feb 2015 21:10:47 +0000 (22:10 +0100)
committerMichael Niedermayer <michaelni@gmx.at>
Thu, 19 Feb 2015 21:10:47 +0000 (22:10 +0100)
Fixes writing uninitialized values into metadata without error in case
parsing fails

Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
libavformat/dss.c

index f4355f1..a353ee0 100644 (file)
@@ -78,7 +78,8 @@ static int dss_read_metadata_date(AVFormatContext *s, unsigned int offset,
     if (ret < DSS_TIME_SIZE)
         return ret < 0 ? ret : AVERROR_EOF;
 
-    sscanf(string, "%2d%2d%2d%2d%2d%2d", &y, &month, &d, &h, &minute, &sec);
+    if (sscanf(string, "%2d%2d%2d%2d%2d%2d", &y, &month, &d, &h, &minute, &sec) != 6)
+        return AVERROR_INVALIDDATA;
     /* We deal with a two-digit year here, so set the default date to 2000
      * and hope it will never be used in the next century. */
     snprintf(datetime, sizeof(datetime), "%.4d-%.2d-%.2dT%.2d:%.2d:%.2d",