avcodec/bmp_parser: fix parsing a single bmp which has a fsize < its header
authorMichael Niedermayer <michaelni@gmx.at>
Sat, 13 Sep 2014 14:43:27 +0000 (16:43 +0200)
committerMichael Niedermayer <michaelni@gmx.at>
Sat, 13 Sep 2014 15:10:13 +0000 (17:10 +0200)
Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
libavcodec/bmp_parser.c

index eae8ae0..25fdd27 100644 (file)
@@ -45,21 +45,32 @@ static int bmp_parse(AVCodecParserContext *s, AVCodecContext *avctx,
     int i = 0;
 
     *poutbuf_size = 0;
-    if (buf_size == 0)
-        return 0;
 
-    if (!bpc->pc.frame_start_found) {
+    if (bpc->pc.frame_start_found <= 2+4+4) {
         for (; i < buf_size; i++) {
             state = (state << 8) | buf[i];
-            if ((state >> 48) == (('B' << 8) | 'M')) {
-                bpc->fsize = av_bswap32(state >> 16);
-                bpc->pc.frame_start_found = 1;
-                if (bpc->fsize > buf_size - i + 7)
-                    bpc->remaining_size = bpc->fsize - buf_size + i - 7;
+            if (bpc->pc.frame_start_found == 0) {
+                if ((state >> 48) == (('B' << 8) | 'M')) {
+                    bpc->fsize = av_bswap32(state >> 16);
+                    bpc->pc.frame_start_found = 1;
+                }
+            } else if (bpc->pc.frame_start_found == 2+4+4) {
+//                 unsigned hsize = av_bswap32(state>>32);
+                unsigned ihsize = av_bswap32(state);
+                if (ihsize < 12 || ihsize > 200) {
+                    bpc->pc.frame_start_found = 0;
+                    continue;
+                }
+                if (bpc->fsize <= ihsize + 14)
+                    bpc->fsize = INT_MAX/2;
+                bpc->pc.frame_start_found++;
+                if (bpc->fsize > buf_size - i + 17)
+                    bpc->remaining_size = bpc->fsize - buf_size + i - 17;
                 else
-                    next = bpc->fsize + i - 7;
+                    next = bpc->fsize + i - 17;
                 break;
-            }
+            } else if (bpc->pc.frame_start_found)
+                bpc->pc.frame_start_found++;
         }
         bpc->pc.state64 = state;
     } else {