avformat/httpauth: add comment about "" and algorithm
authorMichael Niedermayer <michaelni@gmx.at>
Mon, 3 Mar 2014 16:04:57 +0000 (17:04 +0100)
committerMichael Niedermayer <michaelni@gmx.at>
Mon, 3 Mar 2014 16:04:57 +0000 (17:04 +0100)
Suggested-by: ubitux
Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
libavformat/httpauth.c

index 3f90975..dbe3eff 100644 (file)
@@ -224,8 +224,11 @@ static char *make_digest_auth(HTTPAuthState *state, const char *username,
     av_strlcatf(authstr, len, ",nonce=\"%s\"",     digest->nonce);
     av_strlcatf(authstr, len, ",uri=\"%s\"",       uri);
     av_strlcatf(authstr, len, ",response=\"%s\"",  response);
+
+    // we are violating the RFC and use "" because all others seem to do that too.
     if (digest->algorithm[0])
         av_strlcatf(authstr, len, ",algorithm=\"%s\"",  digest->algorithm);
+
     if (digest->opaque[0])
         av_strlcatf(authstr, len, ",opaque=\"%s\"", digest->opaque);
     if (digest->qop[0]) {