avfilter/f_setcmd: fix null pointer dereference on using dash as interval
authorMarton Balint <cus@passwd.hu>
Wed, 8 Feb 2017 23:03:21 +0000 (00:03 +0100)
committerMarton Balint <cus@passwd.hu>
Sun, 19 Feb 2017 15:43:53 +0000 (16:43 +0100)
Fixes Coverity CID 1396259.

Reviewed-by: Paul B Mahol <onemda@gmail.com>
Signed-off-by: Marton Balint <cus@passwd.hu>
libavfilter/f_sendcmd.c

index fb30220..522d6ad 100644 (file)
@@ -268,6 +268,13 @@ static int parse_interval(Interval *interval, int interval_count,
         char *start, *end;
 
         start = av_strtok(intervalstr, "-", &end);
+        if (!start) {
+            ret = AVERROR(EINVAL);
+            av_log(log_ctx, AV_LOG_ERROR,
+                   "Invalid interval specification '%s' in interval #%d\n",
+                   intervalstr, interval_count);
+            goto end;
+        }
         if ((ret = av_parse_time(&interval->start_ts, start, 1)) < 0) {
             av_log(log_ctx, AV_LOG_ERROR,
                    "Invalid start time specification '%s' in interval #%d\n",