tests/tiny_ssim: check dimensions
authorMichael Niedermayer <michaelni@gmx.at>
Mon, 5 May 2014 16:39:30 +0000 (18:39 +0200)
committerMichael Niedermayer <michaelni@gmx.at>
Mon, 5 May 2014 16:47:24 +0000 (18:47 +0200)
Fix integer overflow

Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
tests/tiny_ssim.c

index fe65e47..767a0fe 100644 (file)
@@ -29,6 +29,7 @@
 
 #include "config.h"
 #include <inttypes.h>
+#include <limits.h>
 #include <math.h>
 #include <stdio.h>
 #include <stdlib.h>
@@ -195,7 +196,13 @@ int main(int argc, char* argv[])
     f[0] = fopen(argv[1], "rb");
     f[1] = fopen(argv[2], "rb");
     sscanf(argv[3], "%dx%d", &w, &h);
-    frame_size = w*h*3/2;
+
+    if (w<=0 || h<=0 || w*(int64_t)h >= INT_MAX/3 || 2LL*w+12 >= INT_MAX / sizeof(*temp)) {
+        fprintf(stderr, "Dimensions are too large\n");
+        return -2;
+    }
+
+    frame_size = w*h*3LL/2;
     for( i=0; i<2; i++ )
     {
         buf[i] = malloc(frame_size);