avcodec/wmv2dsp: Fix runtime error: signed integer overflow: 181 * -12156865 cannot...
authorMichael Niedermayer <michael@niedermayer.cc>
Sun, 7 May 2017 21:07:42 +0000 (23:07 +0200)
committerMichael Niedermayer <michael@niedermayer.cc>
Mon, 8 May 2017 01:25:17 +0000 (03:25 +0200)
Fixes: 1401/clusterfuzz-testcase-minimized-6526248148795392

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
libavcodec/wmv2dsp.c

index 162ac92..7a3a851 100644 (file)
@@ -78,8 +78,8 @@ static void wmv2_idct_col(short * b)
     a4 = (W0 * b[8 * 0] - W0 * b[8 * 4]    ) >> 3;
 
     /* step 2 */
-    s1 = (181 * (a1 - a5 + a7 - a3) + 128) >> 8;
-    s2 = (181 * (a1 - a5 - a7 + a3) + 128) >> 8;
+    s1 = (int)(181U * (a1 - a5 + a7 - a3) + 128) >> 8;
+    s2 = (int)(181U * (a1 - a5 - a7 + a3) + 128) >> 8;
 
     /* step 3 */
     b[8 * 0] = (a0 + a2 + a1 + a5 + (1 << 13)) >> 14;