avcodec/utils: add some saftey checks to add_metadata_from_side_data()
authorMichael Niedermayer <michaelni@gmx.at>
Sat, 19 Oct 2013 15:52:47 +0000 (17:52 +0200)
committerMichael Niedermayer <michaelni@gmx.at>
Sat, 19 Oct 2013 15:58:47 +0000 (17:58 +0200)
This fixes potential overreads with crafted files.

Found-by: wm4
Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
libavcodec/utils.c

index 3832b81..162d61d 100644 (file)
@@ -1952,10 +1952,17 @@ static int add_metadata_from_side_data(AVCodecContext *avctx, AVFrame *frame)
     if (!side_metadata)
         goto end;
     end = side_metadata + size;
+    if (size && end[-1])
+        return AVERROR_INVALIDDATA;
     while (side_metadata < end) {
         const uint8_t *key = side_metadata;
         const uint8_t *val = side_metadata + strlen(key) + 1;
-        int ret = av_dict_set(avpriv_frame_get_metadatap(frame), key, val, 0);
+        int ret;
+
+        if (val >= end)
+            return AVERROR_INVALIDDATA;
+
+        ret = av_dict_set(avpriv_frame_get_metadatap(frame), key, val, 0);
         if (ret < 0)
             break;
         side_metadata = val + strlen(val) + 1;