tools/coverity: Add models for av_mallocz and av_free
authorPhilip Langdale <philipl@overt.org>
Sun, 27 Nov 2016 19:16:18 +0000 (11:16 -0800)
committerPhilip Langdale <philipl@overt.org>
Wed, 30 Nov 2016 21:27:43 +0000 (13:27 -0800)
This should deal with some false positives, but might lead to
more of them depending on whether it realises that av_freep()
wraps av_free() or not.

tools/coverity.c

index 80fc1c2..3cc248c 100644 (file)
 void *av_malloc(size_t size) {
     int has_memory;
     __coverity_negative_sink__(size);
-    if(has_memory)
-        return __coverity_alloc__(size);
-    else
+    if (has_memory) {
+        void *ptr = __coverity_alloc__(size);
+        __coverity_mark_as_uninitialized_buffer__(ptr);
+        __coverity_mark_as_afm_allocated__(ptr, "av_free");
+         return ptr;
+    } else {
         return 0;
+    }
+}
+
+void *av_mallocz(size_t size) {
+    int has_memory;
+    __coverity_negative_sink__(size);
+    if (has_memory) {
+        void *ptr = __coverity_alloc__(size);
+        __coverity_writeall0__(ptr);
+        __coverity_mark_as_afm_allocated__(ptr, "av_free");
+        return ptr;
+    } else {
+        return 0;
+    }
+}
+
+void *av_free(void *ptr) {
+    __coverity_free__(ptr);
+    __coverity_mark_as_afm_freed__(ptr, "av_free");
 }