httpauth: Fix the length passed to av_strlcat
authorMartin Storsjö <martin@martin.st>
Thu, 3 Jun 2010 20:31:29 +0000 (20:31 +0000)
committerMartin Storsjö <martin@martin.st>
Thu, 3 Jun 2010 20:31:29 +0000 (20:31 +0000)
Since the buffer always was large enough, this bug didn't have any
effect in practice.

Originally committed as revision 23447 to svn://svn.ffmpeg.org/ffmpeg/trunk

libavformat/httpauth.c

index abdee81..799f84d 100644 (file)
@@ -303,7 +303,7 @@ char *ff_http_auth_create_response(HTTPAuthState *state, const char *auth,
         snprintf(authstr, len, "Authorization: Basic ");
         ptr = authstr + strlen(authstr);
         av_base64_encode(ptr, auth_b64_len, auth, strlen(auth));
-        av_strlcat(ptr, "\r\n", len);
+        av_strlcat(ptr, "\r\n", len - (ptr - authstr));
     } else if (state->auth_type == HTTP_AUTH_DIGEST) {
         char *username = av_strdup(auth), *password;