fixing an integer overflow, which could lead to overwriting the end of a malloced...
authorMichael Niedermayer <michaelni@gmx.at>
Fri, 4 Feb 2005 18:58:59 +0000 (18:58 +0000)
committerMichael Niedermayer <michaelni@gmx.at>
Fri, 4 Feb 2005 18:58:59 +0000 (18:58 +0000)
Originally committed as revision 3937 to svn://svn.ffmpeg.org/ffmpeg/trunk

libavformat/sierravmd.c

index 16b6a8d..b1484b5 100644 (file)
@@ -212,7 +212,8 @@ static int vmd_read_header(AVFormatContext *s,
 
         /* if the frame size is 0, do not count the frame and bring the
          * total frame count down */
-        vmd->frame_table[i].frame_size = LE_32(&current_frame_record[2]);
+        // note, we limit the size to 1Gb to ensure that we dont end up overflowing the size integer used to allocate the memory
+        vmd->frame_table[i].frame_size = LE_32(&current_frame_record[2]) & 0x3FFFFFFF; 
 
         /* this logic is present so that 0-length audio chunks are not
          * accounted */