Avoid a crash when H264 MMC operation causes the short term reference
authorJeff Downs <heydowns@borg.com>
Wed, 5 Sep 2007 20:04:09 +0000 (20:04 +0000)
committerBenoit Fouet <benoit.fouet@free.fr>
Wed, 5 Sep 2007 20:04:09 +0000 (20:04 +0000)
list to be emptied.
Patch by Jeff Downs: [heydowns borg com]

Originally committed as revision 10416 to svn://svn.ffmpeg.org/ffmpeg/trunk

libavcodec/h264.c

index a4d2a13..49eaa37 100644 (file)
@@ -3159,8 +3159,8 @@ static Picture * remove_short(H264Context *h, int frame_num){
             av_log(h->s.avctx, AV_LOG_DEBUG, "%d %d %p\n", i, pic->frame_num, pic);
         if(pic->frame_num == frame_num){
             h->short_ref[i]= NULL;
-            memmove(&h->short_ref[i], &h->short_ref[i+1], (h->short_ref_count - i - 1)*sizeof(Picture*));
-            h->short_ref_count--;
+            if (--h->short_ref_count)
+                memmove(&h->short_ref[i], &h->short_ref[i+1], (h->short_ref_count - i)*sizeof(Picture*));
             return pic;
         }
     }