adpcm: Write the proper predictor in trellis mode in IMA QT
authorMartin Storsjö <martin@martin.st>
Fri, 6 Jun 2014 09:03:09 +0000 (12:03 +0300)
committerMichael Niedermayer <michaelni@gmx.at>
Fri, 6 Jun 2014 15:08:21 +0000 (17:08 +0200)
commitfa8f060b75bf9074792a0f9ff4ed002652ef62b8
tree886251304a86ddecc841d56a0bf02022104fee1e
parentfb7646d92cba547b88ce82bfcc093eb57caf1dde
adpcm: Write the proper predictor in trellis mode in IMA QT

The actual predictor value, set by the trellis code, never
was written back into the variable that was written into
the block header. This was accidentally removed in b304244b.

This significantly improves the audio quality of the trellis
case, which was plain broken since b304244b.

Encoding IMA QT with trellis still actually gives a slightly
worse quality than without trellis, since the trellis encoder
doesn't use the exact same way of rounding as in
adpcm_ima_qt_compress_sample and adpcm_ima_qt_expand_nibble.

Fixes part of Ticket3701

Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
libavcodec/adpcmenc.c
tests/ref/acodec/adpcm-ima_qt-trellis