avcodec/bsf: make sure the AVBSFInternal stored packet is reference counted
authorJames Almer <jamrial@gmail.com>
Fri, 23 Mar 2018 21:16:11 +0000 (18:16 -0300)
committerJames Almer <jamrial@gmail.com>
Sat, 24 Mar 2018 01:10:39 +0000 (22:10 -0300)
commited1f08bfb5500340463e630290360609a90d2886
tree38ff15dd965666f9ae77905bff1392bfe12901eb
parent231a73308f183484317c3fdfe098f543cd401898
avcodec/bsf: make sure the AVBSFInternal stored packet is reference counted

Some bitstream filters may buffer said packet in their own contexts
for latter use. The documentation for av_bsf_send_packet() doesn't
forbid feeding it non-reference counted packets, which depending on
the way said packets were internally buffered by the bsf it may
result in the data described in them becoming invalid or unavailable
at any time.
This was the case with vp9_superframe after commit e1bc3f4396, which
was then promptly fixed in 37f4a093f7 and 7a02b364b6. It is still the
case even today with vp9_reorder_raw.

With this change the bitstream filters will not have to worry how to
store or consume the packets fed to them.

Reviewed-by: wm4 <nfxjfg@googlemail.com>
Signed-off-by: James Almer <jamrial@gmail.com>
libavcodec/bsf.c