compat/atomics: add typecasts in atomic_compare_exchange_strong()
authorWan-Teh Chang <wtc@google.com>
Sat, 3 Dec 2016 00:56:16 +0000 (16:56 -0800)
committerVittorio Giovara <vittorio.giovara@gmail.com>
Thu, 8 Dec 2016 20:53:58 +0000 (15:53 -0500)
commit6a93b596c5c3af31b843d63013a7985ffeea354d
tree023ffd3b217ea2541f3f1bd71440d2d6a93c63c4
parent2170017a1cd033b6f28e16476921022712a522d8
compat/atomics: add typecasts in atomic_compare_exchange_strong()

The Solaris and Windows emulations of atomic_compare_exchange_strong()
need typecasts to avoid compiler warnings, because the functions they
call expect a void* pointer but an intptr_t integer is passed.

Note that the emulations of atomic_compare_exchange_strong() (except
the gcc version) only work for atomic_intptr_t because of the type of
the second argument (|expected|). See
http://en.cppreference.com/w/c/atomic:

_Bool atomic_compare_exchange_strong( volatile A* obj,
                                      C* expected, C desired );

The types of the first argument and second argument are different
(|A| and |C|, respectively). |C| is the non-atomic type corresponding
to |A|. In the emulations of atomic_compare_exchange_strong(), |C| is
intptr_t. This implies |A| can only be sig_intptr_t.

Signed-off-by: Wan-Teh Chang <wtc@google.com>
compat/atomics/suncc/stdatomic.h
compat/atomics/win32/stdatomic.h